From 0063eef05f3d8eae44b93e8c13e33af08a64c383 Mon Sep 17 00:00:00 2001 From: Axel Uhl Date: Sun, 9 Nov 2025 16:39:27 +0100 Subject: [PATCH] RolePrototype doesn't have to be serializable; removed Named interface --- .../sailing/domain/common/subscription/PremiumRole.java | 1 - .../com/sap/sailing/expeditionconnector/UDPMirror.java | 1 - .../sap/sailing/server/security/EventManagerRole.java | 1 - .../sap/sailing/server/security/SailingViewerRole.java | 2 -- .../src/com/sap/sse/security/shared/AdminRole.java | 1 - .../src/com/sap/sse/security/shared/RolePrototype.java | 9 +++------ .../src/com/sap/sse/security/shared/ServerAdminRole.java | 2 -- .../src/com/sap/sse/security/shared/UserRole.java | 2 -- .../security/shared/subscription/AllDataMiningRole.java | 1 - .../shared/subscription/ArchiveDataMiningRole.java | 1 - 10 files changed, 3 insertions(+), 18 deletions(-) diff --git a/java/com.sap.sailing.domain.common/src/com/sap/sailing/domain/common/subscription/PremiumRole.java b/java/com.sap.sailing.domain.common/src/com/sap/sailing/domain/common/subscription/PremiumRole.java index 06f27ea1aa5..5be47a1112a 100644 --- a/java/com.sap.sailing.domain.common/src/com/sap/sailing/domain/common/subscription/PremiumRole.java +++ b/java/com.sap.sailing.domain.common/src/com/sap/sailing/domain/common/subscription/PremiumRole.java @@ -13,7 +13,6 @@ import com.sap.sse.security.shared.impl.SecuredSecurityTypes; */ public class PremiumRole extends RolePrototype { private static final UUID ROLE_ID = UUID.fromString("7021e7a2-569a-11ec-bf63-0242ac130002"); - private static final long serialVersionUID = 8032532973066767581L; private static final PremiumRole INSTANCE = new PremiumRole(); PremiumRole() { diff --git a/java/com.sap.sailing.expeditionconnector/src/com/sap/sailing/expeditionconnector/UDPMirror.java b/java/com.sap.sailing.expeditionconnector/src/com/sap/sailing/expeditionconnector/UDPMirror.java index 187d904bd91..962d5f2adda 100755 --- a/java/com.sap.sailing.expeditionconnector/src/com/sap/sailing/expeditionconnector/UDPMirror.java +++ b/java/com.sap.sailing.expeditionconnector/src/com/sap/sailing/expeditionconnector/UDPMirror.java @@ -30,7 +30,6 @@ public class UDPMirror { } int listeningOnPort = Integer.valueOf(args[c++]); byte[] buf = new byte[65536]; - @SuppressWarnings("resource") // Can't close resource due to the infinite loop. Will be closed, when the thread is terminated. DatagramSocket udpSocket = new DatagramSocket(listeningOnPort); DatagramPacket received = new DatagramPacket(buf, buf.length); DatagramSocket[] sendingSockets = new DatagramSocket[(args.length - 1) / 2]; diff --git a/java/com.sap.sailing.server/src/com/sap/sailing/server/security/EventManagerRole.java b/java/com.sap.sailing.server/src/com/sap/sailing/server/security/EventManagerRole.java index 3682aa1e443..fbccdb5c600 100644 --- a/java/com.sap.sailing.server/src/com/sap/sailing/server/security/EventManagerRole.java +++ b/java/com.sap.sailing.server/src/com/sap/sailing/server/security/EventManagerRole.java @@ -13,7 +13,6 @@ import com.sap.sse.security.shared.impl.SecuredSecurityTypes.ServerActions; * server infrastructure configuration. */ public class EventManagerRole extends RolePrototype { - private static final long serialVersionUID = 6775068846340911064L; private static final EventManagerRole INSTANCE = new EventManagerRole(); EventManagerRole() { diff --git a/java/com.sap.sailing.server/src/com/sap/sailing/server/security/SailingViewerRole.java b/java/com.sap.sailing.server/src/com/sap/sailing/server/security/SailingViewerRole.java index db26fc0e73a..46adf8b7bc2 100644 --- a/java/com.sap.sailing.server/src/com/sap/sailing/server/security/SailingViewerRole.java +++ b/java/com.sap.sailing.server/src/com/sap/sailing/server/security/SailingViewerRole.java @@ -11,8 +11,6 @@ import com.sap.sse.security.shared.impl.SecuredSecurityTypes; * page and basic analytical frontends. */ public class SailingViewerRole extends RolePrototype { - private static final long serialVersionUID = 3291793984984443193L; - private static final SailingViewerRole INSTANCE = new SailingViewerRole(); SailingViewerRole() { diff --git a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/AdminRole.java b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/AdminRole.java index a78e653c015..0508d045768 100755 --- a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/AdminRole.java +++ b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/AdminRole.java @@ -1,7 +1,6 @@ package com.sap.sse.security.shared; public class AdminRole extends RolePrototype { - private static final long serialVersionUID = 3291793984984443193L; private static final AdminRole INSTANCE = new AdminRole(); private static final String UUID_STRING = "dc77e3d1-d405-435e-8699-ce7245f6fd7a"; diff --git a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/RolePrototype.java b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/RolePrototype.java index d2bc66ceffb..149ae9893a6 100755 --- a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/RolePrototype.java +++ b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/RolePrototype.java @@ -4,13 +4,10 @@ import java.util.HashSet; import java.util.Set; import java.util.UUID; -import com.sap.sse.common.NamedWithID; import com.sap.sse.common.Util; +import com.sap.sse.common.WithID; -public abstract class RolePrototype implements NamedWithID { - - private static final long serialVersionUID = -3911998376131317304L; - +public abstract class RolePrototype implements WithID { /* * Might be used in Stringmessages to identify SubscriptionplanRoles. Do check and validate before changing. */ @@ -40,7 +37,7 @@ public abstract class RolePrototype implements NamedWithID { } } - @Override +// @Override public String getName() { return name; } diff --git a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/ServerAdminRole.java b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/ServerAdminRole.java index 890b23aea3d..504dd95a981 100644 --- a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/ServerAdminRole.java +++ b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/ServerAdminRole.java @@ -14,8 +14,6 @@ import com.sap.sse.security.shared.impl.SecuredSecurityTypes; * */ public class ServerAdminRole extends RolePrototype { - private static final long serialVersionUID = -4196925850206436676L; - private static final ServerAdminRole INSTANCE = new ServerAdminRole(); ServerAdminRole() { diff --git a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/UserRole.java b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/UserRole.java index 050f7481d55..9f6ad1d8bfa 100755 --- a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/UserRole.java +++ b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/UserRole.java @@ -4,8 +4,6 @@ import com.sap.sse.security.shared.HasPermissions.DefaultActions; import com.sap.sse.security.shared.impl.SecuredSecurityTypes; public class UserRole extends RolePrototype { - private static final long serialVersionUID = 3291793984984443193L; - private static final UserRole INSTANCE = new UserRole(); UserRole() { diff --git a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/subscription/AllDataMiningRole.java b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/subscription/AllDataMiningRole.java index aa738c08ba3..3e899149116 100644 --- a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/subscription/AllDataMiningRole.java +++ b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/subscription/AllDataMiningRole.java @@ -10,7 +10,6 @@ import com.sap.sse.security.shared.impl.SecuredSecurityTypes; * Specifies a role that when associated to a user gives access to the date mining functionality on all servers. */ public class AllDataMiningRole extends RolePrototype { - private static final long serialVersionUID = 6671501683896115261L; private static final UUID ROLE_ID = UUID.fromString("de4205b5-ccf9-49b2-91e1-9a41b4db166b"); private static final AllDataMiningRole INSTANCE = new AllDataMiningRole(); diff --git a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/subscription/ArchiveDataMiningRole.java b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/subscription/ArchiveDataMiningRole.java index 20c60e713b5..63b889f4a39 100644 --- a/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/subscription/ArchiveDataMiningRole.java +++ b/java/com.sap.sse.security.common/src/com/sap/sse/security/shared/subscription/ArchiveDataMiningRole.java @@ -10,7 +10,6 @@ import com.sap.sse.security.shared.impl.SecuredSecurityTypes; * Specifies a role that when associated to a user gives access to the date mining functionality on archive server. */ public class ArchiveDataMiningRole extends RolePrototype { - private static final long serialVersionUID = 6671501683896115261L; private static final UUID ROLE_ID = UUID.fromString("f2993a7a-c08d-11ec-9d64-0242ac120002"); private static final ArchiveDataMiningRole INSTANCE = new ArchiveDataMiningRole();