From 09d747e763b2a328652f4fb022e21ad99be70985 Mon Sep 17 00:00:00 2001
From: Axel Uhl <axel.uhl@sap.com>
Date: Fri, 8 Jun 2012 16:50:07 +0200
Subject: [PATCH] added test case for empty ISAF ID

---
 .../sap/sailing/kiworesultimport/test/ParserTest.java    | 9 +++++++++
 .../sap/sailing/kiworesultimport/impl/SkipperImpl.java   | 8 ++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/java/com.sap.sailing.kiworesultimport.test/src/com/sap/sailing/kiworesultimport/test/ParserTest.java b/java/com.sap.sailing.kiworesultimport.test/src/com/sap/sailing/kiworesultimport/test/ParserTest.java
index ed2fd3cc502..0f7dc86b311 100755
--- a/java/com.sap.sailing.kiworesultimport.test/src/com/sap/sailing/kiworesultimport/test/ParserTest.java
+++ b/java/com.sap.sailing.kiworesultimport.test/src/com/sap/sailing/kiworesultimport/test/ParserTest.java
@@ -3,6 +3,7 @@ package com.sap.sailing.kiworesultimport.test;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -57,6 +58,14 @@ public class ParserTest {
         return getInputStream("2011-06-18_49er_Wettfahrt_2_Extra.xml");
     }
     
+    @Test
+    public void testEmptyIsafID() throws FileNotFoundException, SAXException, IOException, ParserConfigurationException {
+        ResultListParser parser = ResultListParserFactory.INSTANCE.createResultListParser();
+        ResultList resultList = parser.parse(getSampleInputStream());
+        assertNotNull(resultList);
+        assertNull(resultList.getVerteilung().getBoatBySailID("SWE 1196").getCrew().getSkipper().getIsaf());
+    }
+    
     @Test
     public void testObtainingResultList() throws FileNotFoundException, SAXException, IOException, ParserConfigurationException {
         ResultListParser parser = ResultListParserFactory.INSTANCE.createResultListParser();
diff --git a/java/com.sap.sailing.kiworesultimport/src/com/sap/sailing/kiworesultimport/impl/SkipperImpl.java b/java/com.sap.sailing.kiworesultimport/src/com/sap/sailing/kiworesultimport/impl/SkipperImpl.java
index adb95d1a0d0..da549f1f825 100755
--- a/java/com.sap.sailing.kiworesultimport/src/com/sap/sailing/kiworesultimport/impl/SkipperImpl.java
+++ b/java/com.sap.sailing.kiworesultimport/src/com/sap/sailing/kiworesultimport/impl/SkipperImpl.java
@@ -16,7 +16,11 @@ public class SkipperImpl extends NamedImpl implements Skipper {
 
     @Override
     public URL getIsaf() throws MalformedURLException, DOMException {
-        return new URL(getNode().getAttributes().getNamedItem("isaf").getNodeValue());
+        final String nodeValue = getNode().getAttributes().getNamedItem("isaf").getNodeValue();
+        URL result = null;
+        if (nodeValue != null && nodeValue.trim().length() > 0) {
+            result = new URL(nodeValue);
+        }
+        return result;
     }
-
 }