From 2c0b8b0fa19eb76fabcb4469bcffbb4f676e1af1 Mon Sep 17 00:00:00 2001 From: Papick Garcia Taboada Date: Mon, 15 Dec 2014 13:36:47 +0100 Subject: [PATCH] Issue 2504: workaround for overflowing slick-track element on some chrome instances. --- .../controls/carousel/ImageCarousel.java | 18 +++++++++++++++++- .../controls/carousel/ImageCarousel.ui.xml | 2 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/controls/carousel/ImageCarousel.java b/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/controls/carousel/ImageCarousel.java index 9959e5d1e65..a5456c8f101 100644 --- a/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/controls/carousel/ImageCarousel.java +++ b/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/controls/carousel/ImageCarousel.java @@ -4,6 +4,7 @@ import com.google.gwt.core.client.GWT; import com.google.gwt.core.client.Scheduler; import com.google.gwt.dom.client.DivElement; import com.google.gwt.dom.client.Document; +import com.google.gwt.dom.client.Element; import com.google.gwt.dom.client.ImageElement; import com.google.gwt.dom.client.Style.Unit; import com.google.gwt.safehtml.shared.UriUtils; @@ -118,7 +119,14 @@ public class ImageCarousel extends Widget { slidesToShow : 2 }); - + $wnd + .$( + '.' + + (sliderReference.@com.sap.sse.gwt.client.controls.carousel.ImageCarousel::uniqueId) + + '>.slick-list>.slick-track') + .height( + sliderReference.@com.sap.sse.gwt.client.controls.carousel.ImageCarousel::imagesHeight + + 'px'); }-*/; /** @@ -241,6 +249,14 @@ public class ImageCarousel extends Widget { public void execute() { try { setupSlider(reference); + + for (int childIndex = 0; childIndex < getElement().getChildCount(); childIndex++) { + Element child = Element.as(getElement().getChild(childIndex)); + if (child.getClassName() != null && child.getClassName().contains("slick-track")) { + + } + } + } catch (Exception e) { GWT.log("Catched Exception on slider init", e); } diff --git a/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/controls/carousel/ImageCarousel.ui.xml b/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/controls/carousel/ImageCarousel.ui.xml index facd729c473..0d0c61a39b2 100644 --- a/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/controls/carousel/ImageCarousel.ui.xml +++ b/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/controls/carousel/ImageCarousel.ui.xml @@ -7,7 +7,7 @@ } .slider .slick-track { - + overflow-y:hidden; } .slider li { width: 10px;