From 2dbf2bd9d030d74d4622311ef6e0499488fd6c8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kai=20B=C3=B6rnert?= Date: Wed, 5 Dec 2018 10:03:53 +0100 Subject: [PATCH] fixed deletion of RoleDefinition --- .../security/ui/server/UserManagementServiceImpl.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/server/UserManagementServiceImpl.java b/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/server/UserManagementServiceImpl.java index a54c48f7cb3..b191caf317e 100644 --- a/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/server/UserManagementServiceImpl.java +++ b/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/server/UserManagementServiceImpl.java @@ -31,6 +31,7 @@ import com.sap.sse.common.Util; import com.sap.sse.common.Util.Pair; import com.sap.sse.common.Util.Triple; import com.sap.sse.common.mail.MailException; +import com.sap.sse.security.Action; import com.sap.sse.security.ActionWithResult; import com.sap.sse.security.Credential; import com.sap.sse.security.SecurityService; @@ -125,8 +126,14 @@ public class UserManagementServiceImpl extends RemoteServiceServlet implements U @Override public void deleteRoleDefinition(String roleIdAsString) { - SecurityUtils.getSubject().checkPermission(SecuredSecurityTypes.ROLE_DEFINITION.getStringPermissionForObjects(DefaultActions.DELETE, roleIdAsString)); - getSecurityService().deleteRoleDefinition(getSecurityService().getRoleDefinition(UUID.fromString(roleIdAsString))); + getSecurityService().checkPermissionAndDeleteOwnershipForObjectRemoval(SecuredSecurityTypes.ROLE_DEFINITION, + roleIdAsString, new Action() { + @Override + public void run() throws Exception { + getSecurityService().deleteRoleDefinition( + getSecurityService().getRoleDefinition(UUID.fromString(roleIdAsString))); + } + }); } @Override