diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/raceboard/RaceBoardEntryPoint.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/raceboard/RaceBoardEntryPoint.java index a9946a18a33..5fd8d3a7f1c 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/raceboard/RaceBoardEntryPoint.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/raceboard/RaceBoardEntryPoint.java @@ -32,31 +32,26 @@ public class RaceBoardEntryPoint extends AbstractEntryPoint { @Override public void onModuleLoad() { super.onModuleLoad(); - eventName = Window.Location.getParameter("eventName"); raceName = Window.Location.getParameter("raceName"); String leaderboardNameParamValue = Window.Location.getParameter("leaderboardName"); String leaderboardGroupNameParamValue = Window.Location.getParameter("leaderboardGroupName"); - if(leaderboardNameParamValue == null || leaderboardNameParamValue.isEmpty()) { leaderboardName = DefaultLeaderboardName.DEFAULT_LEADERBOARD_NAME; } else { leaderboardName = leaderboardNameParamValue; } - - if(leaderboardGroupNameParamValue != null && !leaderboardGroupNameParamValue.isEmpty()) + if(leaderboardGroupNameParamValue != null && !leaderboardGroupNameParamValue.isEmpty()) { leaderboardGroupName = leaderboardGroupNameParamValue; - + } if (eventName == null || eventName.isEmpty() || raceName == null || raceName.isEmpty()) { createErrorPage("This page requires a valid event name and race name."); return; } - final ParallelExecutionCallback> getLeaderboardNamesCallback = new ParallelExecutionCallback>(); final ParallelExecutionCallback> listEventsCallback = new ParallelExecutionCallback>(); final ParallelExecutionCallback getLeaderboardGroupByNameCallback = new ParallelExecutionCallback(); final ParallelExecutionCallback getUserCallback = new ParallelExecutionCallback(); - if (leaderboardGroupName != null) { new ParallelExecutionHolder(getLeaderboardNamesCallback, getLeaderboardGroupByNameCallback, listEventsCallback, getUserCallback) { @Override @@ -81,21 +76,19 @@ public class RaceBoardEntryPoint extends AbstractEntryPoint { } }; } - sailingService.listEvents(false, listEventsCallback); sailingService.getLeaderboardNames(getLeaderboardNamesCallback); - if(leaderboardGroupName != null) + if(leaderboardGroupName != null) { sailingService.getLeaderboardGroupByName(leaderboardGroupNameParamValue, getLeaderboardGroupByNameCallback); + } userManagementService.getUser(getUserCallback); } - private void checkUrlParameters(List leaderboardNames, LeaderboardGroupDTO leaderboardGroup, List events, UserDTO user) - { + private void checkUrlParameters(List leaderboardNames, LeaderboardGroupDTO leaderboardGroup, List events, UserDTO user) { if (!leaderboardNames.contains(leaderboardName)) { createErrorPage(stringMessages.noSuchLeaderboard()); return; } - if (leaderboardGroupName != null && leaderboardGroup != null) { boolean foundLeaderboard = false; for(LeaderboardDTO leaderBoard: leaderboardGroup.leaderboards) { @@ -109,13 +102,11 @@ public class RaceBoardEntryPoint extends AbstractEntryPoint { return; } } - selectedRace = findRace(eventName, raceName, events); if(selectedRace == null) { createErrorPage("Could not obtain a race with name " + raceName + " for an event with name " + eventName); return; } - createRaceBoardPanel(selectedRace, events, user); }