From 3e7c59a94f2cd18ff35fc9b07855d93bc7d6174b Mon Sep 17 00:00:00 2001 From: Georg Herdt Date: Fri, 6 Mar 2020 16:15:54 +0100 Subject: [PATCH] add selenium id for tests #5153 --- .../sailing/gwt/home/desktop/partials/footer/Footer.java | 9 +++++++++ .../sailing/gwt/home/desktop/partials/header/Header.java | 7 +++++-- .../home/desktop/partials/socialfooter/SocialFooter.java | 2 ++ .../sailing/gwt/ui/client/shared/racemap/RaceMap.java | 2 ++ .../sap/sailing/gwt/ui/shared/databylogo/DataByLogo.java | 2 ++ .../src/com/sap/sse/gwt/client/sapheader/SAPHeader.java | 4 ++++ 6 files changed, 24 insertions(+), 2 deletions(-) diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/footer/Footer.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/footer/Footer.java index 3041781d99e..c127b76b1c0 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/footer/Footer.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/footer/Footer.java @@ -1,6 +1,7 @@ package com.sap.sailing.gwt.home.desktop.partials.footer; import static com.google.gwt.dom.client.Style.Display.NONE; +import static com.sap.sse.gwt.shared.DebugConstants.DEBUG_ID_ATTRIBUTE; import com.google.gwt.core.client.GWT; import com.google.gwt.dom.client.AnchorElement; @@ -22,6 +23,7 @@ import com.sap.sailing.gwt.home.shared.app.PlaceNavigation; import com.sap.sailing.gwt.ui.client.StringMessages; import com.sap.sse.gwt.client.controls.languageselect.LanguageSelector; import com.sap.sse.gwt.shared.Branding; +import com.sap.sse.gwt.shared.DebugConstants; public class Footer extends Composite { private static FooterPanelUiBinder uiBinder = GWT.create(FooterPanelUiBinder.class); @@ -67,6 +69,13 @@ public class Footer extends Composite { imprintAnchorLink.getStyle().setDisplay(Display.NONE); privacyAnchorLink.getStyle().setDisplay(Display.NONE); } + copyrightDiv.setAttribute(DebugConstants.DEBUG_ID_ATTRIBUTE, "copyrightDiv"); + sapJobsAnchor.setAttribute(DEBUG_ID_ATTRIBUTE, "sapJobsAnchor"); + feedbackAnchor.setAttribute(DEBUG_ID_ATTRIBUTE, "feedbackAnchor"); + whatsNewAnchor.setAttribute(DEBUG_ID_ATTRIBUTE, "whatsNewAnchor"); + imprintAnchorLink.setAttribute(DEBUG_ID_ATTRIBUTE, "imprintAnchorLink"); + privacyAnchorLink.setAttribute(DEBUG_ID_ATTRIBUTE, "privacyAnchorLink"); + languageSelector.getElement().setAttribute(DEBUG_ID_ATTRIBUTE, "languageSelector"); } } diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/header/Header.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/header/Header.java index 56db9d95bcd..2cf0c7c0f37 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/header/Header.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/header/Header.java @@ -1,5 +1,7 @@ package com.sap.sailing.gwt.home.desktop.partials.header; +import static com.sap.sse.gwt.shared.DebugConstants.DEBUG_ID_ATTRIBUTE; + import java.util.Arrays; import java.util.List; @@ -112,8 +114,9 @@ public class Header extends Composite { } logoImage.setAttribute(DebugConstants.DEBUG_ID_ATTRIBUTE, "logoImage"); - solutionsPageLink.getElement().setAttribute(DebugConstants.DEBUG_ID_ATTRIBUTE, "solutionsPageLink"); - logoAnchor.setAttribute(DEBUG_ID_PREFIX, "logoAnchor"); + solutionsPageLink.getElement().setAttribute(DEBUG_ID_ATTRIBUTE, "solutionsPageLink"); + logoAnchor.setAttribute(DEBUG_ID_ATTRIBUTE, "logoAnchor"); + eventsPageLink.getElement().setAttribute(DEBUG_ID_ATTRIBUTE, "eventsPage"); } @UiHandler("startPageLink") diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/socialfooter/SocialFooter.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/socialfooter/SocialFooter.java index 57af27dc975..583dda025e5 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/socialfooter/SocialFooter.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/partials/socialfooter/SocialFooter.java @@ -1,6 +1,7 @@ package com.sap.sailing.gwt.home.desktop.partials.socialfooter; import static com.google.gwt.dom.client.Style.Display.NONE; +import static com.sap.sse.gwt.shared.DebugConstants.DEBUG_ID_ATTRIBUTE; import com.google.gwt.core.client.GWT; import com.google.gwt.uibinder.client.UiBinder; @@ -26,6 +27,7 @@ public class SocialFooter extends Composite { if (!Branding.getInstance().isActive()) { htmlPanel.getElement().getStyle().setDisplay(NONE); } + htmlPanel.getElement().setAttribute(DEBUG_ID_ATTRIBUTE, "socialFooter"); } } diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/racemap/RaceMap.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/racemap/RaceMap.java index b10aa40f7e4..65e7e00d4e2 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/racemap/RaceMap.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/racemap/RaceMap.java @@ -166,6 +166,7 @@ import com.sap.sse.gwt.client.shared.components.SettingsDialog; import com.sap.sse.gwt.client.shared.components.SettingsDialogComponent; import com.sap.sse.gwt.client.shared.settings.ComponentContext; import com.sap.sse.gwt.shared.Branding; +import com.sap.sse.gwt.shared.DebugConstants; public class RaceMap extends AbstractCompositeComponent implements TimeListener, CompetitorSelectionChangeListener, RaceTimesInfoProviderListener, TailFactory, ColorMapperChangedListener, RequiresDataInitialization, RequiresResize, QuickRankProvider { @@ -3216,6 +3217,7 @@ public class RaceMap extends AbstractCompositeComponent impleme } }); sapLogo.setStyleName("raceBoard-Logo"); + sapLogo.getElement().setAttribute(DebugConstants.DEBUG_ID_ATTRIBUTE, "raceBoardSapLogo"); return sapLogo; } diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/shared/databylogo/DataByLogo.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/shared/databylogo/DataByLogo.java index 977628c3cdd..f71487209f9 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/shared/databylogo/DataByLogo.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/shared/databylogo/DataByLogo.java @@ -14,6 +14,7 @@ import com.google.gwt.user.client.ui.Widget; import com.sap.sailing.domain.common.tracking.TrackingConnectorType; import com.sap.sailing.gwt.ui.shared.TrackingConnectorInfoDTO; import com.sap.sse.gwt.shared.Branding; +import com.sap.sse.gwt.shared.DebugConstants; public class DataByLogo extends Widget { @@ -33,6 +34,7 @@ public class DataByLogo extends Widget { if (!Branding.getInstance().isActive()) { dataByContainer.getStyle().setDisplay(Display.NONE); } + dataByContainer.setAttribute(DebugConstants.DEBUG_ID_ATTRIBUTE, "dataByContainer"); } public void setUp(Set trackingConnectorInfos, boolean colorIfPossible, diff --git a/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/sapheader/SAPHeader.java b/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/sapheader/SAPHeader.java index 77aa774c6db..4d86bfae784 100644 --- a/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/sapheader/SAPHeader.java +++ b/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/sapheader/SAPHeader.java @@ -12,6 +12,7 @@ import com.google.gwt.user.client.ui.Composite; import com.google.gwt.user.client.ui.SimplePanel; import com.google.gwt.user.client.ui.Widget; import com.sap.sse.gwt.shared.Branding; +import com.sap.sse.gwt.shared.DebugConstants; /** * Generic header widget that is designed with a SAP logo and SAP color scheme. @@ -56,7 +57,10 @@ public class SAPHeader extends Composite { if (!Branding.getInstance().isActive()) { logoAnchor.getStyle().setDisplay(Display.NONE); + applicationNameAnchor.setHref(""); } + logoAnchor.setAttribute(DebugConstants.DEBUG_ID_ATTRIBUTE, "logoAnchor"); + applicationNameAnchor.setAttribute(DEBUG_ID_PREFIX, "applicationNameAnchor"); } public void setHeaderTitle(String title) {