From f655fbdbe3631a86174fb77ed62c06f9dbe90c3c Mon Sep 17 00:00:00 2001 From: Dennis Aulenbacher Date: Fri, 12 Mar 2021 12:53:22 +0100 Subject: [PATCH] bug5488: Extended comment. --- .../sailing/server/gateway/jaxrs/api/EventsResource.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/java/com.sap.sailing.server.gateway/src/com/sap/sailing/server/gateway/jaxrs/api/EventsResource.java b/java/com.sap.sailing.server.gateway/src/com/sap/sailing/server/gateway/jaxrs/api/EventsResource.java index 7b2711538f1..ef7bbf9f3a0 100644 --- a/java/com.sap.sailing.server.gateway/src/com/sap/sailing/server/gateway/jaxrs/api/EventsResource.java +++ b/java/com.sap.sailing.server.gateway/src/com/sap/sailing/server/gateway/jaxrs/api/EventsResource.java @@ -632,8 +632,11 @@ public class EventsResource extends AbstractSailingServerResource { /* leaderboardDiscardThresholdsParam */ leaderboardDiscardThresholdsParam, numberOfRacesParam, canBoatsOfCompetitorsChangePerRace, competitorRegistrationType, localCompetitorRegistrationSecret); if (leaderboardGroup != null) { - // no security checks for any overall leaderboard required here as we don't manipulate it through this service - getService().apply(new UpdateLeaderboardGroup(leaderboardGroup.getId(), leaderboardGroup.getName(), + // no security checks for any overall leaderboard required here as we don't manipulate it + // through this service. leaderboardGroup.getOverallLeaderboard() == null will be true, due to + // overallLeaderboardScoringSchemeTypeParam being null in validateAndAddLeaderboardGroup call. + getService().apply(new UpdateLeaderboardGroup(leaderboardGroup.getId(), + leaderboardGroup.getName(), leaderboardGroup.getDescription(), leaderboardGroup.getDisplayName(), Collections.singletonList(leaderboard.getName()), leaderboardGroup.getOverallLeaderboard() == null ? null