From 43bdeb1b8711a01f0f3c04763f3dd0917986a540 Mon Sep 17 00:00:00 2001 From: Thomas Stokes Date: Thu, 21 Mar 2024 12:43:58 +0100 Subject: [PATCH] Use try-with-resource statement --- .../sap/sailing/server/impl/RacingEventServiceImpl.java | 7 +++---- .../com/sap/sse/mongodb/internal/MongoDBServiceImpl.java | 7 ++++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/java/com.sap.sailing.server/src/com/sap/sailing/server/impl/RacingEventServiceImpl.java b/java/com.sap.sailing.server/src/com/sap/sailing/server/impl/RacingEventServiceImpl.java index 6752f7a0b07..3fe0ca9a246 100644 --- a/java/com.sap.sailing.server/src/com/sap/sailing/server/impl/RacingEventServiceImpl.java +++ b/java/com.sap.sailing.server/src/com/sap/sailing/server/impl/RacingEventServiceImpl.java @@ -5248,11 +5248,10 @@ Replicator { String message = e.getMessage(); if (connection instanceof HttpURLConnection) { // try to obtain an error message from the connection's error stream: - try { - message = new BufferedReader( + try (BufferedReader reader = new BufferedReader( new InputStreamReader(((HttpURLConnection) connection).getErrorStream(), - HttpUrlConnectionHelper.getCharsetFromConnectionOrDefault(connection, "UTF-8"))) - .readLine(); + HttpUrlConnectionHelper.getCharsetFromConnectionOrDefault(connection, "UTF-8")))) { + message = reader.readLine(); } catch (Exception exceptionTryingToReadErrorStream) { // in this case we just stay with the exception's message } diff --git a/java/com.sap.sse.mongodb/src/com/sap/sse/mongodb/internal/MongoDBServiceImpl.java b/java/com.sap.sse.mongodb/src/com/sap/sse/mongodb/internal/MongoDBServiceImpl.java index 8e66cb0de1d..7bad445ce15 100644 --- a/java/com.sap.sse.mongodb/src/com/sap/sse/mongodb/internal/MongoDBServiceImpl.java +++ b/java/com.sap.sse.mongodb/src/com/sap/sse/mongodb/internal/MongoDBServiceImpl.java @@ -142,9 +142,10 @@ public class MongoDBServiceImpl implements MongoDBService { @Override public MongoClient getMongo(ConnectionString mongoConnectionString) { - MongoClient mongo = mongos.computeIfAbsent(mongoConnectionString, - k-> MongoClients.create(mongoConnectionString)); - return mongo; + try (MongoClient mongo = mongos.computeIfAbsent(mongoConnectionString, + k-> MongoClients.create(mongoConnectionString))) { + return mongo; + } } @Override