From 8f017822c933be5176c1b9e1e8df5e076eca9968 Mon Sep 17 00:00:00 2001 From: Axel Uhl Date: Thu, 26 Jun 2014 12:28:33 +0000 Subject: [PATCH 1/2] Updated kielerwoche2014 (markdown) --- wiki/kielerwoche2014.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/wiki/kielerwoche2014.md b/wiki/kielerwoche2014.md index 40f2a705106..4d752bc0a09 100644 --- a/wiki/kielerwoche2014.md +++ b/wiki/kielerwoche2014.md @@ -10,23 +10,23 @@ ELB-based replication cluster: User data for master:
-MONGODB_NAME=KW2014
-REPLICATION_CHANNEL=KW2014
+MONGODB_NAME=KW2014-ELB
+REPLICATION_CHANNEL=KW2014-ELB
 SERVER_STARTUP_NOTIFY=axel.uhl@sap.com
-SERVER_NAME=KW2014
+SERVER_NAME=KW2014-ELB-MASTER
 USE_ENVIRONMENT=live-master-server
-INSTALL_FROM_RELEASE=kiwo2014-release-201406241522
+INSTALL_FROM_RELEASE=kiwo2014-release-201406260007
 MEMORY=20000m
 
User data for replicas:
-MONGODB_NAME=KW2014
-REPLICATION_CHANNEL=KW2014
+MONGODB_NAME=KW2014-ELB
+REPLICATION_CHANNEL=KW2014-ELB
 SERVER_STARTUP_NOTIFY=axel.uhl@sap.com
-SERVER_NAME=KW2014
-REPLICATE_MASTER_SERVLET_HOST=ec2-54-76-178-149.eu-west-1.compute.amazonaws.com
+SERVER_NAME=KW2014-REPLICA3
+REPLICATE_MASTER_SERVLET_HOST=XXX.XXX.XXX.XXX
 USE_ENVIRONMENT=live-replica-server
 INSTALL_FROM_RELEASE=kiwo2014-release-201406260007
 MEMORY=20000m

From db47f7cd291f39c3d0b6a8a5572183a73aac2df2 Mon Sep 17 00:00:00 2001
From: Lennart Hensler 
Date: Thu, 26 Jun 2014 15:39:04 +0200
Subject: [PATCH 2/2] Minor cleanup of the TVEntryPoint

Extracted a constant for the leaderboard name.
Replaced Window.Location.getParameter with
GwtHttpRequestUtils.getBooleanParameter for the boolean parameters. This
allows declaring a default value.
---
 .../java/com/sap/sailing/gwt/ui/tv/TVEntryPoint.java   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/tv/TVEntryPoint.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/tv/TVEntryPoint.java
index 1986cf1eadb..3b7886795a8 100644
--- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/tv/TVEntryPoint.java
+++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/tv/TVEntryPoint.java
@@ -23,6 +23,8 @@ import com.sap.sse.gwt.client.EntryPointHelper;
 import com.sap.sse.gwt.shared.GwtHttpRequestUtils;
 
 public class TVEntryPoint extends AbstractEntryPoint {
+    
+    private static final String PARAM_LEADERBOARD_NAME = "name";
     private static final String PARAM_LEADERBOARD_GROUP_NAME = "leaderboardGroupName";
     private static final String PARAM_EMBEDDED = "embedded";
     private static final String PARAM_SHOW_RACE_DETAILS = "showRaceDetails";
@@ -42,10 +44,8 @@ public class TVEntryPoint extends AbstractEntryPoint {
         EntryPointHelper.registerASyncService((ServiceDefTarget) sailingService, RemoteServiceMappingConstants.sailingServiceRemotePath);
         EntryPointHelper.registerASyncService((ServiceDefTarget) mediaService, RemoteServiceMappingConstants.mediaServiceRemotePath);
 
-        final boolean showRaceDetails = Window.Location.getParameter(PARAM_SHOW_RACE_DETAILS) != null
-                && Window.Location.getParameter(PARAM_SHOW_RACE_DETAILS).equalsIgnoreCase("true");
-        final boolean embedded = Window.Location.getParameter(PARAM_EMBEDDED) != null
-                && Window.Location.getParameter(PARAM_EMBEDDED).equalsIgnoreCase("true");
+        final boolean showRaceDetails = GwtHttpRequestUtils.getBooleanParameter(PARAM_SHOW_RACE_DETAILS, true); 
+        final boolean embedded = GwtHttpRequestUtils.getBooleanParameter(PARAM_EMBEDDED, false); 
         final long delayToLiveMillis = Window.Location.getParameter(PARAM_DELAY_TO_LIVE_MILLIS) != null ? Long
                 .valueOf(Window.Location.getParameter(PARAM_DELAY_TO_LIVE_MILLIS)) : 5000l; // default 5s
         final boolean showNavigationPanel = GwtHttpRequestUtils.getBooleanParameter(
@@ -65,7 +65,7 @@ public class TVEntryPoint extends AbstractEntryPoint {
         sailingService.getLeaderboardNames(new AsyncCallback>() {
             @Override
             public void onSuccess(List leaderboardNames) {
-                leaderboardName = Window.Location.getParameter("name");
+                leaderboardName = Window.Location.getParameter(PARAM_LEADERBOARD_NAME);
                 leaderboardGroupName = Window.Location.getParameter(PARAM_LEADERBOARD_GROUP_NAME);
                 if (leaderboardNames.contains(leaderboardName)) {
                     createUI(showRaceDetails, embedded, showNavigationPanel, delayToLiveMillis);