From 6bbbbdb3a98953378e6054d6dfc9758bebd3351a Mon Sep 17 00:00:00 2001 From: Vladislav Chumak Date: Wed, 25 Jul 2018 17:10:00 +0200 Subject: [PATCH] Improved performance benefit calculation and error message --- .../impl/IncrementalManeuverComputationTest.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/maneuverdetection/impl/IncrementalManeuverComputationTest.java b/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/maneuverdetection/impl/IncrementalManeuverComputationTest.java index 031f22ec7fa..572727bfa3b 100644 --- a/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/maneuverdetection/impl/IncrementalManeuverComputationTest.java +++ b/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/maneuverdetection/impl/IncrementalManeuverComputationTest.java @@ -130,11 +130,14 @@ public class IncrementalManeuverComputationTest extends AbstractManeuverDetectio performanceMeasurementStartedAt = System.currentTimeMillis(); List normallyDetectedManeuvers = normalManeuverDetector.detectManeuvers(); long millisForNormalManeuverDetection = System.currentTimeMillis() - performanceMeasurementStartedAt; + int performanceBenefitOfIncrementalManeuverDetectionInPercent = (int) ((1.0 * (millisForNormalManeuverDetection - millisForIncrementalManeuverDetection) + / millisForNormalManeuverDetection) * 100); assertEquals("Incrementally calculated maneuvers differ from normally calculated maneuvers", normallyDetectedManeuvers, incrementallyDetectedManeuvers); assertTrue( - "Incremental maneuver detection was not 20% faster in detecting maneuvers incrementally, than the full maneuver detection", - millisForIncrementalManeuverDetection * 1.2 < millisForNormalManeuverDetection); + "Incremental maneuver detection was not 20% faster in detecting maneuvers incrementally, than the full maneuver detection. The actual performance benefit was: " + + performanceBenefitOfIncrementalManeuverDetectionInPercent + "%", + performanceBenefitOfIncrementalManeuverDetectionInPercent >= 20); } }