From 3f8b1fdd758b79573a209b54324d8c859619b417 Mon Sep 17 00:00:00 2001 From: Dennis Aulenbacher Date: Wed, 6 May 2020 10:47:02 +0200 Subject: [PATCH 1/5] Bug5212: added refresh action on dialog callback --- .../gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java index c322b4fa47f..85c0e14468b 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java @@ -287,7 +287,7 @@ public class MarkTemplatePanel extends FlowPanel { new DefaultActionsImagesBarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog .create(userService.getUserManagementService(), type, markTemplate -> { - /* no refresh action */}, stringMessages); + refreshMarkTemplates();}, stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, markTemplate -> markTemplate.getAccessControlList(), From 3991bc1810df28482d2a07146a4d2d13946b0871 Mon Sep 17 00:00:00 2001 From: Axel Uhl Date: Fri, 15 May 2020 01:06:41 +0200 Subject: [PATCH 2/5] formatting changes only --- .../coursecreation/MarkTemplatePanel.java | 22 ++----------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java index b0d00862e59..95420e24221 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java @@ -71,7 +71,6 @@ public class MarkTemplatePanel extends FlowPanel { add(buttonAndFilterPanel); allMarkTemplates = new ArrayList<>(); buttonAndFilterPanel.addUnsecuredAction(stringMessages.refresh(), new Command() { - @Override public void execute() { loadMarkTemplates(); @@ -81,14 +80,11 @@ public class MarkTemplatePanel extends FlowPanel { @Override public void execute() { openEditMarkTemplateDialog(new MarkTemplateDTO()); - // TODO add action } }); - Label lblFilterRaces = new Label(stringMessages.filterMarkTemplateByName() + ":"); lblFilterRaces.setWordWrap(false); buttonAndFilterPanel.addUnsecuredWidget(lblFilterRaces); - this.filterableMarkTemplates = new LabeledAbstractFilterablePanel(lblFilterRaces, allMarkTemplates, markTemplateListDataProvider, stringMessages) { @Override @@ -132,17 +128,14 @@ public class MarkTemplatePanel extends FlowPanel { private void createMarkTemplatesTable(final UserService userService) { // Create a CellTable. - // Set a key provider that provides a unique key for each contact. If key is // used to identify contacts when fields (such as the name and address) // change. markTemplateTable = new BaseCelltable<>(1000, tableResources); markTemplateTable.setWidth("100%"); - // Attach a column sort handler to the ListDataProvider to sort the list. ListHandler sortHandler = new ListHandler<>(markTemplateListDataProvider.getList()); markTemplateTable.addColumnSortHandler(sortHandler); - // Add a selection model so we can select cells. refreshableSelectionModel = new RefreshableMultiSelectionModel<>( new EntityIdentityComparator() { @@ -188,7 +181,6 @@ public class MarkTemplatePanel extends FlowPanel { // Initialize the columns. initTableColumns(sortHandler, userService); - markTemplateListDataProvider.addDataDisplay(markTemplateTable); add(markTemplateTable); allMarkTemplates.clear(); @@ -210,7 +202,6 @@ public class MarkTemplatePanel extends FlowPanel { }; markTemplateTable.addColumn(checkColumn, SafeHtmlUtils.fromSafeConstant("
")); markTemplateTable.setColumnWidth(checkColumn, 40, Unit.PX); - // id Column idColumn = new Column(new TextCell()) { @Override @@ -264,31 +255,24 @@ public class MarkTemplatePanel extends FlowPanel { : ""; } }; - nameColumn.setSortable(true); sortHandler.setComparator(nameColumn, new Comparator() { public int compare(MarkTemplateDTO markTemplate1, MarkTemplateDTO markTemplate2) { return markTemplate1.getName().compareTo(markTemplate2.getName()); } }); - markTemplateTable.addColumn(nameColumn, stringMessages.name()); markTemplateTable.addColumn(shortNameColumn, stringMessages.shortName()); markTemplateTable.addColumn(colorColumn, stringMessages.color()); markTemplateTable.addColumn(shapeColumn, stringMessages.shape()); markTemplateTable.addColumn(patternColumn, stringMessages.pattern()); markTemplateTable.addColumn(typeColumn, stringMessages.type()); - SecuredDTOOwnerColumn.configureOwnerColumns(markTemplateTable, sortHandler, stringMessages); - final HasPermissions type = SecuredDomainType.MARK_TEMPLATE; - final AccessControlledActionsColumn actionsColumn = create( new DefaultActionsImagesBarCell(stringMessages), userService); - final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, markTemplate -> { - refreshMarkTemplates();}, stringMessages); - + final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog.create( + userService.getUserManagementService(), type, markTemplate -> refreshMarkTemplates(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, markTemplate -> markTemplate.getAccessControlList(), stringMessages); @@ -297,7 +281,6 @@ public class MarkTemplatePanel extends FlowPanel { markTemplate -> configACL.openACLDialog(markTemplate)); markTemplateTable.addColumn(idColumn, stringMessages.id()); markTemplateTable.addColumn(actionsColumn, stringMessages.actions()); - } public void refreshMarkTemplates() { @@ -337,5 +320,4 @@ public class MarkTemplatePanel extends FlowPanel { dialog.ensureDebugId("MarkTemplateEditDialog"); dialog.show(); } - } From de37e1d60736c73208e77a2582b98d975e019359 Mon Sep 17 00:00:00 2001 From: Dennis Aulenbacher Date: Fri, 15 May 2020 17:37:12 +0200 Subject: [PATCH 3/5] consistently reloading tables, when EditOwnershipDialog returns --- .../gwt/ui/adminconsole/BoatTableWrapper.java | 5 +---- .../gwt/ui/adminconsole/CompetitorTableWrapper.java | 2 +- .../sap/sailing/gwt/ui/adminconsole/MediaPanel.java | 12 ++++-------- .../SmartphoneTrackingEventManagementPanel.java | 3 +-- .../coursecreation/CourseTemplatePanel.java | 9 +-------- .../coursecreation/MarkPropertiesPanel.java | 11 ++--------- .../adminconsole/coursecreation/MarkRolePanel.java | 3 +-- .../coursecreation/MarkTemplatePanel.java | 10 +--------- 8 files changed, 12 insertions(+), 43 deletions(-) diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/BoatTableWrapper.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/BoatTableWrapper.java index 6e0a9c0dc4a..cfee91d1813 100755 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/BoatTableWrapper.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/BoatTableWrapper.java @@ -169,7 +169,6 @@ public class BoatTableWrapper> exte }; filterField.setUpdatePermissionFilterForCheckbox(boat -> userService.hasPermission(boat, DefaultActions.UPDATE)); registerSelectionModelOnNewDataProvider(filterField.getAllListDataProvider()); - // BoatTable edit features final HasPermissions type = SecuredDomainType.BOAT; AccessControlledActionsColumn boatActionColumn = create( @@ -178,15 +177,13 @@ public class BoatTableWrapper> exte this::openEditBoatDialog); boatActionColumn.addAction(BoatConfigImagesBarCell.ACTION_REFRESH, this::allowUpdate); final DialogConfig editOwnerShipDialog = EditOwnershipDialog.create( - userService.getUserManagementService(), SecuredDomainType.BOAT, null, stringMessages); + userService.getUserManagementService(), SecuredDomainType.BOAT, boatDTO -> refresh(Collections.singleton(boatDTO)), stringMessages); boatActionColumn.addAction(BoatConfigImagesBarCell.ACTION_CHANGE_OWNERSHIP, CHANGE_OWNERSHIP, editOwnerShipDialog::openOwnershipDialog); - final EditACLDialog.DialogConfig configACL = EditACLDialog .create(userService.getUserManagementService(), type, null, stringMessages); boatActionColumn.addAction(BoatConfigImagesBarCell.ACTION_CHANGE_ACL, DefaultActions.CHANGE_ACL, configACL::openACLDialog); - mainPanel.insert(filterField, 0); table.addColumnSortHandler(boatColumnListHandler); table.addColumn(boatNameColumn, stringMessages.name()); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/CompetitorTableWrapper.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/CompetitorTableWrapper.java index 040f346ada6..5a681149d4e 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/CompetitorTableWrapper.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/CompetitorTableWrapper.java @@ -331,7 +331,7 @@ public class CompetitorTableWrapper editOwnerShipDialog = EditOwnershipDialog.create(userService.getUserManagementService(), SecuredDomainType.COMPETITOR, - null, stringMessages); + competitorDTO -> refresh(Collections.singleton(competitorDTO)), stringMessages); competitorActionColumn.addAction(CompetitorConfigImagesBarCell.ACTION_CHANGE_OWNERSHIP, CHANGE_OWNERSHIP, editOwnerShipDialog::openOwnershipDialog); final EditACLDialog.DialogConfig configACL = EditACLDialog diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java index 8fb424e5ab2..b8c1db5ed00 100755 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java @@ -580,19 +580,15 @@ public class MediaPanel extends FlowPanel implements MediaTracksRefresher { removeMediaTrack(mediaTrack); } }); - final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog.create( - userService.getUserManagementService(), type, - mediaTrack -> { - /* no refresh action */}, - stringMessages); - + final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog + .create(userService.getUserManagementService(), type, mediaTrack -> loadMediaTracks(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( - userService.getUserManagementService(), type, mediaTrack -> mediaTrack.getAccessControlList(), stringMessages); + userService.getUserManagementService(), type, mediaTrack -> mediaTrack.getAccessControlList(), + stringMessages); actionsColumn.addAction(ACTION_CHANGE_OWNERSHIP, CHANGE_OWNERSHIP, configOwnership::openOwnershipDialog); actionsColumn.addAction(DefaultActionsImagesBarCell.ACTION_CHANGE_ACL, DefaultActions.CHANGE_ACL, mediaTrack -> configACL.openACLDialog(mediaTrack)); mediaTracksTable.addColumn(actionsColumn, stringMessages.actions()); - } protected void removeMediaTrack(MediaTrack mediaTrack) { diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SmartphoneTrackingEventManagementPanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SmartphoneTrackingEventManagementPanel.java index 4da4b3411f0..2522db6707c 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SmartphoneTrackingEventManagementPanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SmartphoneTrackingEventManagementPanel.java @@ -195,8 +195,7 @@ public class SmartphoneTrackingEventManagementPanel Boolean.valueOf(l1.canBoatsOfCompetitorsChangePerRace).compareTo(Boolean.valueOf(l2.canBoatsOfCompetitorsChangePerRace))); final HasPermissions type = SecuredDomainType.EVENT; final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, leaderboard -> { - }, stringMessages); + .create(userService.getUserManagementService(), type, leaderboard -> loadAndRefreshLeaderboard(leaderboard.getName()), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, leaderboard -> leaderboard.getAccessControlList(), stringMessages); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java index 6bea48c22cd..8341546bc2c 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java @@ -293,29 +293,22 @@ public class CourseTemplatePanel extends FlowPanel { return Integer.toString(courseTemplate.getWaypointTemplates().size()); } }; - nameColumn.setSortable(true); sortHandler.setComparator(nameColumn, new Comparator() { public int compare(CourseTemplateDTO courseTemplate1, CourseTemplateDTO courseTemplate2) { return courseTemplate1.getName().compareTo(courseTemplate2.getName()); } }); - courseTemplateTable.addColumn(nameColumn, stringMessages.name()); courseTemplateTable.addColumn(urlColumn, stringMessages.url()); courseTemplateTable.addColumn(tagsColumn, stringMessages.tags()); courseTemplateTable.addColumn(waypointTemplateCountColumn, stringMessages.waypoints()); - SecuredDTOOwnerColumn.configureOwnerColumns(courseTemplateTable, sortHandler, stringMessages); - final HasPermissions type = SecuredDomainType.COURSE_TEMPLATE; - final AccessControlledActionsColumn actionsColumn = create( new DefaultActionsImagesBarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, courseTemplate -> { - /* no refresh action */}, stringMessages); - + .create(userService.getUserManagementService(), type, courseTemplate -> refreshCourseTemplates(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, courseTemplate -> courseTemplate.getAccessControlList(), stringMessages); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkPropertiesPanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkPropertiesPanel.java index 47b1790cd90..115d1ba725c 100755 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkPropertiesPanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkPropertiesPanel.java @@ -294,7 +294,6 @@ public class MarkPropertiesPanel extends FlowPanel { return String.join(", ", markProperties.getTags()); } }; - Column positioningColumn = new Column( new AbstractCell() { @@ -315,14 +314,12 @@ public class MarkPropertiesPanel extends FlowPanel { } } }; - nameColumn.setSortable(true); sortHandler.setComparator(nameColumn, new Comparator() { public int compare(MarkPropertiesDTO markProperties1, MarkPropertiesDTO markProperties2) { return markProperties1.getName().compareTo(markProperties2.getName()); } }); - markPropertiesTable.addColumn(nameColumn, stringMessages.name()); markPropertiesTable.addColumn(shortNameColumn, stringMessages.shortName()); markPropertiesTable.addColumn(colorColumn, stringMessages.color()); @@ -331,17 +328,13 @@ public class MarkPropertiesPanel extends FlowPanel { markPropertiesTable.addColumn(typeColumn, stringMessages.type()); markPropertiesTable.addColumn(positioningColumn, stringMessages.position()); markPropertiesTable.addColumn(tagsColumn, stringMessages.tags()); - SecuredDTOOwnerColumn.configureOwnerColumns(markPropertiesTable, sortHandler, stringMessages); - final HasPermissions type = SecuredDomainType.MARK_PROPERTIES; - final AccessControlledActionsColumn actionsColumn = create( new MarkPropertiesImagesbarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, markProperties -> { - /* no refresh action */}, stringMessages); - + .create(userService.getUserManagementService(), type, markProperties -> + refreshMarkProperties(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, markProperties -> markProperties.getAccessControlList(), stringMessages); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkRolePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkRolePanel.java index faa15fb4643..f2c12b9da9d 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkRolePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkRolePanel.java @@ -238,8 +238,7 @@ public class MarkRolePanel extends FlowPanel { final AccessControlledActionsColumn actionsColumn = create( new DefaultActionsImagesBarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), SecuredDomainType.MARK_ROLE, markRole -> { - /* no refresh action */}, stringMessages); + .create(userService.getUserManagementService(), SecuredDomainType.MARK_ROLE, markRole -> refreshMarkRoles(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), SecuredDomainType.MARK_ROLE, markRole -> markRole.getAccessControlList(), stringMessages); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java index 85c0e14468b..2ddf4e53c02 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java @@ -264,31 +264,24 @@ public class MarkTemplatePanel extends FlowPanel { : ""; } }; - nameColumn.setSortable(true); sortHandler.setComparator(nameColumn, new Comparator() { public int compare(MarkTemplateDTO markTemplate1, MarkTemplateDTO markTemplate2) { return markTemplate1.getName().compareTo(markTemplate2.getName()); } }); - markTemplateTable.addColumn(nameColumn, stringMessages.name()); markTemplateTable.addColumn(shortNameColumn, stringMessages.shortName()); markTemplateTable.addColumn(colorColumn, stringMessages.color()); markTemplateTable.addColumn(shapeColumn, stringMessages.shape()); markTemplateTable.addColumn(patternColumn, stringMessages.pattern()); markTemplateTable.addColumn(typeColumn, stringMessages.type()); - SecuredDTOOwnerColumn.configureOwnerColumns(markTemplateTable, sortHandler, stringMessages); - final HasPermissions type = SecuredDomainType.MARK_TEMPLATE; - final AccessControlledActionsColumn actionsColumn = create( new DefaultActionsImagesBarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, markTemplate -> { - refreshMarkTemplates();}, stringMessages); - + .create(userService.getUserManagementService(), type, markTemplate -> refreshMarkTemplates(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, markTemplate -> markTemplate.getAccessControlList(), stringMessages); @@ -297,7 +290,6 @@ public class MarkTemplatePanel extends FlowPanel { markTemplate -> configACL.openACLDialog(markTemplate)); markTemplateTable.addColumn(idColumn, stringMessages.id()); markTemplateTable.addColumn(actionsColumn, stringMessages.actions()); - } public void refreshMarkTemplates() { From 0e0f27a7c0b8731228726c5eb08604a6042fc105 Mon Sep 17 00:00:00 2001 From: Dennis Aulenbacher Date: Mon, 25 May 2020 11:37:16 +0200 Subject: [PATCH 4/5] bug5212: substitution of full refresh methods for list data providers refresh method, reducing unnecessary backend calls. --- .../java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java | 2 +- .../adminconsole/SmartphoneTrackingEventManagementPanel.java | 2 +- .../ui/adminconsole/coursecreation/CourseTemplatePanel.java | 5 +++-- .../ui/adminconsole/coursecreation/MarkPropertiesPanel.java | 2 +- .../gwt/ui/adminconsole/coursecreation/MarkRolePanel.java | 2 +- .../ui/adminconsole/coursecreation/MarkTemplatePanel.java | 2 +- 6 files changed, 8 insertions(+), 7 deletions(-) diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java index 10aa8c6e783..bfcaec31f2b 100755 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/MediaPanel.java @@ -581,7 +581,7 @@ public class MediaPanel extends FlowPanel implements MediaTracksRefresher { } }); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, mediaTrack -> loadMediaTracks(), stringMessages); + .create(userService.getUserManagementService(), type, mediaTrack -> mediaTrackListDataProvider.refresh(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, mediaTrack -> mediaTrack.getAccessControlList(), stringMessages); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SmartphoneTrackingEventManagementPanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SmartphoneTrackingEventManagementPanel.java index 4907d3a16d5..5fc1eef19f7 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SmartphoneTrackingEventManagementPanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SmartphoneTrackingEventManagementPanel.java @@ -195,7 +195,7 @@ public class SmartphoneTrackingEventManagementPanel Boolean.valueOf(l1.canBoatsOfCompetitorsChangePerRace).compareTo(Boolean.valueOf(l2.canBoatsOfCompetitorsChangePerRace))); final HasPermissions type = SecuredDomainType.EVENT; final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, leaderboard -> loadAndRefreshLeaderboard(leaderboard.getName()), stringMessages); + .create(userService.getUserManagementService(), type, leaderboard -> listDataProvider.refresh(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, leaderboard -> leaderboard.getAccessControlList(), stringMessages); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java index 5199aa4796f..bd76b85a47b 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java @@ -40,6 +40,7 @@ import com.sap.sailing.gwt.ui.client.StringMessages; import com.sap.sailing.gwt.ui.shared.courseCreation.CourseTemplateDTO; import com.sap.sailing.gwt.ui.shared.courseCreation.MarkRoleDTO; import com.sap.sailing.gwt.ui.shared.courseCreation.MarkTemplateDTO; +import com.sap.sse.common.Util; import com.sap.sse.gwt.adminconsole.AdminConsoleTableResources; import com.sap.sse.gwt.client.ErrorReporter; import com.sap.sse.gwt.client.celltable.BaseCelltable; @@ -308,7 +309,7 @@ public class CourseTemplatePanel extends FlowPanel { final AccessControlledActionsColumn actionsColumn = create( new DefaultActionsImagesBarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, courseTemplate -> refreshCourseTemplates(), stringMessages); + .create(userService.getUserManagementService(), type, courseTemplateDTO -> courseTemplateListDataProvider.refresh(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, courseTemplate -> courseTemplate.getAccessControlList(), stringMessages); @@ -335,7 +336,7 @@ public class CourseTemplatePanel extends FlowPanel { courseTemplateTable.addColumn(idColumn, stringMessages.id()); courseTemplateTable.addColumn(actionsColumn, stringMessages.actions()); } - + public void refreshCourseTemplates() { loadCourseTemplates(); loadMarkRoles(); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkPropertiesPanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkPropertiesPanel.java index 928cfe8be53..f350fba78c5 100755 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkPropertiesPanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkPropertiesPanel.java @@ -334,7 +334,7 @@ public class MarkPropertiesPanel extends FlowPanel { new MarkPropertiesImagesbarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog .create(userService.getUserManagementService(), type, markProperties -> - refreshMarkProperties(), stringMessages); + markPropertiesListDataProvider.refresh(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, markProperties -> markProperties.getAccessControlList(), stringMessages); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkRolePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkRolePanel.java index f0a7a3c68a1..7e4c2479cfb 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkRolePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkRolePanel.java @@ -238,7 +238,7 @@ public class MarkRolePanel extends FlowPanel { final AccessControlledActionsColumn actionsColumn = create( new DefaultActionsImagesBarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), SecuredDomainType.MARK_ROLE, markRole -> refreshMarkRoles(), stringMessages); + .create(userService.getUserManagementService(), SecuredDomainType.MARK_ROLE, markRole -> markRoleListDataProvider.refresh(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), SecuredDomainType.MARK_ROLE, markRole -> markRole.getAccessControlList(), stringMessages); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java index 4a69f00f3a9..4a6b982c07d 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/MarkTemplatePanel.java @@ -272,7 +272,7 @@ public class MarkTemplatePanel extends FlowPanel { final AccessControlledActionsColumn actionsColumn = create( new DefaultActionsImagesBarCell(stringMessages), userService); final EditOwnershipDialog.DialogConfig configOwnership = EditOwnershipDialog - .create(userService.getUserManagementService(), type, markTemplate -> refreshMarkTemplates(), stringMessages); + .create(userService.getUserManagementService(), type, markTemplate -> markTemplateListDataProvider.refresh(), stringMessages); final EditACLDialog.DialogConfig configACL = EditACLDialog.create( userService.getUserManagementService(), type, markTemplate -> markTemplate.getAccessControlList(), stringMessages); From 910015c02233284a06322eed13e0c9d44a182b0c Mon Sep 17 00:00:00 2001 From: Dennis Aulenbacher Date: Tue, 26 May 2020 15:17:24 +0200 Subject: [PATCH 5/5] removed unused imports --- .../gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java | 1 - 1 file changed, 1 deletion(-) diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java index bd76b85a47b..148f8a15a34 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/coursecreation/CourseTemplatePanel.java @@ -40,7 +40,6 @@ import com.sap.sailing.gwt.ui.client.StringMessages; import com.sap.sailing.gwt.ui.shared.courseCreation.CourseTemplateDTO; import com.sap.sailing.gwt.ui.shared.courseCreation.MarkRoleDTO; import com.sap.sailing.gwt.ui.shared.courseCreation.MarkTemplateDTO; -import com.sap.sse.common.Util; import com.sap.sse.gwt.adminconsole.AdminConsoleTableResources; import com.sap.sse.gwt.client.ErrorReporter; import com.sap.sse.gwt.client.celltable.BaseCelltable;