diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/RaceMap.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/RaceMap.java index 459e1f00749..34e8c2b5015 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/RaceMap.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/RaceMap.java @@ -353,15 +353,15 @@ public class RaceMap extends SimplePanel implements TimeListener, CompetitorSele /** * From {@link #fixes} as well as the selection of {@link #getCompetitorsToShow competitors to show}, computes the - * from/to times for which to request GPS raceMapData.fixes from the server. No update is performed here to {@link #fixes}. The + * from/to times for which to request GPS fixes from the server. No update is performed here to {@link #fixes}. The * result guarantees that, when used in * {@link SailingServiceAsync#getBoatPositions(String, String, Map, Map, boolean, AsyncCallback)}, for each - * competitor from {@link #competitorsToShow} there are all raceMapData.fixes known by the server for that competitor starting + * competitor from {@link #competitorsToShow} there are all fixes known by the server for that competitor starting * at upTo-{@link #tailLengthInMilliSeconds} and ending at upTo (exclusive). * * @return a triple whose {@link Triple#getA() first} component contains the "from", and whose {@link Triple#getB() * second} component contains the "to" times for the competitors whose trails / positions to show; the - * {@link Triple#getC() third} component tells whether the existing raceMapData.fixes can remain and be augmented by + * {@link Triple#getC() third} component tells whether the existing fixes can remain and be augmented by * those requested or need to be replaced */ protected Triple, Map, Map> computeFromAndTo( @@ -382,6 +382,7 @@ public class RaceMap extends SimplePanel implements TimeListener, CompetitorSele && !tailstart.before(timepointOfFirstKnownFix) && timepointOfLastKnownFix != null && !tailstart.after(timepointOfLastKnownFix)) { // the beginning of what we need is contained in the interval we already have; skip what we already have + // FIXME requests the lastKnownFix again because "from" is *inclusive*; could lead to bug 319 fromDate = timepointOfLastKnownFix; overlap = true; } else { @@ -409,10 +410,10 @@ public class RaceMap extends SimplePanel implements TimeListener, CompetitorSele /** - * Adds the raceMapData.fixes received in result to {@link #fixes} and ensures they are still contiguous for each - * competitor. If overlapsWithKnownraceMapData.fixes indicates that the raceMapData.fixes received in result - * overlap with those already known, the raceMapData.fixes are merged into the list of already known raceMapData.fixes for the competitor. - * Otherwise, the raceMapData.fixes received in result replace those known so far for the respective competitor. + * Adds the fixes received in result to {@link #fixes} and ensures they are still contiguous for each + * competitor. If overlapsWithKnownFixes indicates that the fixes received in result + * overlap with those already known, the fixes are merged into the list of already known fixes for the competitor. + * Otherwise, the fixes received in result replace those known so far for the respective competitor. */ protected void updateFixes(Map> result, Map overlapsWithKnownFixes) { @@ -425,8 +426,8 @@ public class RaceMap extends SimplePanel implements TimeListener, CompetitorSele } if (!overlapsWithKnownFixes.get(e.getKey())) { fixesForCompetitor.clear(); - // to re-establish the invariants for raceMapData.tails, raceMapData.firstShownFix and raceMapData.lastShownFix, we now need to remove - // all points from the competitor's polyline and clear the entries in raceMapData.firstShownFix and raceMapData.lastShownFix + // to re-establish the invariants for tails, firstShownFix and lastShownFix, we now need to remove + // all points from the competitor's polyline and clear the entries in firstShownFix and lastShownFix if (map != null && tails.containsKey(e.getKey())) { map.removeOverlay(tails.remove(e.getKey())); } diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/WindChart.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/WindChart.java index eb0307f1dfa..a696e0652d8 100755 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/WindChart.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/WindChart.java @@ -92,6 +92,7 @@ public class WindChart implements Component, RaceSelectionCha chart.setToolTip(new ToolTip().setEnabled(true).setFormatter(new ToolTipFormatter() { @Override public String format(ToolTipData toolTipData) { + // TODO consider using toolTipData.getPoint().getName() instead... return "" + toolTipData.getSeriesName() + (toolTipData.getPointName() != null ? " "+toolTipData.getPointName() : "") + "
" + dateFormat.format(new Date(toolTipData.getXAsLong())) + ": " +