From 8336cc3f4309ca7b71d7fd42428989339db8a39a Mon Sep 17 00:00:00 2001
From: Steffen Jacobs <steffen.jacobs@oio.de>
Date: Wed, 28 Nov 2018 11:04:50 +0100
Subject: [PATCH] adjusted styling of EditAclDialog

---
 .../client/component/editacl/AclDialogResources.gss   | 10 ++++++++--
 .../client/component/editacl/AclDialogResources.java  |  2 ++
 .../ui/client/component/editacl/AclEditPanel.java     | 11 ++++++++---
 3 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclDialogResources.gss b/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclDialogResources.gss
index 68f09e2504b..63e8c6a0e84 100644
--- a/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclDialogResources.gss
+++ b/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclDialogResources.gss
@@ -2,14 +2,20 @@
     margin-right: 5px;
     margin-left: 5px;
     margin-top: 10px;
-    display: inline-block;
+    display: inline;
 }
 
 .deniedActionsTable {
     margin-top: 10px;
-    display: inline-block;
+    display: inline;
 }
+
 .additionalWidget {
     margin-left: 5px;
     margin-right: 5px;
+}
+
+.userGroupTextBox {
+    min-width: 200px;
+    margin-bottom: 5px;
 }
\ No newline at end of file
diff --git a/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclDialogResources.java b/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclDialogResources.java
index ebeb3142212..6182ca84321 100644
--- a/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclDialogResources.java
+++ b/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclDialogResources.java
@@ -20,5 +20,7 @@ public interface AclDialogResources extends ClientBundle {
         String deniedActionsTable();
 
         String additionalWidget();
+
+        String userGroupTextBox();
     }
 }
diff --git a/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclEditPanel.java b/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclEditPanel.java
index df6d3e16486..c4afdf46618 100644
--- a/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclEditPanel.java
+++ b/java/com.sap.sse.security.ui/src/main/java/com/sap/sse/security/ui/client/component/editacl/AclEditPanel.java
@@ -138,7 +138,12 @@ public class AclEditPanel extends Composite {
                 userGroupOracle.setDefaultSuggestionsFromText(suggestionList);
             }
         });
-        return new SuggestBox(userGroupOracle, new TextBox());
+        TextBox textBox = new TextBox();
+        textBox.getElement().setPropertyString("placeholder", stringMessages.enterUserGroupName());
+
+        SuggestBox suggestBox = new SuggestBox(userGroupOracle, textBox);
+        suggestBox.addStyleName(AclDialogResources.INSTANCE.css().userGroupTextBox());
+        return suggestBox;
     }
 
     /** @return the UI element for visualizing {@link UserGroup} elements. */
@@ -178,8 +183,6 @@ public class AclEditPanel extends Composite {
         tenantPager.setDisplay(cellList);
         final ScrollPanel tenantPanel = new ScrollPanel(cellList);
         final VerticalPanel tenantListWrapper = new VerticalPanel();
-        tenantListWrapper.add(tenantPanel);
-        tenantListWrapper.add(tenantPager);
 
         // add additional widgets
         final FlowPanel additionalWidgetsPanel = new FlowPanel();
@@ -188,6 +191,8 @@ public class AclEditPanel extends Composite {
             additionalWidget.addStyleName(AclDialogResources.INSTANCE.css().additionalWidget());
         }
         tenantListWrapper.add(additionalWidgetsPanel);
+        tenantListWrapper.add(tenantPanel);
+        tenantListWrapper.add(tenantPager);
 
         final CaptionPanel tenantListCaption = new CaptionPanel(title);
         tenantListCaption.add(tenantListWrapper);