From 9d67fef062091ed402bd8453d5f67e60b0dc72f8 Mon Sep 17 00:00:00 2001 From: Steffen Schaefer Date: Mon, 7 Sep 2020 08:55:41 +0200 Subject: [PATCH 1/2] Bug 5239: Fixed reading the value in TextBoxBasePO --- .../src/com/sap/sailing/selenium/pages/gwt/TextBoxBasePO.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/gwt/TextBoxBasePO.java b/java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/gwt/TextBoxBasePO.java index d355e4e74cc..5c4844bb88f 100644 --- a/java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/gwt/TextBoxBasePO.java +++ b/java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/gwt/TextBoxBasePO.java @@ -75,13 +75,13 @@ public abstract class TextBoxBasePO extends AbstractInputPO { } /** - * Gets the text contained in the underlying {@link WebElement}s "Value" attribute. + * Gets the text contained in the underlying {@link WebElement}s "value" attribute. * This might be necessary for input elements that do not maintain their contained text in the "innerText" attribute, that is returned by #WebElement#getText() * @return the contained text * */ public String getValue() { - return getWebElement().getAttribute("Value"); + return getWebElement().getAttribute("value"); } } From ff4e3ffc6ddebf5315b53ec11d7b018045b37a2a Mon Sep 17 00:00:00 2001 From: Steffen Schaefer Date: Mon, 7 Sep 2020 08:57:06 +0200 Subject: [PATCH 2/2] Bug 5239: Finding the correct permission entry by name in RoleDefinition edit dialog --- .../selenium/pages/gwt/StringListEditorCompositePO.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/gwt/StringListEditorCompositePO.java b/java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/gwt/StringListEditorCompositePO.java index 59c247b8112..3e332171fea 100644 --- a/java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/gwt/StringListEditorCompositePO.java +++ b/java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/gwt/StringListEditorCompositePO.java @@ -47,11 +47,11 @@ public class StringListEditorCompositePO extends PageArea { return new GenericCellTablePO<>(this.driver, this.valueGrid, ValueEntryPO.class); } - public ValueEntryPO findValue(final String permission) { + public ValueEntryPO findValue(final String valueToFind) { final CellTablePO table = getExpandedValuesGrid(); for (ValueEntryPO entry : table.getEntries()) { final String name = entry.getValueEntryName(); - if (name != null) { + if (name != null && name.equals(valueToFind)) { return entry; } }