diff --git a/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/abstractlog/race/RaceLogTagEvent.java b/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/abstractlog/race/RaceLogTagEvent.java index 637b5bf7735..069af85e9c9 100644 --- a/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/abstractlog/race/RaceLogTagEvent.java +++ b/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/abstractlog/race/RaceLogTagEvent.java @@ -6,16 +6,16 @@ import com.sap.sse.common.TimePoint; public interface RaceLogTagEvent extends RaceLogEvent, Revokable { String getTag(); - + String getUsername(); - + String getComment(); - - String getImageURL(); - + + String getImageURL(); + boolean isVisibleForPublic(); void markAsRevoked(TimePoint revokedAt); - + TimePoint getRevokedAt(); } diff --git a/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/abstractlog/race/impl/RaceLogTagEventImpl.java b/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/abstractlog/race/impl/RaceLogTagEventImpl.java index a74a4a6be38..89620d2d035 100644 --- a/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/abstractlog/race/impl/RaceLogTagEventImpl.java +++ b/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/abstractlog/race/impl/RaceLogTagEventImpl.java @@ -57,8 +57,13 @@ public class RaceLogTagEventImpl extends RaceLogEventImpl implements RaceLogTagE return username; } + @Override + public boolean isVisibleForPublic() { + return visibleForPublic; + } + /** - * Only sets revokedAt if tag is not already revoked and given timepoint is not null. + * Only sets revokedAt if tag is not already revoked and given TimePoint is not null. */ @Override public void markAsRevoked(TimePoint revokedAt) { @@ -83,10 +88,6 @@ public class RaceLogTagEventImpl extends RaceLogEventImpl implements RaceLogTagE } @Override - public boolean isVisibleForPublic() { - return visibleForPublic; - } - public boolean equals(Object obj) { if (this == obj) return true; diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagNumberFilterUIFactory.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagNumberFilterUIFactory.java deleted file mode 100644 index 39172102a72..00000000000 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagNumberFilterUIFactory.java +++ /dev/null @@ -1,37 +0,0 @@ -package com.sap.sailing.gwt.ui.client.shared.filter; - -import java.util.ArrayList; -import java.util.List; - -import com.google.gwt.user.client.ui.ListBox; -import com.sap.sailing.gwt.ui.shared.TagDTO; -import com.sap.sse.common.filter.BinaryOperator; -import com.sap.sse.common.filter.NumberFilter; -import com.sap.sse.gwt.client.dialog.DataEntryDialog; - -public abstract class AbstractTagNumberFilterUIFactory implements FilterUIFactory { - protected List supportedOperators; - protected BinaryOperator.Operators defaultOperator; - protected NumberFilter tagNumberFilter; - - public AbstractTagNumberFilterUIFactory(NumberFilter tagNumberFilter, BinaryOperator.Operators defaultOperator) { - this.tagNumberFilter = tagNumberFilter; - this.defaultOperator = defaultOperator; - supportedOperators = new ArrayList(); - } - - protected ListBox createOperatorSelectionListBox(DataEntryDialog dataEntryDialog) { - ListBox operatorsListBox = dataEntryDialog.createListBox(false); - int i = 0; - for (BinaryOperator.Operators op : supportedOperators) { - operatorsListBox.addItem(FilterOperatorsFormatter.format(op), op.name()); - if (tagNumberFilter.getOperator() != null && tagNumberFilter.getOperator().getName().equals(op.name())) { - operatorsListBox.setSelectedIndex(i); - } else if (defaultOperator != null && defaultOperator.equals(op)) { - operatorsListBox.setSelectedIndex(i); - } - i++; - } - return operatorsListBox; - } -} diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagTextFilterUIFactory.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagTextFilterUIFactory.java index b9196987eb3..f0a7e90a441 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagTextFilterUIFactory.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagTextFilterUIFactory.java @@ -10,7 +10,7 @@ import com.sap.sse.common.filter.TextOperator; import com.sap.sse.gwt.client.dialog.DataEntryDialog; public abstract class AbstractTagTextFilterUIFactory implements FilterUIFactory { - + protected List supportedOperators; protected TextOperator.Operators defaultOperator; protected TextFilter tagTextFilter; @@ -24,9 +24,9 @@ public abstract class AbstractTagTextFilterUIFactory implements FilterUIFactory< protected ListBox createOperatorSelectionListBox(DataEntryDialog dataEntryDialog) { ListBox operatorsListBox = dataEntryDialog.createListBox(false); int i = 0; - for(TextOperator.Operators op: supportedOperators) { + for (TextOperator.Operators op : supportedOperators) { operatorsListBox.addItem(FilterOperatorsFormatter.format(op), op.name()); - if(tagTextFilter.getOperator() != null && tagTextFilter.getOperator().getName().equals(op.name())) { + if (tagTextFilter.getOperator() != null && tagTextFilter.getOperator().getName().equals(op.name())) { operatorsListBox.setSelectedIndex(i); } else if (defaultOperator != null && defaultOperator.equals(op)) { operatorsListBox.setSelectedIndex(i); diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagsFilterSetDialog.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagsFilterSetDialog.java index 24f26d8b7dc..7cec10548bc 100644 --- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagsFilterSetDialog.java +++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/filter/AbstractTagsFilterSetDialog.java @@ -36,18 +36,18 @@ public abstract class AbstractTagsFilterSetDialog extends DataEntryDialog filterEditWidgets; private final List> filterUIFactories; private final List