diff --git a/java/com.sap.sse.security.userstore.mongodb/src/com/sap/sse/security/userstore/mongodb/impl/Activator.java b/java/com.sap.sse.security.userstore.mongodb/src/com/sap/sse/security/userstore/mongodb/impl/Activator.java index d9a90c5cc14..73782cd327a 100644 --- a/java/com.sap.sse.security.userstore.mongodb/src/com/sap/sse/security/userstore/mongodb/impl/Activator.java +++ b/java/com.sap.sse.security.userstore.mongodb/src/com/sap/sse/security/userstore/mongodb/impl/Activator.java @@ -59,7 +59,7 @@ public class Activator implements BundleActivator { MongoDBService.INSTANCE.registerExclusively(CollectionNames.class, name.name()); } - new Thread(getClass().getName() + "userstore after SecurityService async startup") { + new Thread(getClass().getName() + "migrate ownerships after security service is ready") { public void run() { try { final ServiceTracker securityServiceServiceTracker = new ServiceTracker<>( diff --git a/java/com.sap.sse.security.userstore.mongodb/src/com/sap/sse/security/userstore/mongodb/impl/DomainObjectFactoryImpl.java b/java/com.sap.sse.security.userstore.mongodb/src/com/sap/sse/security/userstore/mongodb/impl/DomainObjectFactoryImpl.java index 78385593c01..bc496cff0cd 100644 --- a/java/com.sap.sse.security.userstore.mongodb/src/com/sap/sse/security/userstore/mongodb/impl/DomainObjectFactoryImpl.java +++ b/java/com.sap.sse.security.userstore.mongodb/src/com/sap/sse/security/userstore/mongodb/impl/DomainObjectFactoryImpl.java @@ -281,7 +281,9 @@ public class DomainObjectFactoryImpl implements DomainObjectFactory { // migrate old admins to new admin! if (roleDefinition.getName().equals(o.toString())) { logger.info("Found role "+roleDefinition+" for old role "+o.toString()+" for user "+name); - // we do not do role associations, to stay similar as before, so + // we do not do role associations, to stay similar as before, meaning that all admins can + // edit the roles. Without this we would need to determine which admin (if + // multiple present) should own this association. roles.add(new Role(roleDefinition, defaultTenantForRoleMigration, /* user qualification */ null)); rolesMigrated = true;