From a66ffac4b3bdda36dce3047d32db4cf868638366 Mon Sep 17 00:00:00 2001 From: Axel Uhl Date: Mon, 19 Mar 2018 17:49:05 +0100 Subject: [PATCH] in StoreAndLoadCompetitorsTest drop the COMPETITORS, not the COMPETITORS_BAK collection, also now the BOATS collection Change-Id: Ic65e0bee3de5b8fe76d74c4bcb0fe2cafc01e9aa --- .../base/impl/TransientCompetitorStoreImpl.java | 3 --- .../mongodb/test/StoreAndLoadCompetitorsTest.java | 15 +++++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/base/impl/TransientCompetitorStoreImpl.java b/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/base/impl/TransientCompetitorStoreImpl.java index 8369f9d5809..7a5dbfe93d2 100755 --- a/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/base/impl/TransientCompetitorStoreImpl.java +++ b/java/com.sap.sailing.domain.shared.android/src/com/sap/sailing/domain/base/impl/TransientCompetitorStoreImpl.java @@ -54,11 +54,9 @@ public class TransientCompetitorStoreImpl implements CompetitorStore, Serializab private transient WeakHashMap weakCompetitorDTOCache; - private final Set boatsToUpdateDuringGetOrCreate; private transient WeakHashMap weakBoatDTOCache; - private final NamedReentrantReadWriteLock lock; @@ -69,7 +67,6 @@ public class TransientCompetitorStoreImpl implements CompetitorStore, Serializab competitorsToUpdateDuringGetOrCreate = new HashSet(); weakCompetitorDTOCache = new WeakHashMap(); competitorUpdateListeners = Collections.synchronizedSet(new HashSet()); - boatCache = new HashMap(); boatsByIdAsString = new HashMap(); boatsToUpdateDuringGetOrCreate = new HashSet(); diff --git a/java/com.sap.sailing.mongodb.test/src/com/sap/sailing/mongodb/test/StoreAndLoadCompetitorsTest.java b/java/com.sap.sailing.mongodb.test/src/com/sap/sailing/mongodb/test/StoreAndLoadCompetitorsTest.java index aafbfcec91f..ff3156e43f6 100755 --- a/java/com.sap.sailing.mongodb.test/src/com/sap/sailing/mongodb/test/StoreAndLoadCompetitorsTest.java +++ b/java/com.sap.sailing.mongodb.test/src/com/sap/sailing/mongodb/test/StoreAndLoadCompetitorsTest.java @@ -72,11 +72,14 @@ public class StoreAndLoadCompetitorsTest extends AbstractMongoDBTest { domainFactory = new DomainFactoryImpl((srlid)->null); } - private void dropCompetitorCollection() { + private void dropCompetitorAndBoatsCollection() { DB db = getMongoService().getDB(); - DBCollection competitorCollection = db.getCollection(CollectionNames.COMPETITORS_BAK.name()); + DBCollection competitorCollection = db.getCollection(CollectionNames.COMPETITORS.name()); competitorCollection.setWriteConcern(WriteConcern.SAFE); // ensure that the drop() has happened competitorCollection.drop(); + DBCollection boatsCollection = db.getCollection(CollectionNames.BOATS.name()); + boatsCollection.setWriteConcern(WriteConcern.SAFE); // ensure that the drop() has happened + boatsCollection.drop(); } @Test @@ -90,7 +93,7 @@ public class StoreAndLoadCompetitorsTest extends AbstractMongoDBTest { MongoObjectFactory mongoObjectFactory = PersistenceFactory.INSTANCE.getMongoObjectFactory(getMongoService()); DomainObjectFactory domainObjectFactory = PersistenceFactory.INSTANCE.getDomainObjectFactory(getMongoService(), domainFactory); - dropCompetitorCollection(); + dropCompetitorAndBoatsCollection(); DynamicCompetitor c = (DynamicCompetitor) createCompetitor(competitorName1); c.setShortName(competitorShortName1); @@ -121,7 +124,7 @@ public class StoreAndLoadCompetitorsTest extends AbstractMongoDBTest { public void testStoreAndUpdateCompetitorWithUUIDAsId() { MongoObjectFactory mongoObjectFactory = PersistenceFactory.INSTANCE.getMongoObjectFactory(getMongoService()); DomainObjectFactory domainObjectFactory = PersistenceFactory.INSTANCE.getDomainObjectFactory(getMongoService(), domainFactory); - dropCompetitorCollection(); + dropCompetitorAndBoatsCollection(); DynamicCompetitor c = (DynamicCompetitor) createCompetitor("Hasso", UUID.randomUUID()); mongoObjectFactory.storeCompetitor(c); @@ -135,7 +138,7 @@ public class StoreAndLoadCompetitorsTest extends AbstractMongoDBTest { public void testStoreAndRemoveCompetitor() { MongoObjectFactory mongoObjectFactory = PersistenceFactory.INSTANCE.getMongoObjectFactory(getMongoService()); DomainObjectFactory domainObjectFactory = PersistenceFactory.INSTANCE.getDomainObjectFactory(getMongoService(), domainFactory); - dropCompetitorCollection(); + dropCompetitorAndBoatsCollection(); DynamicCompetitor c = (DynamicCompetitor) createCompetitor("Hasso"); mongoObjectFactory.storeCompetitor(c); @@ -149,7 +152,7 @@ public class StoreAndLoadCompetitorsTest extends AbstractMongoDBTest { public void testStoreAndRemoveCompetitorWithUUIDAsId() { MongoObjectFactory mongoObjectFactory = PersistenceFactory.INSTANCE.getMongoObjectFactory(getMongoService()); DomainObjectFactory domainObjectFactory = PersistenceFactory.INSTANCE.getDomainObjectFactory(getMongoService(), domainFactory); - dropCompetitorCollection(); + dropCompetitorAndBoatsCollection(); DynamicCompetitor c = (DynamicCompetitor) createCompetitor("Hasso", UUID.randomUUID()); mongoObjectFactory.storeCompetitor(c);