From bbbd43e14ba94124f7f314c07826065a22c58dfe Mon Sep 17 00:00:00 2001
From: Robert Benedikt <robert.benedikt@sap.com>
Date: Wed, 26 Jun 2019 16:22:50 +0200
Subject: [PATCH] Fix preference input and persistence for a set of values

---
 .../res/layout/edit_set_preference.xml                       | 2 +-
 .../preference/EditSetPreferenceDialogFragmentCompat.java    | 1 -
 .../sailing/android/shared/ui/views/EditSetPreference.java   | 5 +++++
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/mobile/com.sap.sailing.android.shared/res/layout/edit_set_preference.xml b/mobile/com.sap.sailing.android.shared/res/layout/edit_set_preference.xml
index a54c94781e0..f8b594bf7bd 100644
--- a/mobile/com.sap.sailing.android.shared/res/layout/edit_set_preference.xml
+++ b/mobile/com.sap.sailing.android.shared/res/layout/edit_set_preference.xml
@@ -17,7 +17,7 @@
             android:layout_weight="1"
             android:completionThreshold="1"
             android:hint="@string/enter_new_item"
-            android:inputType="textNoSuggestions|textVisiblePassword" />
+            android:inputType="textCapWords|textNoSuggestions" />
 
         <Button
             android:id="@+id/edit_set_preference_add"
diff --git a/mobile/com.sap.sailing.android.shared/src/com/sap/sailing/android/shared/ui/fragments/preference/EditSetPreferenceDialogFragmentCompat.java b/mobile/com.sap.sailing.android.shared/src/com/sap/sailing/android/shared/ui/fragments/preference/EditSetPreferenceDialogFragmentCompat.java
index e5af588e84a..618094920e4 100644
--- a/mobile/com.sap.sailing.android.shared/src/com/sap/sailing/android/shared/ui/fragments/preference/EditSetPreferenceDialogFragmentCompat.java
+++ b/mobile/com.sap.sailing.android.shared/src/com/sap/sailing/android/shared/ui/fragments/preference/EditSetPreferenceDialogFragmentCompat.java
@@ -96,7 +96,6 @@ public class EditSetPreferenceDialogFragmentCompat extends PreferenceDialogFragm
                 && preference.callChangeListener(values)) {
             ExLog.i(getContext(), TAG, "Storing result...");
             preference.persistStringSet(values);
-            currentValues = values;
         }
     }
 }
diff --git a/mobile/com.sap.sailing.android.shared/src/com/sap/sailing/android/shared/ui/views/EditSetPreference.java b/mobile/com.sap.sailing.android.shared/src/com/sap/sailing/android/shared/ui/views/EditSetPreference.java
index c9ea9d0725b..9fee30128ba 100644
--- a/mobile/com.sap.sailing.android.shared/src/com/sap/sailing/android/shared/ui/views/EditSetPreference.java
+++ b/mobile/com.sap.sailing.android.shared/src/com/sap/sailing/android/shared/ui/views/EditSetPreference.java
@@ -77,4 +77,9 @@ public class EditSetPreference extends DialogPreference {
         return value == null ? null : new HashSet<>(value);
     }
 
+    @Override
+    public boolean persistStringSet(Set<String> values) {
+        currentValues = values;
+        return super.persistStringSet(values);
+    }
 }