From f1ab1cc28383f3c685b04b361b47f2d9e85d72dd Mon Sep 17 00:00:00 2001
From: Axel Uhl <axel.uhl@sap.com>
Date: Thu, 7 Jan 2021 21:29:59 +0100
Subject: [PATCH] ignore ORC tests if no certificates are found and issue a
 warning to the log instead of failing

---
 .../orc/FailIfNoValidOrcCertificateRule.java     | 16 +++++++++-------
 .../domain/orc/FailIfNoValidOrcCertificates.java |  7 +++----
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/orc/FailIfNoValidOrcCertificateRule.java b/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/orc/FailIfNoValidOrcCertificateRule.java
index 3c0ab7f42fa..85f35310051 100644
--- a/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/orc/FailIfNoValidOrcCertificateRule.java
+++ b/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/orc/FailIfNoValidOrcCertificateRule.java
@@ -5,8 +5,8 @@ import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
+import java.util.logging.Logger;
 
-import org.junit.Assert;
 import org.junit.rules.TestRule;
 import org.junit.runner.Description;
 import org.junit.runners.model.Statement;
@@ -32,8 +32,8 @@ import com.sap.sse.common.CountryCodeFactory;
  * @author Usman Ali
  *
  */
-
 public class FailIfNoValidOrcCertificateRule implements TestRule {
+    private final static Logger logger = Logger.getLogger(FailIfNoValidOrcCertificateRule.class.getName());
     private ORCPublicCertificateDatabase db = new ORCPublicCertificateDatabaseImpl();
     
     private List<ORCCertificate> availableCerts;
@@ -76,16 +76,18 @@ public class FailIfNoValidOrcCertificateRule implements TestRule {
                         orcCertificates.forEach(availableCerts::add);
                         if (orcCertificates.iterator().hasNext()) {
                             certificateExists = true;
-                            break;
+                            break; // Note: this stops after the first valid certificates for a country have been read!
                         }
                     } catch (Exception ex) {
-                        // Exceptions are ignored because we are searching for any countries orc certificate's
-                        // availability.
+                        // Exceptions are ignored because we are searching for any country's ORC certificate availability.
                     }
                 }
             }
-            Assert.assertTrue(certificateExists);
-            base.evaluate();
+            if (certificateExists) {
+                base.evaluate();
+            } else {
+                logger.warning("No certificates found. Are we at the beginning of a new year (January)? Then this may be okay. Otherwise, please check what's up!");
+            }
         }
     }
 }
\ No newline at end of file
diff --git a/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/orc/FailIfNoValidOrcCertificates.java b/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/orc/FailIfNoValidOrcCertificates.java
index 01400ab60d0..589c3195d73 100644
--- a/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/orc/FailIfNoValidOrcCertificates.java
+++ b/java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/orc/FailIfNoValidOrcCertificates.java
@@ -7,10 +7,9 @@ import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
 /***
- * A IgnoreInvalidOrcCerticates is a annotation which is used to identify whether we need to execute the
- * {@link FailIfNoValidOrcCertificateRule} for that particular test case. i.e. you can find
- * the usage of {@link FailIfNoValidOrcCertificates} in
- * {@link TestORCPublicCertificateDatabase} class.
+ * A {@link FailIfNoValidOrcCertificates} is an annotation which is used to identify whether we need to execute the
+ * {@link FailIfNoValidOrcCertificateRule} for that particular test case. i.e. you can find the usage of
+ * {@link FailIfNoValidOrcCertificates} in {@link TestORCPublicCertificateDatabase} class.
  * 
  * @author Usman Ali
  *