From fa8cb777032b056a84c53bac1d5ab2a71ffeb4e9 Mon Sep 17 00:00:00 2001
From: Axel Uhl <axel.uhl@sap.com>
Date: Sat, 29 Jun 2019 16:39:03 +0200
Subject: [PATCH] combined wind arrow now is a "tri-state" (off/on/colored)

Change-Id: I31e1dba5d347ec080508f6cd65e8567096d3b07d
---
 .../places/whatsnew/resources/SailingAnalyticsNotes.html | 6 ++++++
 .../gwt/ui/client/shared/racemap/CombinedWindPanel.java  | 9 ++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/places/whatsnew/resources/SailingAnalyticsNotes.html b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/places/whatsnew/resources/SailingAnalyticsNotes.html
index b046b1848c8..8724450a211 100755
--- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/places/whatsnew/resources/SailingAnalyticsNotes.html
+++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/places/whatsnew/resources/SailingAnalyticsNotes.html
@@ -4,6 +4,12 @@
 <div id="mainContent">
     <h4 class="articleHeadline">What's New - SAP Sailing Analytics</h4>
       <div class="innerContent">
+         <h5 class="articleSubheadline">June 2019</h5>
+         <ul class="bulletList">
+            <li>The combined wind arrow on the top left of the map now switches through three states:
+                wind visualization off, wind visualization on, wind visualization on with color.</li>
+         </ul>
+
          <h5 class="articleSubheadline">May 2019</h5>
          <ul class="bulletList">
             <li>Improvements for handicap regattas: when finishing times have been entered, leading to finish line
diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/racemap/CombinedWindPanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/racemap/CombinedWindPanel.java
index 1c8fba2ecae..7eb0e6ad87b 100644
--- a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/racemap/CombinedWindPanel.java
+++ b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/racemap/CombinedWindPanel.java
@@ -44,13 +44,16 @@ public class CombinedWindPanel extends FlowPanel {
             @Override
             public void onClick(ClickEvent event) {
                 RaceMapSettings oldRaceMapSettings = map.getSettings();
-                boolean newShowStreamletsOverlaySetting = !oldRaceMapSettings.isShowWindStreamletOverlay();
-                // TODO three states: on / colored / off
+                // when off, turn on; when on and no color, turn on color; when on with color, turn off
+                boolean newShowStreamletsOverlaySetting = oldRaceMapSettings.isShowWindStreamletOverlay() ?
+                        oldRaceMapSettings.isShowWindStreamletColors() ? false : true : true;
+                boolean newShowWindStreamletColors = oldRaceMapSettings.isShowWindStreamletOverlay() ? !oldRaceMapSettings.isShowWindStreamletColors() :
+                    false;
                 final RaceMapSettings newRaceMapSettings = new RaceMapSettings(oldRaceMapSettings.getZoomSettings(),
                         oldRaceMapSettings.getHelpLinesSettings(), oldRaceMapSettings.getTransparentHoverlines(), 
                         oldRaceMapSettings.getHoverlineStrokeWeight(), oldRaceMapSettings.getTailLengthInMilliseconds(), oldRaceMapSettings.isWindUp(),
                         oldRaceMapSettings.getBuoyZoneRadius(), oldRaceMapSettings.isShowOnlySelectedCompetitors(),
-                        oldRaceMapSettings.isShowSelectedCompetitorsInfo(), oldRaceMapSettings.isShowWindStreamletColors(),
+                        oldRaceMapSettings.isShowSelectedCompetitorsInfo(), newShowWindStreamletColors,
                         newShowStreamletsOverlaySetting, oldRaceMapSettings.isShowSimulationOverlay(),
                         oldRaceMapSettings.isShowMapControls(), oldRaceMapSettings.getManeuverTypesToShow(),
                         oldRaceMapSettings.isShowDouglasPeuckerPoints(), oldRaceMapSettings.isShowEstimatedDuration(),