trying to improve performance by making RaceDefinition.getCompetitors().contains(...) faster using LinkedHashSet

java/com.sap.sailing.domain/src/com/sap/sailing/domain/base/impl/AbstractRaceColumn.java

@@ -59,18 +59,22 @@ public abstract class AbstractRaceColumn implements RaceColumn {
     @Override
     public void setTrackedRace(Fleet fleet, TrackedRace trackedRace) {
         TrackedRace previouslyLinkedRace = this.trackedRaces.get(fleet);
-        if (trackedRace == null) {
+        if (trackedRace != previouslyLinkedRace) {
-            setRaceIdentifier(fleet, null);
+            synchronized (this) {
-            this.trackedRaces.remove(fleet);
+                if (trackedRace == null) {
-        } else {
+                    setRaceIdentifier(fleet, null);
-            this.trackedRaces.put(fleet, trackedRace);
+                    this.trackedRaces.remove(fleet);
-            this.setRaceIdentifier(fleet, trackedRace.getRaceIdentifier());
+                } else {
-        }
+                    this.trackedRaces.put(fleet, trackedRace);
-        if (previouslyLinkedRace != null) {
+                    this.setRaceIdentifier(fleet, trackedRace.getRaceIdentifier());
-            notifyListenersAboutTrackedRaceUnlinked(fleet, previouslyLinkedRace);
+                }
-        }
+            }
-        if (trackedRace != null) {
+            if (previouslyLinkedRace != null) {
-            notifyListenersAboutTrackedRaceLinked(fleet, trackedRace);
+                notifyListenersAboutTrackedRaceUnlinked(fleet, previouslyLinkedRace);
+            }
+            if (trackedRace != null) {
+                notifyListenersAboutTrackedRaceLinked(fleet, trackedRace);
+            }
         }
     }
 
@@ -104,7 +108,7 @@ public abstract class AbstractRaceColumn implements RaceColumn {
     }
 
     @Override
-    public void releaseTrackedRace(Fleet fleet) {
+    public synchronized void releaseTrackedRace(Fleet fleet) {
         trackedRaces.remove(fleet);
     }
 

java/com.sap.sailing.domain/src/com/sap/sailing/domain/base/impl/RaceDefinitionImpl.java

@@ -1,6 +1,8 @@
 package com.sap.sailing.domain.base.impl;
 
 import java.io.Serializable;
+import java.util.LinkedHashSet;
+import java.util.Set;
 
 import com.sap.sailing.domain.base.BoatClass;
 import com.sap.sailing.domain.base.Competitor;
@@ -22,7 +24,11 @@ public class RaceDefinitionImpl extends NamedImpl implements RaceDefinition {
     public RaceDefinitionImpl(String name, Course course, BoatClass boatClass, Iterable<Competitor> competitors, Serializable id) {
         super(name);
         this.course = course;
-        this.competitors = competitors;
+        Set<Competitor> competitorsAsLinkedHashSet = new LinkedHashSet<Competitor>();
+        for (Competitor competitor : competitors) {
+            competitorsAsLinkedHashSet.add(competitor);
+        }
+        this.competitors = competitorsAsLinkedHashSet;
         this.boatClass = boatClass;
         this.id = id;
     }