eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-11-08 12:02:20 +00:00
Code Activity

bug6209: fixing test case, restricting random competitor selection to those considered valid

Browse Source
This commit is contained in:
Axel Uhl committed 2026-03-04 23:56:04 +01:00
1 parent 9f603d5ddd
commit 2dd61987ab
1 file changed
+9 -8
Download Patch File Download Diff File Expand all files Collapse all files
java/com.sap.sailing.domain.test/src/com/sap/sailing/domain/test/CourseChangeBasedTrackApproximationWithTracTracDataTest.java
+9 -8
View File
@@ -51,26 +51,27 @@ public class CourseChangeBasedTrackApproximationWithTracTracDataTest extends Onl
// To pick a single competitor, e.g., for debugging, use the following line:
// sampleCompetitor = (CompetitorWithBoat) Util.first(Util.filter(competitors, c->c.getName().equals("Feldmann")));
// To pick a random competitor, use the following line:
sampleCompetitor = (CompetitorWithBoat) Util.get(
Util.filter(competitors,
c -> getTrackedRace().getMarkPassing(c,
getTrackedRace().getRace().getCourse().getLastWaypoint()) != null),
new Random().nextInt(Util.size(competitors)));
final Iterable<Competitor> validCompetitors = getValidCompetitors();
sampleCompetitor = (CompetitorWithBoat) Util.get(validCompetitors, new Random().nextInt(Util.size(validCompetitors)));
sampleTrack = getTrackedRace().getTrack(sampleCompetitor);
} while (sampleTrack.isEmpty());
}
@Test
public void testAllCompetitorsThatFinished() {
for (final Competitor competitor : Util.filter(competitors,
c -> !c.getName().equals("Broise") &&
getTrackedRace().getMarkPassing(c, getTrackedRace().getRace().getCourse().getLastWaypoint()) != null)) {
for (final Competitor competitor : getValidCompetitors()) {
sampleCompetitor = (CompetitorWithBoat) competitor;
sampleTrack = getTrackedRace().getTrack(sampleCompetitor);
logger.info("Testing competitor "+sampleCompetitor.getName());
testNoDiffBetweenEarlyAndLateInitialization();
}
}
private Iterable<Competitor> getValidCompetitors() {
return Util.filter(competitors,
c -> !c.getName().equals("Broise") && // Broise has major gaps in the track, leading to deviations, not relevant for production, so exclude them
getTrackedRace().getMarkPassing(c, getTrackedRace().getRace().getCourse().getLastWaypoint()) != null);
}
/**
* During the work on bug5959 (https://bugzilla.sapsailing.com/bugzilla/show_bug.cgi?id=5959) we identified an issue