mirror of
https://github.com/eclipse-sailing-analytics/sailing-analytics.git
synced 2026-11-04 10:09:42 +00:00
fixing incorrect veto of race column addition in race execution order listener
This commit is contained in:
1 parent
1fc692e4d3
commit
3069a2d70d
6 files changed
+8
-31
No files matched your search
@@ -20,7 +20,9 @@ public interface RaceColumnListener extends Serializable {
|
||||
|
||||
void hasSplitFleetContiguousScoringChanged(RaceColumn raceColumn, boolean hasSplitFleetContiguousScoring);
|
||||
|
||||
boolean canAddRaceColumnToContainer(RaceColumn raceColumn);
|
||||
default boolean canAddRaceColumnToContainer(RaceColumn raceColumn) {
|
||||
return true;
|
||||
}
|
||||
|
||||
void raceColumnAddedToContainer(RaceColumn raceColumn);
|
||||
|
||||
|
||||
-5
@@ -63,11 +63,6 @@ public abstract class AbstractRaceColumnListener implements RaceColumnListener{
|
||||
defaultAction();
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean canAddRaceColumnToContainer(RaceColumn raceColumn) {
|
||||
return false;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void raceColumnAddedToContainer(RaceColumn raceColumn) {
|
||||
defaultAction();
|
||||
|
||||
@@ -25,6 +25,11 @@ import com.sap.sailing.domain.tracking.TrackedRegattaRegistry;
|
||||
import com.sap.sailing.util.impl.RaceColumnListeners;
|
||||
import com.sap.sse.common.Util;
|
||||
|
||||
/**
|
||||
* A series listens on its columns; however, a veto for column addition isn't done here but in a {@link RegattaLeaderboard}.
|
||||
*
|
||||
* @see #addRaceColumn(String, TrackedRegattaRegistry)
|
||||
*/
|
||||
public class SeriesImpl extends RenamableImpl implements Series, RaceColumnListener {
|
||||
private static final long serialVersionUID = -1640404303144907381L;
|
||||
private final Map<String, Fleet> fleetsByName;
|
||||
@@ -302,16 +307,6 @@ public class SeriesImpl extends RenamableImpl implements Series, RaceColumnListe
|
||||
raceColumnListeners.notifyListenersAboutIsFirstColumnIsNonDiscardableCarryForwardChanged(raceColumn, firstColumnIsNonDiscardableCarryForward);
|
||||
}
|
||||
|
||||
/**
|
||||
* A series listens on its columns; individual columns, however, don't ask whether they can be added; the series itself does.
|
||||
*
|
||||
* @see #addRaceColumn(String, TrackedRegattaRegistry)
|
||||
*/
|
||||
@Override
|
||||
public boolean canAddRaceColumnToContainer(RaceColumn raceColumn) {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void raceColumnAddedToContainer(RaceColumn raceColumn) {
|
||||
raceColumnListeners.notifyListenersAboutRaceColumnAddedToContainer(raceColumn);
|
||||
|
||||
-5
@@ -293,11 +293,6 @@ public class LeaderboardCacheManager {
|
||||
removeFromCache(leaderboard);
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean canAddRaceColumnToContainer(RaceColumn raceColumn) {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void raceColumnAddedToContainer(RaceColumn raceColumn) {
|
||||
removeFromCache(leaderboard);
|
||||
|
||||
@@ -90,11 +90,6 @@ public class RaceLogReplicator implements RaceColumnListener {
|
||||
public void hasSplitFleetContiguousScoringChanged(RaceColumn raceColumn, boolean hasSplitFleetContiguousScoring) {
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean canAddRaceColumnToContainer(RaceColumn raceColumn) {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void raceColumnAddedToContainer(RaceColumn raceColumn) {
|
||||
}
|
||||
|
||||
-5
@@ -62,11 +62,6 @@ public class RaceLogScoringReplicator implements RaceColumnListener {
|
||||
public void isFirstColumnIsNonDiscardableCarryForwardChanged(RaceColumn raceColumn, boolean firstColumnIsNonDiscardableCarryForward) {
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean canAddRaceColumnToContainer(RaceColumn raceColumn) {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void raceColumnAddedToContainer(RaceColumn raceColumn) {
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user