eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-10-20 19:20:04 +00:00
Code Activity

some code improvements

Browse Source
This commit is contained in:
fmittag committed 2016-01-28 13:07:38 +01:00
1 parent 80ab02f60f
commit b500c0cbe0
2 files changed
+16 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/places/event/regatta/analyticstab/RegattaCompetitorAnalyticsTabView.java
+8 -6
View File
@@ -26,7 +26,7 @@ import com.sap.sailing.gwt.home.shared.ExperimentalFeatures;
import com.sap.sailing.gwt.home.shared.partials.placeholder.Placeholder;
import com.sap.sailing.gwt.ui.client.CompetitorSelectionChangeListener;
import com.sap.sailing.gwt.ui.client.CompetitorSelectionModel;
import com.sap.sailing.gwt.ui.leaderboard.LeaderboardPanel;
import com.sap.sailing.gwt.ui.leaderboard.LeaderboardUpdateProvider;
import com.sap.sse.common.Util;
/**
@@ -41,7 +41,7 @@ public class RegattaCompetitorAnalyticsTabView extends SharedLeaderboardRegattaT
private Presenter currentPresenter;
private final int MAX_COMPETITORS_IN_CHART = 30;
private LeaderboardPanel leaderboardPanel;
private LeaderboardUpdateProvider leaderboardUpdateProvider = null;
public RegattaCompetitorAnalyticsTabView() {
super();
@@ -69,11 +69,11 @@ public class RegattaCompetitorAnalyticsTabView extends SharedLeaderboardRegattaT
if (regattaId != null && !regattaId.isEmpty()) {
String leaderboardName = regattaId;
RegattaAnalyticsDataManager regattaAnalyticsManager = currentPresenter.getCtx().getRegattaAnalyticsManager();
leaderboardPanel = regattaAnalyticsManager.getLeaderboardPanel();
if(leaderboardPanel == null) {
if(regattaAnalyticsManager.getLeaderboardPanel() == null) {
createSharedLeaderboardPanel(leaderboardName, regattaAnalyticsManager);
}
leaderboardPanel.addLeaderboardUpdateListener(this);
leaderboardUpdateProvider = regattaAnalyticsManager.getLeaderboardPanel();
leaderboardUpdateProvider.addLeaderboardUpdateListener(this);
initWidget(ourUiBinder.createAndBindUi(this));
DetailType initialDetailType = DetailType.REGATTA_RANK;
@@ -147,6 +147,8 @@ public class RegattaCompetitorAnalyticsTabView extends SharedLeaderboardRegattaT
@Override
protected void onUnload() {
super.onUnload();
leaderboardPanel.removeLeaderboardUpdateListener(this);
if (leaderboardUpdateProvider != null) {
leaderboardUpdateProvider.removeLeaderboardUpdateListener(this);
}
}
}
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/places/event/regatta/leaderboardtab/RegattaLeaderboardTabView.java
+8 -4
View File
@@ -19,6 +19,7 @@ import com.sap.sailing.gwt.home.desktop.places.event.regatta.SharedLeaderboardRe
import com.sap.sailing.gwt.home.desktop.places.event.regatta.EventRegattaView.Presenter;
import com.sap.sailing.gwt.home.shared.partials.placeholder.Placeholder;
import com.sap.sailing.gwt.ui.leaderboard.LeaderboardPanel;
import com.sap.sailing.gwt.ui.leaderboard.LeaderboardUpdateProvider;
/**
* Created by pgtaboada on 25.11.14.
@@ -34,7 +35,7 @@ public class RegattaLeaderboardTabView extends SharedLeaderboardRegattaTabView<R
@UiField(provided = true)
protected OldLeaderboard leaderboard;
private LeaderboardPanel leaderboardPanel;
private LeaderboardUpdateProvider leaderboardUpdateProvider = null;
public RegattaLeaderboardTabView() {
leaderboard = new OldLeaderboard(new OldLeaderboardDelegateFullscreenViewer());
@@ -62,11 +63,12 @@ public class RegattaLeaderboardTabView extends SharedLeaderboardRegattaTabView<R
if (regattaId != null && !regattaId.isEmpty()) {
String leaderboardName = regattaId;
RegattaAnalyticsDataManager regattaAnalyticsManager = currentPresenter.getCtx().getRegattaAnalyticsManager();
leaderboardPanel = regattaAnalyticsManager.getLeaderboardPanel();
LeaderboardPanel leaderboardPanel = regattaAnalyticsManager.getLeaderboardPanel();
if(leaderboardPanel == null) {
leaderboardPanel = createSharedLeaderboardPanel(leaderboardName, regattaAnalyticsManager);
}
leaderboardPanel.addLeaderboardUpdateListener(this);
leaderboardUpdateProvider = leaderboardPanel;
leaderboardUpdateProvider.addLeaderboardUpdateListener(this);
initWidget(ourUiBinder.createAndBindUi(this));
leaderboard.setLeaderboard(leaderboardPanel, currentPresenter.getAutoRefreshTimer());
if (currentPresenter.getEventDTO().getState() == EventState.RUNNING) {
@@ -109,6 +111,8 @@ public class RegattaLeaderboardTabView extends SharedLeaderboardRegattaTabView<R
@Override
protected void onUnload() {
super.onUnload();
leaderboardPanel.removeLeaderboardUpdateListener(this);
if (leaderboardUpdateProvider != null) {
leaderboardUpdateProvider.removeLeaderboardUpdateListener(this);
}
}
}