eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-11-07 19:42:17 +00:00
Code Activity

aftermath for d3698bc608: ConcurrentWeakHashMap cannot deal with null values; using dummy object instead

Browse Source 
Change-Id: I2f3c892aed8e35ffc3efda098e1ff2d611250a48
This commit is contained in:
Axel Uhl committed 2019-05-27 10:03:50 +02:00
1 parent d3698bc608
commit e75d1b17b8
1 file changed
+4 -2
Download Patch File Download Diff File Expand all files Collapse all files
java/com.sap.sse.security/src/com/sap/sse/security/SecurityWebSessionManager.java
+4 -2
View File
@@ -38,7 +38,9 @@ public class SecurityWebSessionManager extends DefaultWebSessionManager {
*/
private static final Duration MAX_DURATION_AFTER_WHICH_TO_PING_SESSION = Duration.ONE_HOUR;
private static final ConcurrentWeakHashMap<Session, Void> sessionsAlreadyScheduledForOnChange = new ConcurrentWeakHashMap<>();
private static final Object DUMMY = new Object(); // for use as dummy value in sessionsAlreadyScheduledForOnChange
private static final ConcurrentWeakHashMap<Session, Object> sessionsAlreadyScheduledForOnChange = new ConcurrentWeakHashMap<>();
public SecurityWebSessionManager() {
super();
@@ -55,7 +57,7 @@ public class SecurityWebSessionManager extends DefaultWebSessionManager {
private void triggerOnChangeLatestInHalfTimeoutPeriod(Session s) {
Duration sendDurationLatestIn = new MillisecondsDurationImpl(s.getTimeout()).minus(MAX_DURATION_ASSUMED_FOR_MESSAGE_DELIVERY);
if (!sessionsAlreadyScheduledForOnChange.containsKey(s)) {
sessionsAlreadyScheduledForOnChange.put(s, null);
sessionsAlreadyScheduledForOnChange.put(s, DUMMY);
timer.schedule(()->{ onChange(s); sessionsAlreadyScheduledForOnChange.remove(s); },
MillisecondsTimePoint.now().plus(
sendDurationLatestIn.compareTo(MAX_DURATION_AFTER_WHICH_TO_PING_SESSION) > 0 ?