eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-10-03 10:53:49 +00:00
Code Activity

Bug 4104: Removed duplicate footer refreshes which caused unnecessary whitespace to appear

Browse Source
This commit is contained in:
Henri Kohlberg committed 2018-09-19 16:27:42 +02:00
1 parent 239b918a58
commit f2b1fafc2c
2 files changed
+5 -16
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/raceboard/tagging/TagFooterPanel.java
+5 -9
View File
@@ -4,8 +4,8 @@ import com.google.gwt.user.client.ui.FlowPanel;
import com.sap.sailing.gwt.ui.raceboard.tagging.TaggingPanel.State; import com.sap.sailing.gwt.ui.raceboard.tagging.TaggingPanel.State;
/** /**
* Panel containg {@link TagModificationPanel} and {@link TagButtonPanel} which is used as {@link TaggingPanel#footerPanel * Panel containg {@link TagModificationPanel} and {@link TagButtonPanel} which is used as
* footer} in {@link TaggingPanel}. * {@link TaggingPanel#footerPanel footer} in {@link TaggingPanel}.
*/ */
public class TagFooterPanel extends FlowPanel { public class TagFooterPanel extends FlowPanel {
@@ -38,8 +38,8 @@ public class TagFooterPanel extends FlowPanel {
/** /**
* Sets visibility of {@link TagModificationPanel input fields} for new tag and {@link TaggingPanel#createTagsButton * Sets visibility of {@link TagModificationPanel input fields} for new tag and {@link TaggingPanel#createTagsButton
* "Edit Tag-Buttons"-button}. {@link TagModificationPanel Input fields} will not be hidden but removed completly from * "Edit Tag-Buttons"-button}. {@link TagModificationPanel Input fields} will not be hidden but removed completly
* DOM in case <code>visible</code> is set to <code>false</code>! * from DOM in case <code>visible</code> is set to <code>false</code>!
* *
* @param visible * @param visible
* should be <code>true</code> when user is logged in and {@link TaggingPanel} is in * should be <code>true</code> when user is logged in and {@link TaggingPanel} is in
@@ -48,10 +48,8 @@ public class TagFooterPanel extends FlowPanel {
protected void setInputFieldsVisibility(boolean visible) { protected void setInputFieldsVisibility(boolean visible) {
if (visible) { if (visible) {
add(tagModificationPanel); add(tagModificationPanel);
taggingPanel.refreshFooterPanel();
} else { } else {
remove(tagModificationPanel); remove(tagModificationPanel);
taggingPanel.refreshFooterPanel();
} }
} }
@@ -65,10 +63,8 @@ public class TagFooterPanel extends FlowPanel {
protected void setTagButtonsVisibility(boolean visible) { protected void setTagButtonsVisibility(boolean visible) {
if (visible && taggingPanel.getTagButtons().size() > 0) { if (visible && taggingPanel.getTagButtons().size() > 0) {
add(tagButtonPanel); add(tagButtonPanel);
taggingPanel.refreshFooterPanel();
} else { } else {
remove(tagButtonPanel); remove(tagButtonPanel);
taggingPanel.refreshFooterPanel();
} }
} }
@@ -87,7 +83,7 @@ public class TagFooterPanel extends FlowPanel {
tagModificationPanel.setCurrentStatus(state); tagModificationPanel.setCurrentStatus(state);
} }
} }
/** /**
* If height of the {@link TagButtonPanel tagButtonPanel} has changed after deleting (delta height does not equal * If height of the {@link TagButtonPanel tagButtonPanel} has changed after deleting (delta height does not equal
* 0), the {@link TaggingPanel#footerPanel footer widget} of the {@link TaggingPanel} has a different height, which * 0), the {@link TaggingPanel#footerPanel footer widget} of the {@link TaggingPanel} has a different height, which
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/raceboard/tagging/TaggingPanel.java
-7
View File
@@ -405,13 +405,6 @@ public class TaggingPanel extends ComponentWithoutSettings
taggingPanel.setContentWidget(contentPanel); taggingPanel.setContentWidget(contentPanel);
} }
/**
* Forces {@link #footerPanel} to rerender.
*/
protected void refreshFooterPanel() {
taggingPanel.setFooterWidget(footerPanel);
}
/** /**
* Adds {@link TagButton} to {@link #tagButtons list} of all {@link TagButton tag-buttons} and applies * Adds {@link TagButton} to {@link #tagButtons list} of all {@link TagButton tag-buttons} and applies
* {@link com.google.gwt.event.dom.client.ClickHandler ClickHandler} on it which allows saving of tags. * {@link com.google.gwt.event.dom.client.ClickHandler ClickHandler} on it which allows saving of tags.