use braces also for single-statement blocks; use single-return policy

This commit is contained in:
Axel Uhl
2013-03-01 01:15:08 -08:00
parent 29ed4192ed
commit ffe0f03fca
@@ -311,17 +311,17 @@ public class RegattaStructureManagementPanel extends SimplePanel implements Rega
}
protected String getCourseAreaName(String defaultCourseAreaId) {
if (defaultCourseAreaId == null)
return "";
for (EventDTO event : existingEvents) {
for (CourseAreaDTO courseArea : event.venue.getCourseAreas()) {
if (courseArea.id.equals(defaultCourseAreaId)) {
return courseArea.name;
String result = "";
if (defaultCourseAreaId != null) {
for (EventDTO event : existingEvents) {
for (CourseAreaDTO courseArea : event.venue.getCourseAreas()) {
if (courseArea.id.equals(defaultCourseAreaId)) {
result = courseArea.name;
}
}
}
}
return "";
return result;
}
private void editRacesOfRegattaSeries(final RegattaDTO regatta) {