Axel Uhl
16196258c9
restored DeviceIdentifier serialization/deserialization test functionality from removed RaceLogSerializationTest
...
Change-Id: Icfbf819c7a766ec1035db717fc6cf72bf560f9dd
2016-01-18 16:34:44 +01:00
Axel Uhl
a5e4ccb465
removed FIXME; append /fleetName to list of races containing mark
...
Change-Id: I62facd34621de2080a94c710ab4d2272b71200ef
2016-01-18 15:51:00 +01:00
Axel Uhl
cf9dd8f662
replaced equals check on RaceLog by ==
...
Change-Id: I80a7bab98377b63e9068ed48eed36a25089c9a48
2016-01-18 15:40:55 +01:00
Axel Uhl
aff525180e
single point of exit pattern
...
Change-Id: I5c8040a5babc3f4562c116fbb9a041da813b01d6
2016-01-18 15:38:37 +01:00
Axel Uhl
22471f9903
made a few variables final; removed redundant cast
...
Change-Id: I244d0259aceb4d084d048d0e58292481317da5e6
2016-01-18 15:34:38 +01:00
Axel Uhl
d6cd41def9
improved Javadoc
...
Change-Id: I86022d11facc9e799ab23a13ba483b5cff482b3e
2016-01-18 15:29:16 +01:00
Axel Uhl
7b9321336e
avoid redundant contains/remove double lookup in SailingServiceImpl.findDuplicates
...
Change-Id: I65eba92b15187ae489cbb6c7d59adf8303a41496
2016-01-18 15:21:01 +01:00
Axel Uhl
c4fb89fb38
refined exception list of SailingServiceImpl.denoteForRaceLogTracking
...
Change-Id: Iaf17608e35020c428c629eecf2c5170edb3f97fb
2016-01-18 15:13:24 +01:00
Axel Uhl
bfc35601ce
replaced use of SailingServiceImpl.sizeOf by Util.isEmpty() and removed sizeOf
...
Change-Id: I2b6a49b897790030618ce73abe5b83f5cf79d90d
2016-01-18 15:08:06 +01:00
Axel Uhl
1d9f04992f
introducing equals/hashCode on DeviceMappingDTO; reducing entity comparison for DeviceMappingDTO to its equals/hashCode definition
...
Change-Id: I9ce39fa3f560fd1280100adfe0612cfbe41ef094
2016-01-18 12:36:53 +01:00
Axel Uhl
259f61d96d
coding conventions in RegattaLogTrackingDeviceMappingsDialog
...
Change-Id: I5a5e2735da23d432d910666522fc27240a4f2532
2016-01-18 11:38:30 +01:00
Axel Uhl
e7584e6c90
merged AbstractLogTrackingDeviceMappingsDialog into only subclass RegattaLogTrackingDeviceMappingsDialog
...
Change-Id: Ifce7a064817bb90eae1471db933e7db74bb4bcfe
2016-01-18 11:34:55 +01:00
Axel Uhl
9b1e11b0c9
merged AbstractLogAddDeviceMappingDialog into RegattaLogAddDeviceMappingDialog
...
Change-Id: I776f5d2017c669fdd083a1f9addf06781e2c28bb
2016-01-18 11:28:05 +01:00
Axel Uhl
884f071972
added i18n for course management panel
...
Change-Id: Ie12db85b6eb88c463752853148f33ab2a570f2a5
2016-01-18 11:18:45 +01:00
Axel Uhl
3ef139d0dc
use Util.getDominantObject in RaceLogTrackingAdapterImpl when denoting a race for smartphone tracking
...
Change-Id: I454c0ce3bdf72e3c919e0eaa63df85a77a6f0601
2016-01-18 10:48:29 +01:00
Axel Uhl
4286652f3a
changed scope of move method from package to protected
...
Change-Id: I39b40fa6eb9b2f385d7da21322b7f434ee439441
2016-01-18 09:31:31 +01:00
Axel Uhl
babd76d4a3
formatting changes only
...
Change-Id: Ie9442d4229d8f773d40f6f632aa8a94a527b0188
2016-01-18 09:27:16 +01:00
Axel Uhl
80a34a7a0e
fixed test verdict: no artificial mark ping fix is generated anymore
...
Change-Id: Iace233127fcf03972e0c5ddc7a00061be69d6768
2016-01-15 20:15:03 +01:00
Axel Uhl
981c843381
fixed cancel behavior for toggling "Register Competitors on Race"
...
Change-Id: Ic4c299797365fc481e7f65b013a3eac929f39fce
2016-01-15 18:09:38 +01:00
Axel Uhl
c5f9d0b2a0
validate race competitor registration dialog: it's invalid (not saveable) if the race does not support per-race competitor registrations
...
Change-Id: I683234365c642c40a1ae70cd98b7d491c11af753
2016-01-15 18:04:15 +01:00
Axel Uhl
46e5f927ae
allow user to add any competitor to a RaceLog, not only those registered for the regatta
...
Change-Id: I01d844cb06a6dfaba11b6338a0824e36551f4e08
2016-01-15 17:32:22 +01:00
Axel Uhl
132bde4686
use DeviceMappingConstants for postCheckout endpoint
...
Change-Id: Ia8f1a77877304d32d6336fe9fbf6eb9ee66e62b6
2016-01-15 16:59:40 +01:00
Axel Uhl
57c6e5ac89
LeaderboardsResource.pingMark no longer returns a lastKnownPosition in its response, only an OK
...
Change-Id: Id57cbcbb876bf04707a8cb14046b962d44221485
2016-01-15 16:33:02 +01:00
Axel Uhl
d57265f72c
added a confirmation popup when toggling the "Show only competitors from log" checkbox which may lose user input
...
Change-Id: I8d08a8a99d630e4b0474b5926505c38781d576ec
2016-01-15 15:27:52 +01:00
Axel Uhl
27a82505aa
fixed clear() vs. removeAll() issue in filtered competitor panel
...
Change-Id: Ie1bfad9c2ff921ad806b72de043c91a4c740aacb
2016-01-15 15:10:02 +01:00
Axel Uhl
1c3834de91
removed a bunch of empty lines
...
Change-Id: Ifa3c076996b489c8f52c328f1106b3108b67c3a2
2016-01-15 14:46:14 +01:00
Axel Uhl
01dfe544c2
consolidated imports
...
Change-Id: I1b6e5a77e73d1860cde00eadbdd1b71a5e518616
2016-01-15 14:39:28 +01:00
Axel Uhl
f1e1623c2c
improved the implementation of AbstractCompetitorRegistrationsDialog.move, avoiding intermediate collections to be constructed
...
Change-Id: I27baa65771a8417e79289d8de2ebca41b2ff8c3e
2016-01-15 14:37:56 +01:00
Axel Uhl
32f914c0ea
coding conventions, and added a FIXME for showing a confirmation dialog at least before toggling "Show only competitors from log" otherwise losing user input
...
Change-Id: I3b79a60d55a3cc39dbb004bc7160925483eef007
2016-01-15 14:30:55 +01:00
Axel Uhl
b7e7b83778
some minor method renames and making variables final where possible
...
Change-Id: I21880695f4a7a34488eed38e1cdd650ded8c704d
2016-01-15 14:12:16 +01:00
Axel Uhl
c616e0181d
made showOnlyCompetitorsOfLog protected because it is not used outside of subclasses
...
Change-Id: I64e68ebd99311718c31ed4cb23d9636bb3fb076c
2016-01-15 13:51:32 +01:00
Axel Uhl
4d0fb5f865
don't create artificial "anti-creep" mark fixes anymore; see bug 3421 and bug 3422 about abandoning interpolation on mark tracks
...
Change-Id: I38cba61bbc004ca028c6d87adc7507ac9c1db4fc
2016-01-15 12:18:48 +01:00
Axel Uhl
f042f5e4f0
simplified pingMark implementation in RaceLogTrackingAdapterImpl, as marks can only be pinged in RegattaLogs now
...
Change-Id: I5418a24f1c803631e8f0062a2f6440d026d513f8
2016-01-15 10:03:13 +01:00
Axel Uhl
575fe2c71a
restored Javadoc comment for pingMark which was lost in commit 966b17b178
...
Change-Id: Ib1e6085b7b2a4147cae6b36537380cc1cd8e47fa
2016-01-15 09:57:33 +01:00
Axel Uhl
d7e8d4d5f8
removed the unused class LastPingMappingEventFinder
...
Change-Id: Ie9bcd796c58da105ad5ab8b1df7e10b5beb65246
2016-01-15 09:38:56 +01:00
Axel Uhl
4014d8af2a
removing unused RaceLog parameter from RacingEventService.getMarkPosition and updating Javadoc accordingly
...
Change-Id: Idd8355039a22b0e52078db8935fa92d2fb911ed0
2016-01-15 09:35:40 +01:00
Axel Uhl
16651d5aa6
Merge branch 'master' into bug2851
2016-01-14 21:22:44 +01:00
Axel Uhl
1fd73439ef
let NotDenotableForRaceLogTrackingException trickle up as it was declared on RaceLogTrackingAdapterImpl.denoteAllRacesForRaceLogTracking anyhow
...
Change-Id: I083a9631c82e44c300955ff017bc9834c41ee542
2016-01-14 17:07:45 +01:00
Axel Uhl
8c06b43e18
replaced sizeOf(...)>0 by calls to !Util.isEmpty
...
Change-Id: I3b97f34559f3aa471c8fdb8c16512c1ecec2aecc
2016-01-14 17:03:51 +01:00
Axel Uhl
19adb0a7eb
improved Javadocs
...
Change-Id: I080a03728f304b61059234442377f4765e53e550
2016-01-14 16:57:44 +01:00
Axel Uhl
b45b2ffab0
whtitespace and formatting changes only
...
Change-Id: I8075e648af46f86d826ab5e35d6ff21d914dc74e
2016-01-14 16:54:12 +01:00
Axel Uhl
6795767e2a
renamed getMapping to createMapping
...
Change-Id: Ic25ab6131381ad762df2457d3d64a20e6503157b
2016-01-14 16:34:29 +01:00
Axel Uhl
06c6a783e7
adjusted updateStartAndEndOfTracking such that open intervals lead to the start/end of tracking to be the beginning/end of time
...
Change-Id: I6138d7c138962194df83b44f22db3c9d19ea5772
2016-01-14 16:29:46 +01:00
Axel Uhl
93a4f649be
added Javadoc, made implementation of updateStartEndEndOfTracking robust against open intervals / time ranges
...
Change-Id: Ibfd34c42697409dd6ef78cf35ec6ca061b0803f7
2016-01-14 16:21:03 +01:00
Axel Uhl
bd8ba0ea2c
(re-)created RaceLogTrackingAdapter.copyCompetitors and call it from SailingServiceImpl
...
Change-Id: I8e860b8ca9cc82760068efa7d31d5a05594d778c
2016-01-14 14:58:24 +01:00
Axel Uhl
d2aaf40174
replaced decision by exception by a check;
...
CompetitorRegistrationOnRaceLogDisabledException can be avoided usually by a check for isCompetitorRegistrationInRaclogEnabled
Change-Id: I3c2cbe761ba0a36a1a8f21689c774c2943b5556b
2016-01-14 14:40:29 +01:00
Axel Uhl
e24b3050d4
deprecated RACE_LOG_FROM and RACE_LOG_TO
...
Change-Id: I8a9673d44f0b912930b83aed4c193fb7b6771712
2016-01-14 14:20:30 +01:00
Axel Uhl
a1b9492971
deprecated RACE_LOG_MARK, as it was replaced by REGATTA_LOG_MARK
...
Change-Id: Ia10f4c2b417f67dc375ef3435404270c34ea6187
2016-01-14 14:14:20 +01:00
Axel Uhl
f451e36b87
re-introduced TrackedRaceImpl.attachRaceLog because TrackedRaceImpl should be responsible for managing its attachedRaceLogs field
...
Change-Id: Idd26a7b71f937ad4e7f22acc8ab427c1db63b405
2016-01-14 12:19:45 +01:00
Axel Uhl
011bb4ddfc
introduced getAllCompetitors() on HasRegattaLike; all implementations already provide it; using it in LeaderboardsResource instead of only looking at RegattaLog
...
Change-Id: Ibdea059c56a5a528583fd5494afa96d6b1e85a86
2016-01-14 12:07:34 +01:00
Axel Uhl