Steffen Schaefer
663a07121e
Bug 4339: Fixed wait to work with Selenium 3.x
2018-07-19 16:37:27 +02:00
Steffen Schaefer
621c92553c
Merge branch 'bug4675' into bug4339
2018-07-19 16:31:50 +02:00
Steffen Schaefer
3ed22654e7
Bug 4675: Fixed another edge case potentially causing AutoPlay selenium
...
test to fail non deterministically
2018-07-19 16:19:52 +02:00
Steffen Schaefer
46c2d99774
Merge branch 'master' into bug4675
2018-07-19 16:12:01 +02:00
Steffen Schaefer
eaef7c8287
Bug 4675: Removed unintentionally committed @Ignore
2018-07-19 16:11:44 +02:00
Steffen Schaefer
0d20ca2bec
Merge branch 'bug4661'
2018-07-19 16:07:16 +02:00
Steffen Schaefer
75c3b797f8
Bug 4339: When creating a regatta, the dialog asking to create a
...
leaderboard isn't opened synchronously. This failed due to faster test
execution with the new selenium version. This change ensures waiting for
the dialog to open instead of assuming it is opened.
2018-07-19 16:05:43 +02:00
Steffen Schaefer
7dfdc6a786
Bug 4339: Using java.util.function.Function instead of the google.common
...
one for the newer Selenium version
2018-07-19 15:34:34 +02:00
Steffen Schaefer
a6103ed3e4
Merge branch 'bug4675' into bug4339
2018-07-19 15:27:33 +02:00
Steffen Schaefer
b407b88415
Bug 4675: Fixed a bug that caused the 60" test due to bad timing
2018-07-19 15:23:31 +02:00
Steffen Schaefer
6ade8e8057
Merge branch 'master' into bug4339
2018-07-19 14:07:58 +02:00
Axel Uhl
9e40b42ede
Merge remote-tracking branch 'server/master'
...
Change-Id: I273c100d3d93f4ba53803e5db023338bc4bc5a1e
2018-07-19 10:48:22 +02:00
Axel Uhl
5cd730c22a
fixed two tests that were relying on only one TracTrac race per event being obtained during test execution
...
Change-Id: I272f46f819b3c7411ac50e9d9668a120a251c5ad
2018-07-19 10:46:44 +02:00
Steffen Schaefer
ea92ee34cb
Bug 4661: Ensures that having more wins that required also counts as
...
overall winner. If more than one competitor reached the requires wins,
the one with more wins will be ranked better.
2018-07-19 10:44:06 +02:00
Steffen Schaefer
2580435a52
Bug 4661: Extended the JavaDocs of LowPointFirstToWinTwoRaces to explain
...
all special rules compared to the default LowPoint rules
2018-07-19 10:36:45 +02:00
Steffen Schaefer
f9d3d16f4b
Bug 4661: JavaDoc and method naming improvements
2018-07-19 10:13:52 +02:00
Steffen Schaefer
0d9775fc5c
Bug 4661: Handles the special case when two competitors reach the target
...
amount of wins necessary. This could e.g. occur while editing score
corrections.
2018-07-19 10:05:15 +02:00
Alessandro Stoltenberg
628ddf5470
Merge remote-tracking branch 'origin/bug4572'
2018-07-19 09:42:37 +02:00
Axel Uhl
b2e2beacf1
added more total rank verdicts, improved comments
...
Change-Id: I4d88400ec07de75e0af53fc904f9806f1fcf9cd4
2018-07-18 22:25:21 +02:00
Axel Uhl
c3f57fdc9a
added test verdict that actually uses the total rank comparator
...
Change-Id: I0f3bbe837fdf5d69e2d92817e7dc15818805c233
2018-07-18 22:19:58 +02:00
Axel Uhl
6d9ec55b35
fixed method name typos
...
Change-Id: Ia30f33192dd896b4c143dddef7f57ff583bf9f82
2018-07-18 22:06:36 +02:00
Axel Uhl
d182929c10
removed unused @param tag in Javadoc
...
Change-Id: I77d03456d58cf46332e2afdb0e9fbe802d049edb
2018-07-18 22:00:28 +02:00
Axel Uhl
3a9262718f
improved parameter name
...
Change-Id: Id193f1dddadb17f4512baec41f4a81f8945e5e53
2018-07-18 21:50:13 +02:00
Axel Uhl
206fee1214
cleaned up and simplified code
...
Change-Id: I1c159d3a2daa1e96c12ca48599cfadbae6983307
2018-07-18 21:46:30 +02:00
Axel Uhl
03d93bca0c
improved parameter naming
...
Change-Id: I0d6aa8f22952c19c907aaba0f90c425396abffcb
2018-07-18 21:44:14 +02:00
Axel Uhl
9d990e470d
coding conventions
...
Change-Id: I674fb13c731b3f07b09e06eb93a781a4ea7ce252
2018-07-18 21:43:37 +02:00
Axel Uhl
df234945f2
improved scoring scheme i18n text messages
...
Change-Id: I011c918be0e854023bd5572b0f283b2b69ad91f8
2018-07-18 21:41:36 +02:00
Axel Uhl
b55acabff0
reverted unnecessary formatting changes, also to ease review
...
Change-Id: Id769da07307a081194cb52096673085db6ff5062
2018-07-18 21:38:49 +02:00
Axel Uhl
21a0adc91d
added TODO for compareByMedalRacesWon; coding conventions
...
Change-Id: I0325d3f671c6218edb5017122351665457b56124
2018-07-18 21:35:09 +02:00
Axel Uhl
be06df2557
updated Javadoc in ScoringScheme to better reflect the details
...
Change-Id: I369a99e9d2b07843930fa4fa745af58e2bae20ff
2018-07-18 21:26:29 +02:00
Axel Uhl
8673bd82f5
improved Javadoc; code formatting
...
Change-Id: I88502e8e808776f46743e653b248a8808d6524fa
2018-07-18 21:16:37 +02:00
Axel Uhl
a644b5c4cd
coding and formatting conventions
...
Change-Id: Ic0115215d4d235eab4bc2023186395d7434b128f
2018-07-18 20:42:28 +02:00
Axel Uhl
2d7572cb1c
Merge remote-tracking branch 'server/bug4661' into bug4661
...
Change-Id: I7fbe862ff06838275bb2003f1a0f087923f0e3f1
2018-07-18 17:34:15 +02:00
Axel Uhl
cce4f86e25
Merge remote-tracking branch 'server/master' into bug4661
...
Change-Id: I16f808bd941165ec1aa130d81d071c8db684adc9
2018-07-18 17:29:11 +02:00
Steffen Schaefer
c229c6ef85
Added handling of sharding context to GetMiniOverallLeaderbordAction
2018-07-18 15:34:38 +02:00
Axel Uhl
59a3431d5d
fixed bug regarding erasing last maneuvers received from server
...
Change-Id: I3288685cc0e440a9d9aff16ab15ae1161c246e1b
2018-07-18 15:24:42 +02:00
Axel Uhl
3bcbbd57cc
simplified ManeuverMarkersAndLossIndicators
...
Change-Id: Ic43baa9fc6f2e9de7b7d20317be95adb9beb9744
2018-07-18 15:01:09 +02:00
Axel Uhl
4637500025
removed method visualizeManeuverLoss
...
Change-Id: I964c5f777cf7faac58fbbf4e9e8bd37af2d67cfb
2018-07-18 14:40:35 +02:00
Axel Uhl
48f74336ab
moved functionality around maneuver markers and loss indicators into a class
...
Change-Id: Ibbfdfcadac294282cf420b7c775ddf1cf0017d33
2018-07-18 14:38:03 +02:00
Steffen Jacobs
6a6f0fcbfa
Bug 4339: fixed an issue where the some selenium tests failed when
...
executing under ubuntu
2018-07-18 14:19:40 +02:00
Axel Uhl
10eb0d065c
introduced method createManeuverKey to factor the commonalities in four places
...
Change-Id: I1359a49e1be15646f887b4bbec596ada4102c000
2018-07-18 13:57:38 +02:00
Steffen Schaefer
5efe0ee7d7
Bug 4661: Added JavaDocs
2018-07-18 12:52:29 +02:00
Kai Börnert
0b61a4c5dd
bug4661 added javadocs
2018-07-18 12:49:54 +02:00
Kai Börnert
9a3eb7def0
bug4661 use central point of code to determine if a race counts as won
2018-07-18 12:37:12 +02:00
Steffen Jacobs
1d7b928555
Bug 4339: fixed an issue where the some selenium tests failed when
...
executing under ubuntu
2018-07-18 12:04:29 +02:00
Axel Uhl
d6c268c696
Merge remote-tracking branch 'server/bug4572' into bug4572
...
Change-Id: I85b84ca24e52522ff282e35984b7ab6b3126c671
2018-07-18 11:28:38 +02:00
Kai Börnert
b951232889
bug4661 removed discarding rule, adjusted tests, removed now dead code
...
in score calculation
2018-07-18 11:23:21 +02:00
Kai Börnert
26bfc4b8c3
Merge branch 'master' into bug4661
2018-07-18 11:00:25 +02:00
Kai Börnert
6583aaa3c0
Merge branch 'bug4661' of ssh://trac@sapsailing.com/home/trac/git into bug4661
2018-07-18 10:56:43 +02:00
Kai Börnert
4fb7b460a0
bug4661 test simplification due to removed decimals/ manual tie braking.
...
Added tests that check that automatic tie braking is not changed for
lowpoint and changed for new scheme
2018-07-18 10:56:34 +02:00