Commit Graph
4719 Commits
Author SHA1 Message Date
Daniel Lisunkin 896b22fcca Status: CodeReview with Axel 2019-07-05 15:19:09 +02:00
Daniel Lisunkin 4c24994120 Changed Implementation of getLagrangeAllowance...(…) in ORCPerformanceCurveImpl to match the method provided in ORC pascal code. 2019-07-05 10:47:43 +02:00
Daniel Lisunkin 946c267916 Added comments on ORCCertificate interface. 2019-07-04 09:10:41 +02:00
Daniel Lisunkin 5a9e8cca48 Unified units of arguments and returns in relation to course allowances. 2019-07-03 18:27:09 +02:00
Daniel Lisunkin 8863aad3f8 Merge branch 'master' into bug2842 2019-07-03 15:51:20 +02:00
Daniel Lisunkin 1c437fec33 Fixed calculation mistake in getImpliedWind() method. 2019-07-03 15:44:20 +02:00
Daniel Lisunkin 28a6ecfb7b Fixed runtime errors in testORCPerformanceCurve. Calculation following. 2019-07-03 15:07:25 +02:00
Daniel Lisunkin 0dcaf9d2be Added multiple comments in ORCCertificate interface. 2019-07-02 16:00:31 +02:00
Daniel Lisunkin 91abf3e398 Removed unused and redundant class ORCCertificateImporterJSONComplex. 2019-07-02 14:18:08 +02:00
Axel Uhl 62966bcce0 fixing String-based synchronization monitor issue, using Random string guaranteed to be unique per TrackedRaceImpl instance;
See also 4e3ad78640 where this problem had
been solved for another monitor object, also on TrackedRaceImpl

Change-Id: Ic6d9b1f7ed715f82198b7c3fa7b5398cbed4739d
2019-06-26 10:41:14 +02:00
Axel Uhl 139fe06581 return null instead of throwing an exception when mark passing of boat farthest ahead cannot be found
Change-Id: I02ac115711205c50141a10088503b3a45b84d4b1
2019-06-25 19:46:22 +02:00
Daniel Lisunkin 12b93c00fa Merge branch 'master' into bug2842 2019-06-24 18:39:18 +02:00
Daniel Lisunkin 079162efaa Added comments for the ORCPerformanceCurveCourse interface. 2019-06-24 18:38:36 +02:00
Axel Uhl e43c6090e5 bug5076: avoid NPE during TrackedRaceImpl.getAdditionalGateStartDistance if competitor or start line position is unknown
Change-Id: Ie40c8b141c0daeb1950eceaecd0dbf4002e123c6
2019-06-24 17:10:14 +02:00
Daniel Lisunkin 4a7d317df2 Found new hidden bug in a special corner case of the creation of the leg allowances inside a performance curve instance. 2019-06-19 17:55:24 +02:00
Daniel Lisunkin 2daf0f79bb Added and implemented getCDL() method to ORCCertificate interface and implementing classes. Changed affected places in code. 2019-06-18 14:44:17 +02:00
Daniel Lisunkin 919e0b7af4 Merge branch 'master' into bug2842 2019-06-18 13:53:13 +02:00
Daniel Lisunkin c5d8ed5b66 Added further Implied Wind tests. Currently failing, so bugfix needed. 2019-06-18 13:52:42 +02:00
Axel Uhl dbfe462fd0 bug5073: fix for failing test case;
a wrapper mark passing in place that has the correct time is now left untouched

Change-Id: I74643898b48a9ca8b374aab020b5efc3e40679b7
2019-06-07 13:33:47 +02:00
Daniel Lisunkin e76ef8412a Added comments for ORCPerformanceCurve interface 2019-06-06 18:39:40 +02:00
Daniel Lisunkin d04dcee782 Added comments for ORCPerformanceCurveImpl 2019-06-06 18:31:00 +02:00
Daniel Lisunkin 96bcfdba62 Fixed a smaller issue inside the lagrange interpolation. Differences in higher corner cases remain. 2019-06-06 17:54:38 +02:00
Daniel Lisunkin d4d041b5d9 Deleted old LaGrange interpolation, additionally cleaned up the code at some places and added hints from Axel as todos. 2019-06-06 15:57:20 +02:00
Daniel Lisunkin 85f8fd9561 Fixed issues with decision of input values for laGrange Interpolation in ORCPerformanceCurve. 2019-06-04 14:31:15 +02:00
Daniel Lisunkin cd92ffea89 Removed wrong implementation and references for getImpliedWind with the inverted axes. 2019-06-03 15:29:25 +02:00
Daniel Lisunkin 95e7e96366 Merge branch 'master' into bug2842 2019-06-03 12:50:55 +02:00
Axel Uhl 43103d2a75 bug5066: don't try to compute an MPC's edge distance sailed if time points of candidates are unknown 2019-06-03 00:47:46 +02:00
Axel Uhl 6324c97499 bug5063: use convertToCompetitorWithOptionalBoatDTO instead of convertToCompetitorDTO;
during the construction of convertToCompetitorWithOptionalBoatDTO the
CompetitorAndBoatStore.convertToCompetitorDTO method was used. This
always produces CompetitorDTO objects, even for CompetitorWithBoat
server objects. This leads to ClassCastExceptions in the client.

Change-Id: I40a31f03a991f3de96f275421d13cbf0b828b0e6
2019-06-01 13:13:19 +02:00
Daniel Lisunkin 92db0d24f1 Added further TODOs in regard to comments and code style. 2019-05-29 18:04:37 +02:00
Daniel Lisunkin a61f544938 Added refactorings, comments and cleaned up ORCPerformanceCurveImpl 2019-05-29 15:38:48 +02:00
Daniel Lisunkin 8c747e0959 Merge branch 'master' into bug2842 2019-05-29 13:14:53 +02:00
Daniel Lisunkin 8471be626d Added getAllowancePerCourse(impliedWind) to the ORCPerformanceCurve interface and implemented getCalculatedTime(referenceBoat) in ORCPerformanceCurveImpl. 2019-05-29 12:03:03 +02:00
Axel Uhl 89e8bef9c8 Revert "removed PluginNature from our OSGi bundles; they are not Eclipse plugins";
according to https://bugs.eclipse.org/bugs/show_bug.cgi?id=544977#c21 the
scenario of using the ManifestBuilder without setting the PluginNature is
not a supported scenario. Besides, it doesn't help to get rid of the new
Eclipse warning regarding non-exported packages.

This reverts commit 063484e29f.
2019-05-28 21:54:20 +02:00
Daniel Lisunkin 7cc194f9eb Fixed another issue with getImpliedWindNewton() method - found better way to set boundaries for the Newton approach 2019-05-28 17:11:25 +02:00
Daniel Lisunkin 2032d35860 Fixed an issue in the getImpliedWindNewton() method. 2019-05-28 16:29:30 +02:00
Daniel Lisunkin b1beb08497 Merge branch 'master' into bug2842 2019-05-28 13:42:16 +02:00
Daniel Lisunkin 8fa3992941 Started implementing the getImpliedWindNewton() method of ORCPerformanceCurveImpl. Goal is to analyse the difference of the accuracy with this method in comparison to the ORC way. 2019-05-28 13:40:18 +02:00
Axel Uhl 063484e29f removed PluginNature from our OSGi bundles; they are not Eclipse plugins 2019-05-27 22:53:30 +02:00
Daniel Lisunkin 9e2211048a Implemented cubic spline interpolation for ORCPerformanceCurve. Added methods getImpliedWind(Duration), getAllowance(Speed) and test cases for the invertation of the cubic spline function. 2019-05-27 15:21:32 +02:00
Axel Uhl 6bdb973ff9 bug5053: obtain boat from CompetitorWithBoat or race log if possible
Change-Id: Ib2992ac2aaa417556970c0c9378039111963d7d2
2019-05-25 12:12:28 +02:00
Daniel Lisunkin e5ffbd266f Started implementing cubic spline interpolation for ORC Performance Curve. 2019-05-24 19:32:17 +02:00
Daniel Lisunkin 8ccbba79df Clean up & refactoring done. 2019-05-24 19:15:50 +02:00
Daniel Lisunkin 2b5989d42a Code clean up 2019-05-23 12:18:29 +02:00
Daniel Lisunkin 9fe5824d79 Merge branch 'master' into bug2842 2019-05-23 11:05:56 +02:00
Daniel Lisunkin 48ae27d195 Added multiple tests for the lagrange interpolation inside performance curve. Additionally modified the lagrange interpolation to follow the structure of the ORC pascal source code. 2019-05-23 11:03:50 +02:00
Axel Uhl 013b4af418 implemented LowPointTieBreakBasedOnLastSeriesOnly such that all formerly failing test cases pass now
Change-Id: I5625692eb0cd0d10b10536fa26cd707a390615d1
2019-05-21 17:34:56 +02:00
Daniel Lisunkin 678109c53f Updated initialization of static perCentOfAllowancesForLongDistancePC map. Cleaned up older methods of this class. 2019-05-21 14:55:17 +02:00
Daniel Lisunkin 56d66b5e95 Fixed a minor fault in subcourse() calculation. Added more complex test cases for ORCPerformanceCurveCourse.subcourse() method. 2019-05-21 13:22:47 +02:00
Daniel Lisunkin 7f9888f8a9 Added multiple tests for subcourse() method of ORCPerformanceCurveCourse and implementation. 2019-05-21 13:14:23 +02:00
Axel Uhl 0e9bf6cf1a bug4717: added failing test cases
Change-Id: I4712236aafaaa83a764201e63a4ae1bbd4988ad6
2019-05-21 12:23:07 +02:00