mirror of
https://github.com/eclipse-sailing-analytics/sailing-analytics.git
synced 2026-10-31 16:20:45 +00:00
Axel Uhl
f18b36556e
Replace the decommissioned data.orc.org/public/WPub.dll XML endpoints with the new key-based JSON API at https://sas.orc.org/api/{key}/<endpoint> (docs: https://sas.orc.org/api-docs.php), restoring the pre-bug6318 semantics that the bug6318 stopgap had regressed: - country-less and year-based search via the 'activecerts' endpoint (all criteria optional and AND-combined server-side; no criteria -> every active certificate), removing the forced-country / current-year-only branches; - real per-country/family overview counts and VPP year via the 'RMS' endpoint, replacing the stubbed certCount=0 / vppYear=null; - full-certificate download via 'DownBoatRMS_byrefno' (top-level rms[], consumed by the unchanged ORCCertificatesJsonImporter); - TestORCPerformanceCurve bulk online fetch via 'DownRMS'. The API key is read from the ORC_API_KEY environment variable and placed into the request path; it is never logged. When the key is absent the adapter throws, so the live tests FAIL loudly rather than skip. The two pure-offline date-parse tests run independently of the key. release.yml passes ORC_API_KEY to the test runtime, gated so compile-only (skip_tests) runs never see the real secret. Assisted-By: Claude Opus 4.8 (claude-opus-4-8)