mirror of
https://github.com/eclipse-sailing-analytics/sailing-analytics.git
synced 2026-10-31 16:20:45 +00:00
The key-based sas.orc.org API routes all active-certificate search through the activecerts endpoint, which returns active certificates only. The includeInvalid flag on ORCPublicCertificateDatabase.search(...) could therefore never change the result and was dead. Remove it from the interface and impl, the default getCertificateHandle, the two fuzzy-search call sites, SailingServiceImpl, and all ORC test call sites. The sole route to an inactive certificate in this adapter is to download it by reference number via DownBoatRMS_byrefno (getCertificate / getCertificateHandle); the search Javadoc now states this explicitly. Also export ORC_API_KEY from java/target/env-default-rules.sh so the Java VM can read it via System.getenv(...). configuration/secrets assigns it as a plain (non-exported) shell variable that the java child process would not otherwise inherit; it is passed as an environment variable rather than a -D system property so it is not exposed on the process command line. Assisted-By: Claude Opus 4.8 (claude-opus-5-5)