mirror of
https://github.com/espressif/esp-matter.git
synced 2026-04-27 19:13:13 +00:00
components/esp-matter: enable GroupNames feature by default
Removed the configurability of the NameSupport attribute of the Groups cluster and enabled it by default. The NameSupport and feature-map attributes of the Groups cluster must be kept in sync, the connectedhomeip SDK enables the GroupName feature by default and set the NameSupport attribute to appropriate value.
This commit is contained in:
@@ -1,3 +1,10 @@
|
||||
# 28-Aug-2024
|
||||
|
||||
- Removed the configurability of the NameSupport attribute of the Groups cluster and enabled
|
||||
it by default. The NameSupport and feature-map attributes of the Groups cluster must be kept
|
||||
in sync, the connectedhomeip SDK enables the GroupName feature by default and set the
|
||||
NameSupport attribute to appropriate value.
|
||||
|
||||
# 08-July-2024
|
||||
- Changed diagnostic cluster namespaces as per the matter specifications
|
||||
- diagnostics_network_wifi -> wifi_network_diagnotics
|
||||
|
||||
@@ -1061,12 +1061,12 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags)
|
||||
add_function_list(cluster, function_list, function_flags);
|
||||
|
||||
/* Attributes managed internally */
|
||||
global::attribute::create_feature_map(cluster, 0);
|
||||
global::attribute::create_feature_map(cluster, static_cast<uint32_t>(Groups::NameSupportBitmap::kGroupNames));
|
||||
|
||||
/* Attributes not managed internally */
|
||||
global::attribute::create_cluster_revision(cluster, cluster_revision);
|
||||
if (config) {
|
||||
attribute::create_group_name_support(cluster, config->group_name_support);
|
||||
attribute::create_group_name_support(cluster, chip::to_underlying(Groups::NameSupportBitmap::kGroupNames));
|
||||
} else {
|
||||
ESP_LOGE(TAG, "Config is NULL. Cannot add some attributes.");
|
||||
}
|
||||
|
||||
@@ -231,11 +231,7 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags);
|
||||
} /* identify */
|
||||
|
||||
namespace groups {
|
||||
typedef struct config {
|
||||
uint8_t group_name_support;
|
||||
config() : group_name_support(0) {}
|
||||
} config_t;
|
||||
|
||||
using config_t = common::config_t;
|
||||
cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags);
|
||||
} /* groups */
|
||||
|
||||
|
||||
Reference in New Issue
Block a user