espressif/esp-matter
1
0
Fork 0
mirror of https://github.com/espressif/esp-matter.git synced 2026-04-27 19:13:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

components/esp-matter: enable GroupNames feature by default

Browse Source 
Removed the configurability of the NameSupport attribute of the Groups
cluster and enabled it by default. The NameSupport and feature-map
attributes of the Groups cluster must be kept in sync, the
connectedhomeip SDK enables the GroupName feature by default and set
the NameSupport attribute to appropriate value.
This commit is contained in:
Shubham Patil
2024-08-28 10:00:15 +05:30
committed by shripad621git
parent e2663ba968
commit ad37a4cf31
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
RELEASE_NOTES.md
+7
View File
@@ -1,3 +1,10 @@
# 28-Aug-2024
- Removed the configurability of the NameSupport attribute of the Groups cluster and enabled
it by default. The NameSupport and feature-map attributes of the Groups cluster must be kept
in sync, the connectedhomeip SDK enables the GroupName feature by default and set the
NameSupport attribute to appropriate value.
# 07-May-2024 # 07-May-2024
- `tools/mfg_tool.py` is moved to https://github.com/espressif/esp-matter-tools/tree/main/mfg_tool - `tools/mfg_tool.py` is moved to https://github.com/espressif/esp-matter-tools/tree/main/mfg_tool
components/esp_matter/esp_matter_cluster.cpp
+2 -2
View File
@@ -1230,7 +1230,7 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags)
if (flags & CLUSTER_FLAG_SERVER) { if (flags & CLUSTER_FLAG_SERVER) {
/* Attributes managed internally */ /* Attributes managed internally */
global::attribute::create_feature_map(cluster, 0); global::attribute::create_feature_map(cluster, static_cast<uint32_t>(Groups::NameSupportBitmap::kGroupNames));
#if CHIP_CONFIG_ENABLE_EVENTLIST_ATTRIBUTE #if CHIP_CONFIG_ENABLE_EVENTLIST_ATTRIBUTE
global::attribute::create_event_list(cluster, NULL, 0, 0); global::attribute::create_event_list(cluster, NULL, 0, 0);
#endif #endif
@@ -1238,7 +1238,7 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags)
/* Attributes not managed internally */ /* Attributes not managed internally */
if (config) { if (config) {
global::attribute::create_cluster_revision(cluster, config->cluster_revision); global::attribute::create_cluster_revision(cluster, config->cluster_revision);
attribute::create_group_name_support(cluster, config->group_name_support); attribute::create_group_name_support(cluster, chip::to_underlying(Groups::NameSupportBitmap::kGroupNames));
} else { } else {
ESP_LOGE(TAG, "Config is NULL. Cannot add some attributes."); ESP_LOGE(TAG, "Config is NULL. Cannot add some attributes.");
} }
components/esp_matter/esp_matter_cluster.h
+1 -2
View File
@@ -302,8 +302,7 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags);
namespace groups { namespace groups {
typedef struct config { typedef struct config {
uint16_t cluster_revision; uint16_t cluster_revision;
uint8_t group_name_support; config() : cluster_revision(4) {}
config() : cluster_revision(4), group_name_support(0) {}
} config_t; } config_t;
cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags); cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags);