fixed DataMining bug regarding erroneous multiplication of race results by the number of race columns

This commit is contained in:
Axel Uhl committed 2022-11-29 17:02:57 +01:00
1 parent d2bc7d1881
commit 0900a7bf54
2 files changed
+10 -11

No files matched your search

@@ -9,7 +9,6 @@ import com.sap.sailing.datamining.data.HasRaceResultOfCompetitorContext;
import com.sap.sailing.datamining.data.HasTrackedRaceContext;
import com.sap.sailing.datamining.impl.data.RaceResultOfCompetitorWithContext;
import com.sap.sailing.domain.base.Competitor;
import com.sap.sailing.domain.base.RaceColumn;
import com.sap.sse.datamining.components.Processor;
import com.sap.sse.datamining.impl.components.AbstractRetrievalProcessor;
@@ -27,19 +26,14 @@ public class CompetitorOfRaceInLeaderboardRetrievalProcessor
protected Iterable<HasRaceResultOfCompetitorContext> retrieveData(HasTrackedRaceContext element) {
Collection<HasRaceResultOfCompetitorContext> raceResultsOfCompetitor = new ArrayList<>();
HasLeaderboardContext leaderboardContext = element.getLeaderboardContext();
for (RaceColumn raceColumn : leaderboardContext.getLeaderboard().getRaceColumns()) {
for (Competitor competitor : element.getRace().getCompetitors()) {
if (isAborted()) {
break;
}
for (Competitor competitor : leaderboardContext.getLeaderboard().getCompetitors()) {
if (isAborted()) {
break;
}
HasRaceResultOfCompetitorContext raceResultOfCompetitorContext = new RaceResultOfCompetitorWithContext(
leaderboardContext, raceColumn, competitor,
leaderboardContext.getLeaderboardGroupContext().getPolarDataService(), element);
raceResultsOfCompetitor.add(raceResultOfCompetitorContext);
}
HasRaceResultOfCompetitorContext raceResultOfCompetitorContext = new RaceResultOfCompetitorWithContext(
leaderboardContext, element.getRaceColumn(), competitor,
leaderboardContext.getLeaderboardGroupContext().getPolarDataService(), element);
raceResultsOfCompetitor.add(raceResultOfCompetitorContext);
}
return raceResultsOfCompetitor;
}
@@ -7,6 +7,11 @@
<h5 class="articleSubheadline">November 2022</h5>
<ul class="bulletList">
<li>Added flag and country code for South Sudan.</li>
<li>Fixed bug in data mining module: elements from section "Race Results" (Absolute Rank,
Number of Podium Finishes, Number of Wins, and Relative Score (0 best; 1 worst))
have erroneously been "multiplied" by the race columns in the leaderboard. For example,
when summing up wins in a regatta with four races, the results were a factor of four
too great.</li>
</ul>
<h5 class="articleSubheadline">October 2022</h5>
<ul class="bulletList">