Added an imple package to the datamining.shared bundle

java/com.sap.sailing.datamining.shared/META-INF/MANIFEST.MF

@@ -9,5 +9,6 @@ Bundle-ActivationPolicy: lazy
 Bundle-ClassPath: .
 Export-Package: com.sap.sailing.datamining.shared,
  com.sap.sailing.datamining.shared.dto,
+ com.sap.sailing.datamining.shared.impl,
  com.sap.sailing.datamining.shared.impl.dto
 Import-Package: com.google.gwt.i18n.client

java/com.sap.sailing.datamining.shared/src/com/sap/sailing/datamining/shared/ClassesToScanForDataMiningService.java

@@ -1,7 +0,0 @@
-package com.sap.sailing.datamining.shared;
-
-public interface ClassesToScanForDataMiningService {
-    
-    public Iterable<Class<?>> getClassesToScan();
-
-}

java/com.sap.sailing.datamining.shared/src/com/sap/sailing/datamining/shared/DataMiningSerializationDummy.java

@@ -2,6 +2,8 @@ package com.sap.sailing.datamining.shared;
 
 import java.io.Serializable;
 
+import com.sap.sailing.datamining.shared.impl.GenericGroupKey;
+
 @SuppressWarnings("unused")
 public final class DataMiningSerializationDummy implements Serializable {
     private static final long serialVersionUID = 1L;

java/com.sap.sailing.datamining.shared/src/com/sap/sailing/datamining/shared/dto/FunctionDTO.java

@@ -5,14 +5,14 @@ import java.util.List;
 
 public interface FunctionDTO extends Serializable {
 
-    public abstract boolean isDimension();
+    public boolean isDimension();
 
-    public abstract String getDisplayName();
+    public String getDisplayName();
 
-    public abstract List<String> getParameters();
+    public List<String> getParameters();
 
-    public abstract String getReturnTypeName();
+    public String getReturnTypeName();
 
-    public abstract String getSourceTypeName();
+    public String getSourceTypeName();
 
 }

java/com.sap.sailing.datamining.shared/src/com/sap/sailing/datamining/shared/impl/AbstractGroupKey.java

@@ -1,4 +1,6 @@
-package com.sap.sailing.datamining.shared;
+package com.sap.sailing.datamining.shared.impl;
+
+import com.sap.sailing.datamining.shared.GroupKey;
 
 
 public abstract class AbstractGroupKey implements GroupKey {

java/com.sap.sailing.datamining.shared/src/com/sap/sailing/datamining/shared/impl/CompoundGroupKey.java

@@ -1,4 +1,6 @@
-package com.sap.sailing.datamining.shared;
+package com.sap.sailing.datamining.shared.impl;
+
+import com.sap.sailing.datamining.shared.GroupKey;
 
 
 public class CompoundGroupKey extends AbstractGroupKey {

java/com.sap.sailing.datamining.shared/src/com/sap/sailing/datamining/shared/impl/GenericGroupKey.java

@@ -1,4 +1,6 @@
-package com.sap.sailing.datamining.shared;
+package com.sap.sailing.datamining.shared.impl;
+
+import com.sap.sailing.datamining.shared.GroupKey;
 
 
 public class GenericGroupKey<T> extends AbstractGroupKey {

java/com.sap.sailing.datamining.shared/src/com/sap/sailing/datamining/shared/impl/QueryResultImpl.java

@@ -1,8 +1,12 @@
-package com.sap.sailing.datamining.shared;
+package com.sap.sailing.datamining.shared.impl;
 
 import java.util.HashMap;
 import java.util.Map;
 
+import com.sap.sailing.datamining.shared.GroupKey;
+import com.sap.sailing.datamining.shared.QueryResult;
+import com.sap.sailing.datamining.shared.Unit;
+
 public class QueryResultImpl<AggregatedType> implements QueryResult<AggregatedType> {
     private static final long serialVersionUID = -8347731622150585715L;
     

java/com.sap.sailing.datamining.shared/src/com/sap/sailing/datamining/shared/impl/SimpleQueryDefinition.java

@@ -1,4 +1,4 @@
-package com.sap.sailing.datamining.shared;
+package com.sap.sailing.datamining.shared.impl;
 
 import java.util.ArrayList;
 import java.util.Collection;
@@ -10,6 +10,9 @@ import com.google.gwt.i18n.client.LocaleInfo;
 import com.sap.sailing.datamining.shared.Components.AggregatorType;
 import com.sap.sailing.datamining.shared.Components.GrouperType;
 import com.sap.sailing.datamining.shared.Components.StatisticType;
+import com.sap.sailing.datamining.shared.DataTypes;
+import com.sap.sailing.datamining.shared.DimensionIdentifier;
+import com.sap.sailing.datamining.shared.QueryDefinition;
 
 public class SimpleQueryDefinition implements QueryDefinition {
     private static final long serialVersionUID = 3476324726640558091L;

java/com.sap.sailing.datamining.test/src/com/sap/sailing/datamining/test/TestAggregators.java

@@ -13,8 +13,8 @@ import com.sap.sailing.datamining.AggregationWorker;
 import com.sap.sailing.datamining.impl.aggregators.SimpleIntegerArithmeticAverageAggregationWorker;
 import com.sap.sailing.datamining.impl.aggregators.SumAggregationWorker;
 import com.sap.sailing.datamining.impl.aggregators.helpers.SimpleIntegerSumAggregator;
-import com.sap.sailing.datamining.shared.GenericGroupKey;
 import com.sap.sailing.datamining.shared.GroupKey;
+import com.sap.sailing.datamining.shared.impl.GenericGroupKey;
 import com.sap.sailing.datamining.test.util.OpenDataReceiver;
 
 public class TestAggregators {

java/com.sap.sailing.datamining.test/src/com/sap/sailing/datamining/test/TestExtractors.java

@@ -10,8 +10,8 @@ import java.util.Map;
 import org.junit.Test;
 
 import com.sap.sailing.datamining.ExtractionWorker;
-import com.sap.sailing.datamining.shared.GenericGroupKey;
 import com.sap.sailing.datamining.shared.GroupKey;
+import com.sap.sailing.datamining.shared.impl.GenericGroupKey;
 import com.sap.sailing.datamining.test.util.OpenDataReceiver;
 import com.sap.sailing.datamining.test.util.StringLengthExtractor;
 

java/com.sap.sailing.datamining.test/src/com/sap/sailing/datamining/test/groupers/TestDimensionGroupers.java

@@ -15,9 +15,9 @@ import org.junit.Test;
 import com.sap.sailing.datamining.Dimension;
 import com.sap.sailing.datamining.GroupingWorker;
 import com.sap.sailing.datamining.impl.AbstractDimension;
-import com.sap.sailing.datamining.shared.CompoundGroupKey;
-import com.sap.sailing.datamining.shared.GenericGroupKey;
 import com.sap.sailing.datamining.shared.GroupKey;
+import com.sap.sailing.datamining.shared.impl.CompoundGroupKey;
+import com.sap.sailing.datamining.shared.impl.GenericGroupKey;
 import com.sap.sailing.datamining.test.util.OpenDataReceiver;
 import com.sap.sailing.datamining.test.util.OpenGrouper;
 

java/com.sap.sailing.datamining.test/src/com/sap/sailing/datamining/test/util/OpenGrouper.java

@@ -4,8 +4,8 @@ import java.util.Collection;
 
 import com.sap.sailing.datamining.Dimension;
 import com.sap.sailing.datamining.impl.MultiDimensionalGroupingWorker;
-import com.sap.sailing.datamining.shared.GenericGroupKey;
 import com.sap.sailing.datamining.shared.GroupKey;
+import com.sap.sailing.datamining.shared.impl.GenericGroupKey;
 
 public class OpenGrouper<DataType> extends MultiDimensionalGroupingWorker<DataType, String> {
 

java/com.sap.sailing.datamining/src/com/sap/sailing/datamining/impl/MultiDimensionalGroupingWorker.java

@@ -5,9 +5,9 @@ import java.util.Iterator;
 import java.util.LinkedHashSet;
 
 import com.sap.sailing.datamining.Dimension;
-import com.sap.sailing.datamining.shared.CompoundGroupKey;
-import com.sap.sailing.datamining.shared.GenericGroupKey;
 import com.sap.sailing.datamining.shared.GroupKey;
+import com.sap.sailing.datamining.shared.impl.CompoundGroupKey;
+import com.sap.sailing.datamining.shared.impl.GenericGroupKey;
 
 public class MultiDimensionalGroupingWorker<DataType, ValueType> extends AbstractGroupingWorker<DataType> {
     

java/com.sap.sailing.datamining/src/com/sap/sailing/datamining/impl/QueryImpl.java

@@ -16,7 +16,7 @@ import com.sap.sailing.datamining.Query;
 import com.sap.sailing.datamining.shared.GroupKey;
 import com.sap.sailing.datamining.shared.Message;
 import com.sap.sailing.datamining.shared.QueryResult;
-import com.sap.sailing.datamining.shared.QueryResultImpl;
+import com.sap.sailing.datamining.shared.impl.QueryResultImpl;
 
 public class QueryImpl<DataType, ExtractedType, AggregatedType> implements Query<DataType, AggregatedType> {
 

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/datamining/DataMiningEntryPoint.java

@@ -17,9 +17,9 @@ import com.google.gwt.user.client.ui.Widget;
 import com.sap.sailing.datamining.shared.Components.AggregatorType;
 import com.sap.sailing.datamining.shared.Components.GrouperType;
 import com.sap.sailing.datamining.shared.Components.StatisticType;
+import com.sap.sailing.datamining.shared.impl.SimpleQueryDefinition;
 import com.sap.sailing.datamining.shared.DataTypes;
 import com.sap.sailing.datamining.shared.DimensionIdentifier;
-import com.sap.sailing.datamining.shared.SimpleQueryDefinition;
 import com.sap.sailing.gwt.ui.client.AbstractEntryPoint;
 import com.sap.sailing.gwt.ui.client.GlobalNavigationPanel;
 import com.sap.sailing.gwt.ui.client.LogoAndTitlePanel;

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/datamining/selection/QueryDefinitionProviderWithControls.java

@@ -13,7 +13,7 @@ import com.google.gwt.user.client.ui.RequiresResize;
 import com.google.gwt.user.client.ui.Widget;
 import com.sap.sailing.datamining.shared.DimensionIdentifier;
 import com.sap.sailing.datamining.shared.QueryDefinition;
-import com.sap.sailing.datamining.shared.SimpleQueryDefinition;
+import com.sap.sailing.datamining.shared.impl.SimpleQueryDefinition;
 import com.sap.sailing.gwt.ui.client.ErrorReporter;
 import com.sap.sailing.gwt.ui.client.SailingServiceAsync;
 import com.sap.sailing.gwt.ui.client.StringMessages;