eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-11-05 18:42:55 +00:00
Code Activity

Bug 4702: MultipleMultiLeaderboardPanelLifecycle does not have a

Browse Source 
LeaderboardDTO as constructor Parameter anymore. The parameter was null
in all cases
This commit is contained in:
Steffen Schaefer committed 2018-08-09 09:13:17 +02:00
1 parent c73072f3eb
commit 1dee62ba21
4 files changed
+13 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/desktop/places/fakeseries/leaderboardstab/EventSeriesLeaderboardsTabView.java
+1 -1
View File
@@ -160,7 +160,7 @@ public class EventSeriesLeaderboardsTabView extends Composite implements SeriesT
private ComponentContext<MultiRaceLeaderboardSettings> createLeaderboardComponentContext(String leaderboardName, UserService userService,
String placeToken, Iterable<DetailType> availableDetailTypes) {
final MultipleMultiLeaderboardPanelLifecycle lifecycle = new MultipleMultiLeaderboardPanelLifecycle(null, StringMessages.INSTANCE, availableDetailTypes);
final MultipleMultiLeaderboardPanelLifecycle lifecycle = new MultipleMultiLeaderboardPanelLifecycle(StringMessages.INSTANCE, availableDetailTypes);
final StoredSettingsLocation storageDefinition = StoredSettingsLocationFactory.createStoredSettingsLocatorForSeriesRegattaLeaderboards(leaderboardName);
final ComponentContext<MultiRaceLeaderboardSettings> componentContext = new PlaceBasedComponentContextWithSettingsStorage<>(
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/settings/client/leaderboard/MetaLeaderboardPerspectiveLifecycle.java
+1 -1
View File
@@ -12,7 +12,7 @@ public class MetaLeaderboardPerspectiveLifecycle extends AbstractLeaderboardPers
public MetaLeaderboardPerspectiveLifecycle(StringMessages stringMessages, AbstractLeaderboardDTO leaderboard, Iterable<DetailType> availableDetailTypes) {
super(stringMessages, leaderboard, true, availableDetailTypes);
multiLeaderboardPanelLifecycle = new MultipleMultiLeaderboardPanelLifecycle(null, stringMessages, availableDetailTypes);
multiLeaderboardPanelLifecycle = new MultipleMultiLeaderboardPanelLifecycle(stringMessages, availableDetailTypes);
addLifeCycle(multiLeaderboardPanelLifecycle);
}
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/settings/client/leaderboard/MultiRaceLeaderboardPanelLifecycle.java
+7 -1
View File
@@ -13,8 +13,14 @@ public class MultiRaceLeaderboardPanelLifecycle extends LeaderboardPanelLifecycl
public MultiRaceLeaderboardPanelLifecycle(AbstractLeaderboardDTO leaderboard, StringMessages stringMessages,
Iterable<DetailType> availableDetailTypes) {
this(leaderboard != null ? leaderboard.getNamesOfRaceColumns() : new ArrayList<String>(), stringMessages,
availableDetailTypes);
}
protected MultiRaceLeaderboardPanelLifecycle(List<String> namesOfRaceColumns, StringMessages stringMessages,
Iterable<DetailType> availableDetailTypes) {
super(stringMessages, availableDetailTypes);
this.namesOfRaceColumns = leaderboard != null ? leaderboard.getNamesOfRaceColumns() : new ArrayList<String>();
this.namesOfRaceColumns = namesOfRaceColumns;
}
@Override
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/settings/client/leaderboard/MultipleMultiLeaderboardPanelLifecycle.java
+4 -3
View File
@@ -1,7 +1,8 @@
package com.sap.sailing.gwt.settings.client.leaderboard;
import java.util.Collections;
import com.sap.sailing.domain.common.DetailType;
import com.sap.sailing.domain.common.dto.AbstractLeaderboardDTO;
import com.sap.sailing.gwt.ui.client.StringMessages;
/**
@@ -11,8 +12,8 @@ import com.sap.sailing.gwt.ui.client.StringMessages;
public class MultipleMultiLeaderboardPanelLifecycle extends MultiRaceLeaderboardPanelLifecycle {
public static final String MID = "mlb";
public MultipleMultiLeaderboardPanelLifecycle(AbstractLeaderboardDTO leaderboard, StringMessages stringMessages, Iterable<DetailType> availableDetailTypes) {
super(leaderboard, stringMessages, availableDetailTypes);
public MultipleMultiLeaderboardPanelLifecycle(StringMessages stringMessages, Iterable<DetailType> availableDetailTypes) {
super(Collections.emptyList(), stringMessages, availableDetailTypes);
}
@Override