bug5419: Javadoc improvements, removing GWT.log statements

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/AbstractRegattaLogFixesAddMappingsDialog.java

@@ -74,7 +74,7 @@ public class AbstractRegattaLogFixesAddMappingsDialog extends DataEntryDialog<Co
                 sailingServiceWrite, stringMessages, errorReporter);
         boatTable = new BoatTableWrapper<RefreshableSingleSelectionModel<BoatDTO>>(sailingServiceWrite, userService,
                 /* boatsRefresher not needed; registered boats taken from regatta log */ null,
-                /* competitorsRefresher not neede */ null, stringMessages, errorReporter, /* multiSelection */ false,
+                /* competitorsRefresher not needed */ null, stringMessages, errorReporter, /* multiSelection */ false,
                 /* enable Pager */ true, /* allowActions */ false);
 
         registerSelectionChangeHandler(competitorTable.getSelectionModel(), this::mappedToSelectionChanged);

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/AbstractRegattaLogSensorDataAddMappingsDialog.java

@@ -60,7 +60,7 @@ public abstract class AbstractRegattaLogSensorDataAddMappingsDialog extends Data
                 event -> deviceSelectionChanged(deviceIdTable.getSelectionModel().getSelectedObject()));
         boatTable = new BoatTableWrapper<RefreshableSingleSelectionModel<BoatDTO>>(sailingServiceWrite, userService,
                 /* boatsRefresher not needed; registrations are fetched for the leaderboard specifically */ null,
-                /* competitorsRefresher not neede */ null,
+                /* competitorsRefresher not needed */ null,
                 stringMessages, errorReporter, /* multiSelection */ false, /* enable Pager */ true, /* allowActions */ false);
         competitorTable = new CompetitorTableWrapper<>(sailingServiceWrite, userService,
                 /* competitorsRefresher not needed; registrations are fetched for the leaderboard specifically */ null,

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/CompetitorTableWrapper.java

@@ -10,7 +10,6 @@ import java.util.List;
 
 import com.google.gwt.cell.client.SafeHtmlCell;
 import com.google.gwt.core.client.Callback;
-import com.google.gwt.core.client.GWT;
 import com.google.gwt.resources.client.ImageResource;
 import com.google.gwt.safehtml.shared.SafeHtml;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
@@ -415,16 +414,13 @@ public class CompetitorTableWrapper<S extends RefreshableSelectionModel<Competit
             }
         };
         if (leaderboardName != null) {
-            GWT.log("leaderboardName != null");
             sailingServiceWrite.getCompetitorsOfLeaderboard(leaderboardName, myCallback);
         } else {
             if (competitorsRefresher != null) {
-                GWT.log("competitorsRefresher != null");
                 // Don't fetch from server but ask our unified data model to deliver the competitors without forcing server
                 // round-trip unless the competitors haven't been loaded at all so far
                 competitorsRefresher.callFillAndReloadInitially(competitors->myCallback.onSuccess(competitors));
             } else {
-                GWT.log("competitorsRefresher == null");
                 sailingServiceWrite.getCompetitors(filterCompetitorsWithBoat, filterCompetitorsWithoutBoat, myCallback);
             }
         }
@@ -498,7 +494,6 @@ public class CompetitorTableWrapper<S extends RefreshableSelectionModel<Competit
                 newCompetitor, createWithBoatByDefault, new DialogCallback<CompetitorWithBoatDTO>() {
                     @Override
                     public void ok(final CompetitorWithBoatDTO competitor) {
-                        GWT.log("OK 001");
                         if (competitor.hasBoat()) {
                             sailingServiceWrite.addOrUpdateCompetitorWithBoat(competitor, createAddCompetitorCallback());
                         } else {

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/Refresher.java

@@ -85,6 +85,8 @@ public interface Refresher<T> {
      * Like {@link #add(Object)}, but an {@link Object#equals(Object) equal} original DTO will be replaced by {@code newDto} if
      * found in the list of DTOs known to this refresher. This will only take place if the DTO list already exists,
      * indicating that it has been requested before.
+     * 
+     * @param newDto if {@code null}, the {@code oldDto} will be removed if found, and nothing will be added
      */
     void addIfNotContainedElseReplace(T oldDto, T newDto);