Moved the button to clear the filter selection into HierarchicalDimensionListFilterSelectionProvider and fixed a typo in the properties

This commit is contained in:
Lennart Hensler committed 2018-07-27 20:58:30 +02:00
1 parent 514fccbaab
commit 516cd2b7fc
13 files changed
+47 -29

No files matched your search

@@ -261,6 +261,7 @@ input.magnifier {
.filterDimensionsTitleLabel {
padding-top: 5px;
display: inline-block;
}
.filterFilterDimensionsPanel {
@@ -323,9 +324,15 @@ input.magnifier {
.dataMiningMarginLeft {
margin-left: 5px;
}
.dataMiningMarginTop {
margin-top: 5px;
}
.dataMiningMarginRight {
margin-right: 5px;
}
.dataMiningMarginBottom {
margin-bottom: 5px;
}
.resultsPresenterTabHeader * {
display: inline-block;
@@ -335,4 +342,8 @@ input.magnifier {
.emphasizedLabel {
font-weight: 600;
}
.floatRight {
float: right;
}
@@ -24,7 +24,7 @@ public interface StringMessages extends com.sap.sse.gwt.client.StringMessages {
String useClassGetName();
String useStringLiteralsTooltip();
String queryDefinitionViewer();
String runAsSubstantive();
String run();
String queryNotValidBecause();
String queryRunner();
String runAQuery();
@@ -65,5 +65,6 @@ public interface StringMessages extends com.sap.sse.gwt.client.StringMessages {
String filter();
String filterShownDimensions();
String selectDimensionsToFilterBy();
String clear();
}
@@ -48,4 +48,5 @@ search=Search
csvCopiedToClipboard=CSV content has been copied to clipboard.
filter=Filter
filterShownDimensions=Filter shown dimensions
selectDimensionsToFilterBy=Select dimensions to filter by
selectDimensionsToFilterBy=Select dimensions to filter by
clear=Clear
@@ -8,7 +8,7 @@ useClassGetNameTooltip=Robuster gegnüber Änderungen im Code, aber der Code Sni
useClassGetName=Verwende Class.getName() für Typnamen
useStringLiteralsTooltip=Der Code Snippet kann überall verwendet werden, wird aber nicht mehr funktionieren, wenn sich der Code ändert.
queryDefinitionViewer=Query Definition Anzeiger
runAsSubstantive=Durchlauf
run=Ausführen
queryNotValidBecause=Keine Datenabfrage möglich, da
queryRunner=Abfrageverarbeiter
runAQuery=Führe eine Anfrage aus
@@ -48,4 +48,5 @@ search=Suche
csvCopiedToClipboard=Der Inhalt wurde als CSV in die Zwischenablage kopiert.
filter=Filter
filterShownDimensions=Angezeigte Dimensionen filtern
selectDimensionsToFilterBy=Dimensionen der Filterung auswählen
selectDimensionsToFilterBy=Dimensionen der Filterung auswählen
clear=Löschen
@@ -8,7 +8,7 @@ useClassGetNameTooltip=Más resistente frente a modificaciones en la base de có
useClassGetName=Utilizar Class.getName() para nombres de tipo
useStringLiteralsTooltip=El fragmento de código puede utilizarse en todas las ubicaciones, pero se romperá si se modifica la base de código.
queryDefinitionViewer=Visor de definición de consulta
runAsSubstantive=Ejecutar
run=Ejecutar
queryNotValidBecause=No se puede hacer ninguna consulta porque
queryRunner=Ejecutor de la consulta
runAQuery=Realice una consulta
@@ -41,4 +41,4 @@ queryDefinitionProvider=Proveedor de definición de consultas
dataMiningRetrieval=Recuperación de datos
tabbedResultsPresenter=Presentador de resultados por pestañas
useStringLiterals=Utilizar literales de cadena para los nombres de tipo
numberPairResultsPresenter=Diagrama de dispersión
numberPairResultsPresenter=Diagrama de dispersi�n
@@ -8,7 +8,7 @@ useClassGetNameTooltip=Plus stable face aux modifications dans la base de code,
useClassGetName=Utilisez Class.getName() pour les noms des types.
useStringLiteralsTooltip=Le fichier de script peut être utilisé partout, mais sera corrompu si la base de code change.
queryDefinitionViewer=Visualiseur de définitions de requête
runAsSubstantive=Exécuter
run=Exécuter
queryNotValidBecause=Aucune requête possible dû à
queryRunner=Outil d''exécution de requêtes
runAQuery=Exécuter une requête
@@ -8,7 +8,7 @@ useClassGetNameTooltip=コードベースでの変更に対してより堅牢で
useClassGetName=タイプ名に class.getName() を使用
useStringLiteralsTooltip=このコードスニペットはどこでも使用できますが、コードベースが変更される場合は中断します。
queryDefinitionViewer=クエリ定義ビューア
runAsSubstantive=実行
run=実行
queryNotValidBecause=クエリが可能でありません。理由:
queryRunner=クエリランナー
runningQuery=クエリ実行中
@@ -8,7 +8,7 @@ useClassGetNameTooltip=Mais robusto em relação às modificações na base do c
useClassGetName=Utilizar Class.getName() para nomes de tipo
useStringLiteralsTooltip=O trecho do código pode ser utilizado em qualquer local, mas será quebrado se a base do código for modificada.
queryDefinitionViewer=Visualizador de definição da consulta
runAsSubstantive=Competir
run=Competir
queryNotValidBecause=Nenhuma consulta possível, pois
queryRunner=Executor de consulta
runAQuery=Executar uma consulta
@@ -41,4 +41,4 @@ queryDefinitionProvider=Fornecedor da definição da consulta
dataMiningRetrieval=Obtenção de dados
tabbedResultsPresenter=Apresentador de resultados por fichas
useStringLiterals=Utilizar literais de cadeia para nomes de tipo
numberPairResultsPresenter=Diagrama de dispersão
numberPairResultsPresenter=Diagrama de dispers�o
@@ -8,7 +8,7 @@ useClassGetNameTooltip=Более надежно по сравнению с из
useClassGetName=Использовать Class.getName() для имен типов
useStringLiteralsTooltip=Фрагмент кода может использоваться где угодно, но будет нарушен в случае изменения основания кода.
queryDefinitionViewer=Средство просмотра определения запроса
runAsSubstantive=Выполнить
run=Выполнить
queryNotValidBecause=Запрос невозможен, так как
queryRunner=Выполнение запроса
runAQuery=Выполнить запрос
@@ -8,7 +8,7 @@ useClassGetNameTooltip=更灵活应对代码库的更改,但是代码片段只
useClassGetName=将 Class.getName() 用于类型名称
useStringLiteralsTooltip=代码片段可在任意位置使用,当如果基本代码更改,其将中断。
queryDefinitionViewer=查询定义查看器
runAsSubstantive=运行
run=运行
queryNotValidBecause=无法查询,原因:
queryRunner=查询执行器
runAQuery=运行查询
@@ -64,7 +64,7 @@ public class SimpleQueryRunner extends AbstractDataMiningComponent<QueryRunnerSe
this.queryDefinitionProvider = queryDefinitionProvider;
this.resultsPresenter = resultsPresenter;
runButton = new Button(getDataMiningStringMessages().runAsSubstantive());
runButton = new Button(getDataMiningStringMessages().run());
runButton.addClickHandler(new ClickHandler() {
@Override
public void onClick(ClickEvent event) {
@@ -31,7 +31,9 @@ import com.google.gwt.user.cellview.client.DataGrid;
import com.google.gwt.user.cellview.client.RowHoverEvent;
import com.google.gwt.user.cellview.client.TextColumn;
import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwt.user.client.ui.Button;
import com.google.gwt.user.client.ui.DockLayoutPanel;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Label;
import com.google.gwt.user.client.ui.ScrollPanel;
import com.google.gwt.user.client.ui.Widget;
@@ -72,8 +74,9 @@ public class HierarchicalDimensionListFilterSelectionProvider extends AbstractCo
private static final Unit LayoutUnit = Unit.PX;
private static final double SelectionPresenterHeight = 100;
private static final double DimensionSelectionWidth = 300;
private static final double DimensionSelectionHeaderHeight = 40;
private static final double DimensionSelectionWidth = 350;
private static final double DimensionSelectionHeaderHeight = 30;
private static final double FilterFilterDimensionsHeight = 40;
private static final double FilterSelectionTableWidth = 250;
private final DataMiningSession session;
@@ -127,6 +130,11 @@ public class HierarchicalDimensionListFilterSelectionProvider extends AbstractCo
filterDimensionsSelectionTitleLabel.addStyleName("dataMiningMarginLeft");
filterDimensionsSelectionTitleLabel.addStyleName("filterDimensionsTitleLabel");
Button clearSelectionButton = new Button(stringMessages.clear());
clearSelectionButton.addStyleName("floatRight");
clearSelectionButton.addStyleName("dataMiningMarginRight");
clearSelectionButton.addClickHandler(e -> clearSelection());
DataMiningDataGridResources resources = GWT.create(DataMiningDataGridResources.class);
filterDimensionsList = new DataGrid<>(Integer.MAX_VALUE, resources);
filterDimensionsList.setAutoHeaderRefreshDisabled(true);
@@ -168,9 +176,14 @@ public class HierarchicalDimensionListFilterSelectionProvider extends AbstractCo
};
filterDimensionsList.addColumn(dimensionColumn);
FlowPanel headerPanel = new FlowPanel();
headerPanel.addStyleName("dataMiningMarginTop");
headerPanel.add(filterDimensionsSelectionTitleLabel);
headerPanel.add(clearSelectionButton);
DockLayoutPanel filterDimensionsSelectionPanel = new DockLayoutPanel(LayoutUnit);
filterDimensionsSelectionPanel.addNorth(filterDimensionsSelectionTitleLabel, 20);
filterDimensionsSelectionPanel.addNorth(filterFilterDimensionsPanel, DimensionSelectionHeaderHeight);
filterDimensionsSelectionPanel.addNorth(headerPanel, DimensionSelectionHeaderHeight);
filterDimensionsSelectionPanel.addNorth(filterFilterDimensionsPanel, FilterFilterDimensionsHeight);
filterDimensionsSelectionPanel.add(filterDimensionsList);
dimensionFilterSelectionProviders = new HashMap<>();
@@ -94,9 +94,9 @@ public class QueryDefinitionProviderWithControls extends AbstractQueryDefinition
new ClickHandler() {
@Override
public void onClick(ClickEvent event) {
boolean active = queryDefinitionViewerToggleButton.isDown();
filterSplitPanel.setWidgetHidden(queryDefinitionViewer.getEntryWidget(), !active);
queryDefinitionViewer.setActive(active);
boolean active = queryDefinitionViewerToggleButton.isDown();
filterSplitPanel.setWidgetHidden(queryDefinitionViewer.getEntryWidget(), !active);
queryDefinitionViewer.setActive(active);
}
});
queryDefinitionViewer = new QueryDefinitionViewer(parent, context, getDataMiningStringMessages());
@@ -106,15 +106,6 @@ public class QueryDefinitionProviderWithControls extends AbstractQueryDefinition
predefinedQueryRunner = new PredefinedQueryRunner(parent, context, getDataMiningStringMessages(),
dataMiningService, errorReporter, this, queryRunner);
Button clearSelectionButton = new Button(getDataMiningStringMessages().clearSelection());
clearSelectionButton.addClickHandler(new ClickHandler() {
@Override
public void onClick(ClickEvent event) {
filterSelectionProvider.clearSelection();
}
});
addControl(clearSelectionButton);
Button reloadButton = new Button(getDataMiningStringMessages().reload());
reloadButton.addClickHandler(new ClickHandler() {
@Override