bug: error message for failed update was specific to a true set value

Setting feature and community updates may fail. The error shown then
would be  "failed to opt out of ... " in both cases, even if it was
attempted to opt it and *then* failed. this is corrected by use of a
generic error message.
This commit is contained in:
Sohaib Baig committed 2026-05-04 13:09:17 +02:00
1 parent 3e4579b75f
commit 6bb1e23548
4 files changed
+4 -4

No files matched your search

@@ -37,7 +37,7 @@ public class MiscellaneousDisplayImpl {
final AsyncCallback<VoidResult> callbackWrappedWithToastNotification = new AsyncCallback<VoidResult>() {
@Override
public void onFailure(Throwable caught) {
final String failText = StringMessages.INSTANCE.couldNotOptOutOfFeatureAndCommunityUpdates();
final String failText = StringMessages.INSTANCE.couldNotToggleFeatureAndCommunityUpdates();
Notification.notify(failText, NotificationType.ERROR);
if (callback != null) {
callback.onFailure(caught);
@@ -2561,7 +2561,7 @@ public interface StringMessages extends com.sap.sse.gwt.client.StringMessages,
String optOutOfFeatureAndCommunityUpdates();
String optedOutOfFeatureAndCommunityUpdates();
String optedInToFeatureAndCommunityUpdates();
String couldNotOptOutOfFeatureAndCommunityUpdates();
String couldNotToggleFeatureAndCommunityUpdates();
String youWillNowReceiveNotificationsForFavoriteCompetitors();
String youWillNotReceiveNotificationsForFavoriteCompetitorsAnymore();
String failedToSetStatusOfNotificationsForFavoriteCompetitors();
@@ -2597,7 +2597,7 @@ securityUpdates=Security Updates
optOutOfFeatureAndCommunityUpdates=Opt out of feature and community updates
optedOutOfFeatureAndCommunityUpdates=You have opted out of feature and community updates
optedInToFeatureAndCommunityUpdates=You will now receive feature and community updates
couldNotOptOutOfFeatureAndCommunityUpdates=Could not opt-out of feature and community updates
couldNotToggleFeatureAndCommunityUpdates=Could not toggle feature and community updates
failedToSetStatusOfNotificationsForFavoriteCompetitors=Failed to set status of notifications for favorite competitors
youWillNowReceiveNotificationsForFavoriteCompetitors=You will now receive notifications for favorite competitors
failedToSetStatusOfUpdatesOnUpcomingRacesForYourFavoredBoatClasses=Failed to set status of notifications for upcoming races of your favored boat classes
@@ -2591,7 +2591,7 @@ securityUpdates=Sicherheitsupdates
optOutOfFeatureAndCommunityUpdates=Funktions- und Community-Updates abbestellen
optedOutOfFeatureAndCommunityUpdates=Sie haben Funktions- und Community-Updates abbestellt.
optedInToFeatureAndCommunityUpdates=Sie erhalten nun Funktions- und Community-Updates.
couldNotOptOutOfFeatureAndCommunityUpdates=Funktions- und Community-Updates konnten nicht abbestellt werden.
couldNotToggleFeatureAndCommunityUpdates=Der Status der Funktions- und Community-Updates konnte nicht geändert werden.
failedToSetStatusOfNotificationsForFavoriteCompetitors=Status der Benachrichtigungen für bevorzugte Teilnehmer konnte nicht festgelegt werden.
youWillNowReceiveNotificationsForFavoriteCompetitors=Sie erhalten nun Benachrichtigungen für Ihre bevorzugten Teilnehmer.
youWillNotReceiveNotificationsForFavoriteCompetitorsAnymore=Sie erhalten keine Benachrichtigungen mehr für Ihre Lieblingskonkurrenten.