mirror of
https://github.com/eclipse-sailing-analytics/sailing-analytics.git
synced 2026-10-31 16:20:45 +00:00
bug6299: un-pin Firefox for Selenium tests, default to latest
Now that the Selenium suite is on 4.13.0 (#6298) and speaks the W3C WebDriver protocol, the Firefox 140 pin is no longer needed: the pin was a symptom of Selenium 3's JSON Wire Protocol drifting from modern geckodriver/Firefox. Default the firefox_version workflow_dispatch input to "latest" (both the input default and the empty-input fallback) so CI tracks the current Firefox; the setup-firefox action pairs a matching geckodriver automatically. The input is kept so a specific version can still be pinned at dispatch time if a future Firefox release regresses. Assisted-By: Claude (claude-4.8-opus)
This commit is contained in:
1 parent
44e10ffcd7
commit
6fea91d86e
1 file changed
+3
-3
@@ -55,8 +55,8 @@ on:
|
||||
description: Empty means ubuntu-latest, usually 4 CPUs with little disk/memory, but if you have runners named ubuntu-latest-Xcpu, it can be 4, 8, 16, and 64 as well, using, e.g., ubuntu-latest-16cpu; default is ubuntu-latest
|
||||
default: ''
|
||||
firefox_version:
|
||||
description: Version to use for Selenium tests; default is 137.0, but could, e.g., be "141.0" or "latest"
|
||||
default: '140.0'
|
||||
description: Version to use for Selenium tests; default is "latest", but could, e.g., be "141.0" or a specific pin like "140.0"
|
||||
default: 'latest'
|
||||
|
||||
jobs:
|
||||
# The "changes" job will cause the "build" job to get skipped for trivial changes
|
||||
@@ -163,7 +163,7 @@ jobs:
|
||||
id: setup-firefox
|
||||
uses: browser-actions/setup-firefox@0bc507ddf224827e3b1af68e014d5e42ab93e795 # v1.7.2
|
||||
with:
|
||||
firefox-version: ${{ github.event.inputs.firefox_version == '' && '140.0' || github.event.inputs.firefox_version }}
|
||||
firefox-version: ${{ github.event.inputs.firefox_version == '' && 'latest' || github.event.inputs.firefox_version }}
|
||||
- run: |
|
||||
echo Installed firefox versions: ${{ steps.setup-firefox.outputs.firefox-version }}
|
||||
${{ steps.setup-firefox.outputs.firefox-path }} --version
|
||||
|
||||
Reference in new issue
Block a user