eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-11-09 20:41:10 +00:00
Code Activity

Bug 4796: Improved handling of security for igtimi accounts

Browse Source
This commit is contained in:
Steffen Schaefer committed 2019-03-12 11:50:31 +01:00
1 parent 1e67eb0bf8
commit 81614904f2
1 file changed
+7 -11
Download Patch File Download Diff File Expand all files Collapse all files
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/server/SailingServiceImpl.java
+7 -11
View File
@@ -6331,14 +6331,8 @@ public class SailingServiceImpl extends ResultCachingProxiedRemoteServiceServlet
@Override
public Iterable<String> getAllIgtimiAccountEmailAddresses() {
List<String> result = new ArrayList<String>();
for (Account account : getIgtimiConnectionFactory().getAllAccounts()) {
final String email = account.getUser().getEmail();
if (SecurityUtils.getSubject().isPermitted(SecuredDomainType.IGTIMI_ACCOUNT.getStringPermissionForObject(DefaultActions.READ, account))) {
result.add(email);
}
}
return result;
return getSecurityService().mapAndFilterByReadPermissionForCurrentUser(SecuredDomainType.IGTIMI_ACCOUNT,
getIgtimiConnectionFactory().getAllAccounts(), acc -> acc.getUser().getEmail());
}
private IgtimiConnectionFactory getIgtimiConnectionFactory() {
@@ -6377,9 +6371,11 @@ public class SailingServiceImpl extends ResultCachingProxiedRemoteServiceServlet
@Override
public void removeIgtimiAccount(String eMailOfAccountToRemove) {
final Account existingAccount = getIgtimiConnectionFactory().getExistingAccountByEmail(eMailOfAccountToRemove);
SecurityUtils.getSubject().checkPermission(SecuredDomainType.IGTIMI_ACCOUNT.getStringPermissionForObject(
DefaultActions.DELETE, existingAccount));
getIgtimiConnectionFactory().removeAccount(existingAccount);
if (existingAccount != null) {
getSecurityService().checkPermissionAndDeleteOwnershipForObjectRemoval(existingAccount, () -> {
getIgtimiConnectionFactory().removeAccount(existingAccount);
});
}
}
@Override