bug5857: fixed by comparing the scores considering the column factor

This commit is contained in:
Axel Uhl
2024-08-08 15:14:08 +02:00
parent 71f2d90096
commit 82f76da82b
2 changed files with 8 additions and 1 deletions
@@ -275,7 +275,7 @@ public class MatchAndApplyScoreCorrectionsDialog extends DataEntryDialog<BulkSco
// entries not considered "different' in case we haven't got an entry for the competitor/race at all;
// those non-existing "entries" will be ignored by getResults anyhow
boolean entriesDiffer = officialCorrectionEntry != null &&
(((officialTotalPoints == null && entry.totalPoints != null) || (officialTotalPoints != null && (entry.totalPoints == null || !Double.valueOf(entry.totalPoints).equals(officialTotalPoints)))) ||
(((officialTotalPoints == null && entry.totalPoints != null) || (officialTotalPoints != null && (entry.totalPoints == null || !Double.valueOf(entry.netPoints).equals(officialTotalPointsWithFactorApplied)))) ||
((officialTotalPointsWithFactorApplied == null && entry.netPoints != null) || (officialTotalPointsWithFactorApplied != null && (entry.netPoints == null || !Double.valueOf(entry.netPoints).equals(officialTotalPointsWithFactorApplied)))) ||
((officialMaxPointsReason == null && entry.reasonForMaxPoints != MaxPointsReason.NONE) ||
officialMaxPointsReason != null && officialMaxPointsReason != entry.reasonForMaxPoints));
@@ -23,6 +23,13 @@
<div class="mainContent">
<h2 class="releaseHeadline">Release Notes - Administration Console</h2>
<div class="innerContent">
<h2 class="articleSubheadline">August 2024</h2>
<ul class="bulletList">
<li>When importing race results for race columns with column factors different from 1.0,
score difference highlighting now properly considers those column factors. This
should help in particular when importing medal race scores which by default are
doubled.</li>
</ul>
<h2 class="articleSubheadline">July 2024</h2>
<ul class="bulletList">
<li>A regatta's end date is now considered for deciding whether to display the regatta as still