datamining-reports: made StoredDataMiningReportDTOImpl a Renamable

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/datamining/DataMiningEntryPoint.java

@@ -94,7 +94,6 @@ public class DataMiningEntryPoint extends AbstractSailingReadEntryPoint {
 
     private void createDataminingPanel(ServerInfoDTO serverInfo, final String queryIdentifier) {
         removeUrlParameter();
-        ;
         SAPHeaderWithAuthentication header = new SAPSailingHeaderWithAuthentication(getStringMessages().dataMining());
         PaywallResolver paywallResolver = new PaywallResolver(getUserService(), getSubscriptionServiceFactory());
         GenericAuthentication genericSailingAuthentication = new FixedSailingAuthentication(getUserService(), paywallResolver,
@@ -103,7 +102,6 @@ public class DataMiningEntryPoint extends AbstractSailingReadEntryPoint {
                 genericSailingAuthentication);
         authorizedContentDecorator.setPermissionToCheck(serverInfo, ServerActions.DATA_MINING);
         authorizedContentDecorator.setContentWidgetFactory(new WidgetFactory() {
-
             private SimpleQueryRunner queryRunner;
             private final DataMiningSettingsInfoManager settingsManager = new DataMiningSettingsInfoManagerImpl(
                     getStringMessages());
@@ -125,11 +123,9 @@ public class DataMiningEntryPoint extends AbstractSailingReadEntryPoint {
                         queryDefinitionProvider.applyQueryDefinition(queryDefinition);
                     }
                 });
-
                 queryDefinitionProvider = new QueryDefinitionProviderWithControls(null, null, session,
                         dataMiningService, DataMiningEntryPoint.this, settingsControl, settingsManager,
                         queryDefinition -> queryRunner.run(queryDefinition));
-
                 queryRunner = new SimpleQueryRunner(null, null, session, dataMiningService, DataMiningEntryPoint.this,
                         queryDefinitionProvider, resultsPresenter);
                 queryDefinitionProvider.addControl(queryRunner.getEntryWidget());
@@ -137,13 +133,11 @@ public class DataMiningEntryPoint extends AbstractSailingReadEntryPoint {
                     StoredDataMiningQueryDataProvider queryProvider = new StoredDataMiningQueryDataProvider(
                             queryDefinitionProvider, dataMiningService, dataMiningWriteService, getStringMessages());
                     queryDefinitionProvider.addControl(new StoredDataMiningQueryPanel(queryProvider));
-
                     StoredDataMiningReportsProvider reportsProvider = new StoredDataMiningReportsProvider(
                             dataMiningService, dataMiningWriteService);
                     queryDefinitionProvider.addControl(new DataMiningReportStoreControls(DataMiningEntryPoint.this,
                             session, dataMiningService, reportsProvider, mainPanel, queryDefinitionProvider.getRetrieverChainProvider(), resultsPresenter));
                 }
-
                 Anchor orientationAnchor = new Anchor(
                         AbstractImagePrototype.create(dataMiningResources.orientationIcon()).getSafeHtml());
                 orientationAnchor.addStyleName("orientationAnchor");
@@ -192,11 +186,9 @@ public class DataMiningEntryPoint extends AbstractSailingReadEntryPoint {
                         }
                     });
                 }
-                
                 return mainPanel;
             }
         });
-
         RootLayoutPanel rootPanel = RootLayoutPanel.get();
         DockLayoutPanel panel = new DockLayoutPanel(Unit.PX);
         panel.addNorth(header, 75);

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/server/DataMiningWriteServiceImpl.java

@@ -34,5 +34,4 @@ public class DataMiningWriteServiceImpl extends DataMiningServiceImpl implements
         checkDataMiningPermission();
         return storedDataMiningReportPersistor.removeStoredReport(report);
     }
-
 }

java/com.sap.sse.datamining.shared/src/com/sap/sse/datamining/shared/dto/StoredDataMiningReportDTO.java

@@ -1,12 +1,10 @@
 package com.sap.sse.datamining.shared.dto;
 
-import java.io.Serializable;
 import java.util.UUID;
 
-public interface StoredDataMiningReportDTO extends Serializable {
+import com.sap.sse.common.Named;
 
-    String getName();
+public interface StoredDataMiningReportDTO extends Named {
     UUID getId();
     DataMiningReportDTO getReport();
-
 }

java/com.sap.sse.datamining.shared/src/com/sap/sse/datamining/shared/impl/dto/StoredDataMiningReportDTOImpl.java

@@ -2,21 +2,24 @@ package com.sap.sse.datamining.shared.impl.dto;
 
 import java.util.UUID;
 
+import com.sap.sse.common.impl.RenamableImpl;
 import com.sap.sse.datamining.shared.dto.DataMiningReportDTO;
 import com.sap.sse.datamining.shared.dto.StoredDataMiningReportDTO;
 
-public class StoredDataMiningReportDTOImpl implements StoredDataMiningReportDTO {
+public class StoredDataMiningReportDTOImpl extends RenamableImpl implements StoredDataMiningReportDTO {
     private static final long serialVersionUID = 9218620680326470175L;
     
     private UUID id;
-    private String name;
     private DataMiningReportDTO report;
 
-    public StoredDataMiningReportDTOImpl() { }
+    @Deprecated // for GWT serialization only
+    StoredDataMiningReportDTOImpl() {
+        super(null);
+    }
 
     public StoredDataMiningReportDTOImpl(UUID id, String name, DataMiningReportDTO report) {
+        super(name);
         this.id = id;
-        this.name = name;
         this.report = report;
     }
 
@@ -25,15 +28,6 @@ public class StoredDataMiningReportDTOImpl implements StoredDataMiningReportDTO
         return this.id;
     }
 
-    @Override
-    public String getName() {
-        return this.name;
-    }
-    
-    public void setName(String name) {
-        this.name = name;
-    }
-
     @Override
     public DataMiningReportDTO getReport() {
         return this.report;