eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-10-23 12:33:53 +00:00
Code Activity

Removed constants that are only used in one settings object

Browse Source
This commit is contained in:
Steffen Schaefer committed 2017-02-14 15:47:50 +01:00
1 parent 4c6d70dca9
commit a11440be04
3 files changed
+7 -25
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/leaderboard/LeaderboardContextSettings.java
+2 -2
View File
@@ -26,9 +26,9 @@ public class LeaderboardContextSettings extends AbstractGenericSerializableSetti
@Override
protected void addChildSettings() {
eventId = new UUIDSetting(LeaderboardUrlSettings.PARAM_EVENT_ID, this);
eventId = new UUIDSetting("eventId", this);
leaderboardName = new StringSetting("name", this);
leaderboardGroupName = new StringSetting(LeaderboardUrlSettings.PARAM_LEADERBOARD_GROUP_NAME, this);
leaderboardGroupName = new StringSetting("leaderboardGroupName", this);
displayName = new StringSetting("displayName", this);
raceName = new StringSetting(LeaderboardUrlSettings.PARAM_RACE_NAME, this);
regattaName = new StringSetting(LeaderboardUrlSettings.PARAM_REGATTA_NAME, this);
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/leaderboard/LeaderboardPerspectiveOwnSettings.java
+5 -5
View File
@@ -36,13 +36,13 @@ public class LeaderboardPerspectiveOwnSettings extends AbstractGenericSerializab
@Override
protected void addChildSettings() {
showRaceDetails = new BooleanSetting(LeaderboardUrlSettings.PARAM_SHOW_RACE_DETAILS, this, false);
hideToolbar = new BooleanSetting(LeaderboardUrlSettings.PARAM_HIDE_TOOLBAR, this, false);
hideToolbar = new BooleanSetting("hideToolbar", this, false);
autoExpandLastRaceColumn = new BooleanSetting(LeaderboardUrlSettings.PARAM_AUTO_EXPAND_LAST_RACE_COLUMN, this, false);
showCharts = new BooleanSetting(LeaderboardUrlSettings.PARAM_SHOW_CHARTS, this, false);
showOverallLeaderboard = new BooleanSetting(LeaderboardUrlSettings.PARAM_SHOW_OVERALL_LEADERBOARD, this, false);
showSeriesLeaderboards = new BooleanSetting(LeaderboardUrlSettings.PARAM_SHOW_SERIES_LEADERBOARDS, this, false);
zoomTo = new StringSetting(LeaderboardUrlSettings.PARAM_ZOOM_TO, this, "1");
embedded = new BooleanSetting(LeaderboardUrlSettings.PARAM_EMBEDDED, this, false);
showOverallLeaderboard = new BooleanSetting("showOverallLeaderboard", this, false);
showSeriesLeaderboards = new BooleanSetting("showSeriesLeaderboards", this, false);
zoomTo = new StringSetting("zoomTo", this, "1");
embedded = new BooleanSetting("embedded", this, false);
}
public boolean isShowRaceDetails() {
return showRaceDetails.getValue();
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/leaderboard/LeaderboardUrlSettings.java
-18
View File
@@ -3,10 +3,6 @@ package com.sap.sailing.gwt.ui.leaderboard;
import com.sap.sse.common.settings.AbstractSettings;
public class LeaderboardUrlSettings extends AbstractSettings {
public static final String PARAM_LEADERBOARD_GROUP_NAME = "leaderboardGroupName";
public static final String PARAM_EVENT_ID = "eventId";
public static final String PARAM_EMBEDDED = "embedded";
public static final String PARAM_HIDE_TOOLBAR = "hideToolbar";
public static final String PARAM_SHOW_RACE_DETAILS = "showRaceDetails";
public static final String PARAM_RACE_NAME = "raceName";
public static final String PARAM_RACE_DETAIL = "raceDetail";
@@ -18,12 +14,7 @@ public class LeaderboardUrlSettings extends AbstractSettings {
public static final String PARAM_REGATTA_NAME = "regattaName";
public static final String PARAM_REFRESH_INTERVAL_MILLIS = "refreshIntervalMillis";
public static final String PARAM_SHOW_CHARTS = "showCharts";
public static final String PARAM_CHART_DETAIL = "chartDetail";
public static final String PARAM_SHOW_OVERALL_LEADERBOARD = "showOverallLeaderboard";
public static final String PARAM_SHOW_SERIES_LEADERBOARDS = "showSeriesLeaderboards";
public static final String PARAM_SHOW_ADDED_SCORES = "showAddedScores";
public static final String PARAM_SHOW_TIME_ON_TIME_FACTOR = "showTimeOnTimeFactor";
public static final String PARAM_SHOW_TIME_ON_DISTANCE_ALLOWANCE = "showTimeOnDistanceAllowance";
public static final String PARAM_SHOW_OVERALL_COLUMN_WITH_NUMBER_OF_RACES_COMPLETED = "showNumberOfRacesCompleted";
/**
@@ -36,15 +27,6 @@ public class LeaderboardUrlSettings extends AbstractSettings {
public static final String COMPETITOR_NAME_COLUMN_SAIL_ID = "SailId";
public static final String COMPETITOR_NAME_COLUMN_FULL_NAME = "Name";
/**
* Parameter to support scaling the complete page by a given factor. This works by either using the
* CSS3 zoom property or by applying scale operation to the body element. This comes in handy
* when having to deal with screens that have high resolutions and that can't be controlled manually.
* It is also a very simple method of adapting the viewport to a tv resolution. This parameter works
* with value from 0.0 to 10.0 where 1.0 denotes the unchanged level (100%).
*/
public static final String PARAM_ZOOM_TO = "zoomTo";
/**
* Lets the client choose a different race column selection which displays only up to the last N races with N being the integer
* number specified by the parameter.