added TODO regarding SimulationServiceImpl.LegChangeListener; probably a bug

Change-Id: I2d719dcdefa116479a1d536052809607ba3de169
This commit is contained in:
Axel Uhl committed 2018-06-04 18:13:12 +02:00
1 parent 9b49c07842
commit a84c61e84a
1 file changed
+16 -2
@@ -122,12 +122,26 @@ public class SimulationServiceImpl implements SimulationService {
}
}
/**
* A stateful listener whose {@link #legIdentifier} may change over time, updated to the most recent request. When
* changes to the race are received that are considered relevant for the simulation results, a cache update will be
* triggered {@link SimulationServiceImpl#WAIT_MILLIS} milliseconds after the change event. To avoid redundant
* triggers, more updates received before the wait period expires are ignored as long as they are for the same leg.<p>
*
* TODO the {@link #covered} and {@link #legIdentifier} fields with the stateful design and the dependence on {@link #isLive}
* seem a bit "smelly." The {@link #legIdentifier} field is updated only in "live" mode when a simulator result is requested.
* It therefore remains at the last leg for which a result was requested while the race was in live mode. This doesn't
* necessarily have to be the race's last leg. When updates strike---such as a mark moving---then the simulation results
* for all of the race's legs at least need to be invalidated. The way the implementation looks right now it seems that
* results for legs that were requested earlier will not be updated because {@link #legIdentifier} does not point to them.
* And since {@link #legIdentifier} is no more updated for non-live races, updates to older leg simulation results will
* never happen...
*/
private class LegChangeListener extends AbstractRaceChangeListener {
private final TrackedRace trackedRace;
private LegIdentifier legIdentifier;
private final ScheduledExecutorService scheduler;
private boolean covered;
public LegChangeListener(TrackedRace trackedRace, ScheduledExecutorService scheduler) {
this.trackedRace = trackedRace;
@@ -153,7 +167,7 @@ public class SimulationServiceImpl implements SimulationService {
@Override
protected void defaultAction() {
if ((!this.covered)&&(legIdentifier!=null)) {
if ((!this.covered) && (legIdentifier != null)) {
this.covered = true;
LegIdentifier tmpLegIdentifier = new LegIdentifierImpl(legIdentifier.getRaceIdentifier(), legIdentifier.getLegName());
scheduler.schedule(() -> triggerUpdate(tmpLegIdentifier), WAIT_MILLIS, TimeUnit.MILLISECONDS);