eclipse-sailing-analytics/sailing-analytics
1
0
Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-09-22 21:55:39 +00:00
Code Activity

Bug 4147: cleanup after review

Browse Source
This commit is contained in:
Steffen Jacobs
2018-10-31 15:44:04 +01:00
parent 7f59fa2cdd
commit a8739e6214
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/shared/partials/dialog/whatsnew/WhatsNewDialogFactory.java
+7 -7
View File
@@ -51,8 +51,8 @@ public final class WhatsNewDialogFactory {
*/
private static void showWhatsNewDialogIfNecessaryAndUpdatePreference(UserService userService,
PlaceController placeController) {
final long linesInWhatsChangedDocument = WhatsNewResources.INSTANCE.getSailingAnalyticsNotesHtml().getText()
.length();
final long charactersInWhatsChangedDocument = WhatsNewResources.INSTANCE.getSailingAnalyticsNotesHtml()
.getText().length();
userService.getPreference(WhatsNewSettings.PREF_NAME, new AsyncCallback<String>() {
@Override
@@ -62,13 +62,13 @@ public final class WhatsNewDialogFactory {
DialogCallback<Void> dialogCallback = new DialogCallback<Void>() {
@Override
public void ok(Void editedObject) {
updateOrCreatePreference(linesInWhatsChangedDocument, settingsToJsonSerializerGWT);
updateOrCreatePreference(charactersInWhatsChangedDocument, settingsToJsonSerializerGWT);
placeController.goTo(new WhatsNewPlace(WhatsNewNavigationTabs.SailingAnalytics));
}
@Override
public void cancel() {
updateOrCreatePreference(linesInWhatsChangedDocument, settingsToJsonSerializerGWT);
updateOrCreatePreference(charactersInWhatsChangedDocument, settingsToJsonSerializerGWT);
}
};
@@ -76,7 +76,7 @@ public final class WhatsNewDialogFactory {
// deserialize whats-new-setting
WhatsNewSettings pref = settingsToJsonSerializerGWT.deserialize(new WhatsNewSettings(), result);
if (pref.getNumberOfCharsOnLastLogin() > linesInWhatsChangedDocument + THRESHOLD_WHATS_NEW) {
if (pref.getNumberOfCharsOnLastLogin() > charactersInWhatsChangedDocument + THRESHOLD_WHATS_NEW) {
// check if length change is over threshold
WhatsNewDialogFactory.showWhatsNewDialog(placeController, dialogCallback);
}
@@ -92,10 +92,10 @@ public final class WhatsNewDialogFactory {
}
/** Updates or creates a {@link WhatsNewSettings} object. */
private void updateOrCreatePreference(long linesInWhatsChangedDocument,
private void updateOrCreatePreference(long charactersInWhatsChangedDocument,
SettingsToJsonSerializerGWT settingsToJsonSerializerGWT) {
String serializedSetting = settingsToJsonSerializerGWT
.serializeToString(new WhatsNewSettings(linesInWhatsChangedDocument));
.serializeToString(new WhatsNewSettings(charactersInWhatsChangedDocument));
userService.setPreference(WhatsNewSettings.PREF_NAME, serializedSetting, new AsyncCallback<Void>() {
@Override