eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-11-13 22:15:26 +00:00
Code Activity

Bug 5269: Changed method references to anonymous inner classes in cases

Browse Source 
where MigrateGroupOwnershipDialog is used because this seems to trigger
a bug in the GWT compiler.
This commit is contained in:
Steffen Schaefer committed 2020-05-04 16:02:40 +02:00
1 parent 325895f6df
commit ade9d0203f
2 files changed
+46 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/EventListComposite.java
+24 -3
View File
@@ -16,6 +16,8 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.UUID;
import java.util.function.Consumer;
import com.google.gwt.cell.client.AbstractCell;
import com.google.gwt.cell.client.SafeHtmlCell;
import com.google.gwt.cell.client.ValueUpdater;
@@ -329,12 +331,25 @@ public class EventListComposite extends Composite implements EventsRefresher, Le
});
final DialogConfig<EventDTO> config = EditOwnershipDialog.create(userService.getUserManagementService(), EVENT,
event -> fillEvents(), stringMessages);
actionsColumn.addAction(EventConfigImagesBarCell.ACTION_CHANGE_OWNERSHIP, CHANGE_OWNERSHIP, config::openOwnershipDialog);
actionsColumn.addAction(EventConfigImagesBarCell.ACTION_CHANGE_OWNERSHIP, CHANGE_OWNERSHIP,
// Explicitly using an anonymous inner class. Using a method reference caused problems with the GWT compiler (see bug 5269)
new Consumer<EventDTO>() {
@Override
public void accept(EventDTO t) {
config.openOwnershipDialog(t);
}
});
final EditACLDialog.DialogConfig<EventDTO> configACL = EditACLDialog.create(
userService.getUserManagementService(), EVENT, event -> fillEvents(), stringMessages);
actionsColumn.addAction(EventConfigImagesBarCell.ACTION_CHANGE_ACL, DefaultActions.CHANGE_ACL,
e -> configACL.openACLDialog(e));
// Explicitly using an anonymous inner class. Using a method reference caused problems with the GWT compiler (see bug 5269)
new Consumer<EventDTO>() {
@Override
public void accept(EventDTO e) {
configACL.openACLDialog(e);
}
});
final MigrateGroupOwnershipDialog.DialogConfig<EventDTO> migrateDialogConfig = MigrateGroupOwnershipDialog
.create(userService.getUserManagementService(), (event, dto) -> {
@@ -351,7 +366,13 @@ public class EventListComposite extends Composite implements EventsRefresher, Le
});
});
actionsColumn.addAction(EventConfigImagesBarCell.ACTION_MIGRATE_GROUP_OWNERSHIP_HIERARCHY, CHANGE_OWNERSHIP,
migrateDialogConfig::openDialog);
// Explicitly using an anonymous inner class. Using a method reference caused problems with the GWT compiler (see bug 5269)
new Consumer<EventDTO>() {
@Override
public void accept(EventDTO t) {
migrateDialogConfig.openDialog(t);
}
});
eventNameColumn.setSortable(true);
venueNameColumn.setSortable(true);
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/LeaderboardGroupConfigPanel.java
+22 -3
View File
@@ -15,6 +15,7 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.UUID;
import java.util.function.Consumer;
import java.util.function.Function;
import java.util.stream.Collectors;
@@ -596,13 +597,25 @@ public class LeaderboardGroupConfigPanel extends AbstractRegattaPanel
userService.getUserManagementService(), type,
group -> leaderboardGroupsRefresher.fillLeaderboardGroups(), stringMessages);
actionsColumn.addAction(LeaderboardGroupConfigImagesBarCell.ACTION_CHANGE_OWNERSHIP, CHANGE_OWNERSHIP,
e -> config.openOwnershipDialog(e));
// Explicitly using an anonymous inner class. Using a method reference caused problems with the GWT compiler (see bug 5269)
new Consumer<LeaderboardGroupDTO>() {
@Override
public void accept(LeaderboardGroupDTO e) {
config.openOwnershipDialog(e);
}
});
final EditACLDialog.DialogConfig<LeaderboardGroupDTO> configACL = EditACLDialog.create(
userService.getUserManagementService(), type,
group -> leaderboardGroupsRefresher.fillLeaderboardGroups(), stringMessages);
actionsColumn.addAction(LeaderboardGroupConfigImagesBarCell.ACTION_CHANGE_ACL, DefaultActions.CHANGE_ACL,
e -> configACL.openACLDialog(e));
// Explicitly using an anonymous inner class. Using a method reference caused problems with the GWT compiler (see bug 5269)
new Consumer<LeaderboardGroupDTO>() {
@Override
public void accept(LeaderboardGroupDTO e) {
configACL.openACLDialog(e);
}
});
final MigrateGroupOwnershipDialog.DialogConfig<LeaderboardGroupDTO> migrateDialogConfig = MigrateGroupOwnershipDialog
.create(userService.getUserManagementService(), (lg, dto) -> {
@@ -620,7 +633,13 @@ public class LeaderboardGroupConfigPanel extends AbstractRegattaPanel
});
});
actionsColumn.addAction(EventConfigImagesBarCell.ACTION_MIGRATE_GROUP_OWNERSHIP_HIERARCHY, CHANGE_OWNERSHIP,
e -> migrateDialogConfig.openDialog(e));
// Explicitly using an anonymous inner class. Using a method reference caused problems with the GWT compiler (see bug 5269)
new Consumer<LeaderboardGroupDTO>() {
@Override
public void accept(LeaderboardGroupDTO e) {
migrateDialogConfig.openDialog(e);
}
});
SelectionCheckboxColumn<LeaderboardGroupDTO> leaderboardTableSelectionColumn =
new SelectionCheckboxColumn<LeaderboardGroupDTO>(