eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-10-20 11:10:00 +00:00
Code Activity

fixing bug 3178 by applying the unwinding finally clause also when exception is thrown in computeCacheUpdate, not only in provideNewCacheValue

Browse Source
This commit is contained in:
Axel Uhl committed 2015-07-24 00:31:26 +02:00
1 parent ede8f5e9c0
commit adfe1fe8c8
1 file changed
+11 -8
Download Patch File Download Diff File Expand all files Collapse all files
java/com.sap.sse/src/com/sap/sse/util/SmartFutureCache.java
+11 -8
View File
@@ -317,16 +317,19 @@ public class SmartFutureCache<K, V, U extends UpdateInterval<U>> {
runningAndReadUpdateInterval = true;
}
try {
V preResult = cacheUpdateComputer.computeCacheUpdate(key, updateInterval);
final NamedReentrantReadWriteLock lock = getOrCreateLockForKey(key);
LockUtil.lockForWrite(lock);
try {
V result = cacheUpdateComputer.provideNewCacheValue(key, cache.get(key), preResult,
updateInterval);
cache(key, result);
return result;
V preResult = cacheUpdateComputer.computeCacheUpdate(key, updateInterval);
final NamedReentrantReadWriteLock lock = getOrCreateLockForKey(key);
LockUtil.lockForWrite(lock);
try {
V result = cacheUpdateComputer.provideNewCacheValue(key, cache.get(key), preResult,
updateInterval);
cache(key, result);
return result;
} finally {
LockUtil.unlockAfterWrite(lock);
}
} finally {
LockUtil.unlockAfterWrite(lock);
synchronized (ongoingRecalculations) {
boolean newTaskScheduled = false;
Pair<U, Set<SettableFuture<Future<V>>>> queued = triggeredAndNotYetScheduled.get(key);