eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-10-17 01:31:01 +00:00
Code Activity

User Management refactoring - Moved AuthenticationCallback to its own

Browse Source 
file
This commit is contained in:
Benjamin Barth committed 2016-01-26 11:00:26 +01:00
1 parent 5c2b724099
commit ba50dd299b
6 files changed
+23 -22
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/shared/usermanagement/AsyncLoginCallback.java
+2 -3
View File
@@ -1,7 +1,6 @@
package com.sap.sailing.gwt.home.shared.usermanagement;
import com.google.gwt.user.client.rpc.AsyncCallback;
import com.sap.sailing.gwt.home.shared.usermanagement.AuthenticationPlaceManagementController.Callback;
import com.sap.sse.security.ui.authentication.AuthenticationManager;
import com.sap.sse.security.ui.authentication.ErrorMessageView;
import com.sap.sse.security.ui.client.i18n.StringMessages;
@@ -11,11 +10,11 @@ public class AsyncLoginCallback implements AsyncCallback<SuccessInfo> {
private final AuthenticationManager authenticationManager;
private final ErrorMessageView view;
private final Callback callback;
private final AuthenticationCallback callback;
private final boolean fireSignInSuccessfulEvent;
public AsyncLoginCallback(AuthenticationManager authenticationManager, ErrorMessageView view,
AuthenticationPlaceManagementController.Callback callback, boolean fireSignInSuccessfulEvent) {
AuthenticationCallback callback, boolean fireSignInSuccessfulEvent) {
this.authenticationManager = authenticationManager;
this.view = view;
this.callback = callback;
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/shared/usermanagement/AuthenticationCallback.java
+11
View File
@@ -0,0 +1,11 @@
package com.sap.sailing.gwt.home.shared.usermanagement;
import com.sap.sse.security.ui.authentication.create.CreateAccountView;
import com.sap.sse.security.ui.authentication.info.LoggedInUserInfoView;
import com.sap.sse.security.ui.authentication.recover.PasswordRecoveryView;
public interface AuthenticationCallback extends CreateAccountView.Presenter.Callback,
PasswordRecoveryView.Presenter.Callback, LoggedInUserInfoView.Presenter.Callback {
void handleSignInSuccess();
}
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/shared/usermanagement/AuthenticationCallbackImpl.java
+1 -1
View File
@@ -6,7 +6,7 @@ import com.sap.sailing.gwt.home.shared.places.user.confirmation.ConfirmationPlac
import com.sap.sailing.gwt.home.shared.places.user.passwordreset.PasswordResetPlace;
import com.sap.sailing.gwt.home.shared.places.user.profile.AbstractUserProfilePlace;
public class AuthenticationCallbackImpl implements AuthenticationPlaceManagementController.Callback {
public class AuthenticationCallbackImpl implements AuthenticationCallback {
private final String createConfirmationUrl;
private final String passwordResetUrl;
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/shared/usermanagement/AuthenticationPlaceManagementController.java
+3 -12
View File
@@ -18,22 +18,13 @@ import com.sap.sse.security.ui.authentication.AuthenticationContextEvent;
import com.sap.sse.security.ui.authentication.RequiresLoggedInUser;
import com.sap.sse.security.ui.authentication.confirm.ConfirmationInfoPlace;
import com.sap.sse.security.ui.authentication.create.CreateAccountPlace;
import com.sap.sse.security.ui.authentication.create.CreateAccountView;
import com.sap.sse.security.ui.authentication.info.LoggedInUserInfoPlace;
import com.sap.sse.security.ui.authentication.info.LoggedInUserInfoView;
import com.sap.sse.security.ui.authentication.recover.PasswordRecoveryPlace;
import com.sap.sse.security.ui.authentication.recover.PasswordRecoveryView;
import com.sap.sse.security.ui.authentication.signin.SignInPlace;
public class AuthenticationPlaceManagementController extends WrappedPlaceManagementController {
public interface Callback extends CreateAccountView.Presenter.Callback,
PasswordRecoveryView.Presenter.Callback, LoggedInUserInfoView.Presenter.Callback {
void handleSignInSuccess();
}
public AuthenticationPlaceManagementController(AuthenticationClientFactory clientFactory, Callback callback,
public AuthenticationPlaceManagementController(AuthenticationClientFactory clientFactory, AuthenticationCallback callback,
UserManagementView userManagementView, EventBus globalEventBus) {
super(new Configuration(clientFactory, callback, userManagementView));
globalEventBus.addHandler(AuthenticationContextEvent.TYPE, new AuthenticationContextEvent.Handler() {
@@ -46,11 +37,11 @@ public class AuthenticationPlaceManagementController extends WrappedPlaceManagem
private static class Configuration implements PlaceManagementConfiguration {
private final AuthenticationClientFactory clientFactory;
private final Callback callback;
private final AuthenticationCallback callback;
private final UserManagementView userManagementView;
private PlaceController placeController;
public Configuration(AuthenticationClientFactory clientFactory, Callback callback,
public Configuration(AuthenticationClientFactory clientFactory, AuthenticationCallback callback,
UserManagementView userManagementView) {
this.clientFactory = clientFactory;
this.callback = callback;
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/shared/usermanagement/create/CreateAccountActivity.java
+3 -3
View File
@@ -9,7 +9,7 @@ import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwt.user.client.ui.AcceptsOneWidget;
import com.sap.sailing.gwt.home.shared.usermanagement.AsyncLoginCallback;
import com.sap.sailing.gwt.home.shared.usermanagement.AuthenticationPlaceManagementController;
import com.sap.sailing.gwt.home.shared.usermanagement.AuthenticationCallback;
import com.sap.sse.security.shared.UserManagementException;
import com.sap.sse.security.ui.authentication.AuthenticationClientFactory;
import com.sap.sse.security.ui.authentication.confirm.ConfirmationInfoPlace;
@@ -28,10 +28,10 @@ public class CreateAccountActivity extends AbstractActivity implements CreateAcc
private final StringMessages i18n_sec = StringMessages.INSTANCE;
private final CreateAccountFormValues values = new CreateAccountFormValues();
private final AuthenticationPlaceManagementController.Callback callback;
private final AuthenticationCallback callback;
public CreateAccountActivity(CreateAccountView view, AuthenticationClientFactory clientFactory,
AuthenticationPlaceManagementController.Callback callback, PlaceController placeController) {
AuthenticationCallback callback, PlaceController placeController) {
this.view = view;
this.clientFactory = clientFactory;
this.callback = callback;
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/shared/usermanagement/signin/SignInActivity.java
+3 -3
View File
@@ -5,7 +5,7 @@ import com.google.gwt.event.shared.EventBus;
import com.google.gwt.place.shared.PlaceController;
import com.google.gwt.user.client.ui.AcceptsOneWidget;
import com.sap.sailing.gwt.home.shared.usermanagement.AsyncLoginCallback;
import com.sap.sailing.gwt.home.shared.usermanagement.AuthenticationPlaceManagementController;
import com.sap.sailing.gwt.home.shared.usermanagement.AuthenticationCallback;
import com.sap.sse.security.ui.authentication.AuthenticationClientFactory;
import com.sap.sse.security.ui.authentication.AuthenticationContextEvent;
import com.sap.sse.security.ui.authentication.create.CreateAccountPlace;
@@ -18,10 +18,10 @@ public class SignInActivity extends AbstractActivity implements SignInView.Prese
private final AuthenticationClientFactory clientFactory;
private final PlaceController placeController;
private final SignInView view;
private final AuthenticationPlaceManagementController.Callback callback;
private final AuthenticationCallback callback;
public SignInActivity(SignInView view, AuthenticationClientFactory clientFactory,
AuthenticationPlaceManagementController.Callback callback, PlaceController placeController) {
AuthenticationCallback callback, PlaceController placeController) {
this.clientFactory = clientFactory;
this.placeController = placeController;
this.view = view;